Mailing-List: contact cygwin-developers-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT cygwin DOT com>
List-Help: <mailto:cygwin-developers-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT cygwin DOT com
Delivered-To: mailing list cygwin-developers AT cygwin DOT com
Date: Mon, 5 Aug 2002 11:36:32 -0400
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin-developers AT cygwin DOT com
Subject: Re: 1.3.13?
Message-ID: <20020805153632.GA5146@redhat.com>
Reply-To: cygwin-developers AT cygwin DOT com
Mail-Followup-To: cygwin-developers AT cygwin DOT com
References: <20020804195150 DOT GA3381 AT redhat DOT com> <124668090713 DOT 20020805140659 AT logos-m DOT ru> <20020805150600 DOT D3921 AT cygbert DOT vinschen DOT de> <20020805150553 DOT GA4844 AT redhat DOT com> <20020805172250 DOT G3921 AT cygbert DOT vinschen DOT de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020805172250.G3921@cygbert.vinschen.de>
User-Agent: Mutt/1.3.23.1i

On Mon, Aug 05, 2002 at 05:22:50PM +0200, Corinna Vinschen wrote:
>On Mon, Aug 05, 2002 at 11:05:53AM -0400, Chris Faylor wrote:
>> On Mon, Aug 05, 2002 at 03:06:00PM +0200, Corinna Vinschen wrote:
>> >cygthread::exit_thread() calls ExitThread(0).  The thread which calls
>> >exit_thread() - fhandler_tty.cc, process_output() - is a cygthread
>> >function, too.  Shouldn't exit_thread() actually call SuspendThread(0)
>> >instead?
>> 
>> Not if it truly wanted the thread to exit, no.  Suspending the thread
>> when it is going away anyway didn't seem like a good idea to me.
>
>Hmm, since the calling thread is a cygthread, it means that after calling
>exit_thread() there's a thread slot with no actual stub routine running.
>That doesn't sound like a good idea, too, somehow.

It's not going to be reused, though.  This should only be called in a
process exiting condition when the thread is exiting prior to the
process exiting.  It seemed slightly more efficient to just exit the
thread in this case.

cgf