Mailing-List: contact cygwin-developers-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT cygwin DOT com>
List-Help: <mailto:cygwin-developers-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT cygwin DOT com
Delivered-To: mailing list cygwin-developers AT cygwin DOT com
X-WM-Posted-At: avacado.atomice.net; Mon, 1 Jul 02 00:56:09 +0100
Message-ID: <002001c22091$b46b8fd0$0100a8c0@advent02>
From: "Chris January" <chris AT atomice DOT net>
To: <cygwin-developers AT cygwin DOT com>
References: <00a801c22036$1a7456b0$0100a8c0 AT advent02> <20020630171026 DOT GB32201 AT redhat DOT com> <01d901c22084$b7552e20$0100a8c0 AT advent02> <20020630223718 DOT GA3808 AT redhat DOT com> <002d01c2208a$11e8cb80$0100a8c0 AT advent02> <20020630231513 DOT GA4728 AT redhat DOT com>
Subject: Re: changes to fhandler_process.cc from 02/06/2002 should be reverted
Date: Mon, 1 Jul 2002 00:56:08 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2600.0000

> >>Ok, but you can't keep the shared memory for every process open for the
> >>duration of the life of a fhandler_process.  I don't know how to deal
> >>with this but using up lots of resources isn't the way to do it.
> >
> >Agreed, but the current code in CVS will actually crash when lseek is
> >called.  Incidentally, I believe that line 158 in fhandler_process.cc
> >can be removed.  My preferred solution to this would be to save the pid
> >as the original code did and add pinfo p (pid) in fill_filebuf.
>
> Yeah, I'd already put that back but actually, now that I think of it,
> keeping this open may actually be what we want to do.  Keeping it open
> will ensure that the shared memory will be around so the process will
> essentially stay around as long as you have the shared memory open...
> sort of.
I'll have to see what happens on Linux when a process goes away and it has
/proc entries open.

I have a patch for fhandler_registry.cc that I am working on at the moment
and will probably post tomorrow. It fixes a few bugs, but it also adds a
boolean return value to fill_filebuf which means that the test to see if a
process exists can be moved to that function. This is the way things are
with that patch as it stands, anyway.

Chris