Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com
Date: Mon, 22 Oct 2001 17:21:23 -0400
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin-developers AT cygwin DOT com
Subject: Re: miscfuncs.cc won't compile with --enable-debugging
Message-ID: <20011022172123.A11507@redhat.com>
Reply-To: cygwin-developers AT cygwin DOT com
Mail-Followup-To: cygwin-developers AT cygwin DOT com
References: <20011022202804 DOT 5132 DOT qmail AT lizard DOT curl DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20011022202804.5132.qmail@lizard.curl.com>
User-Agent: Mutt/1.3.21i

On Mon, Oct 22, 2001 at 04:28:04PM -0400, Jonathan Kamens wrote:
>Corinna checked a change in today which break miscfuncs.cc when
>--enable-debugging is used.  Here's a patch:

Thanks but I think that it makes sense for set_errno to always do the
same thing regardless of whether DEBUGGING is enabled.  I checked in
a patch to do this.

cgf

>Index: miscfuncs.cc
>===================================================================
>RCS file: /cvs/src/src/winsup/cygwin/miscfuncs.cc,v
>retrieving revision 1.7
>diff -u -r1.7 miscfuncs.cc
>--- miscfuncs.cc	2001/10/22 11:31:39	1.7
>+++ miscfuncs.cc	2001/10/22 20:26:55
>@@ -158,7 +158,7 @@
> __check_invalid_read_ptr_errno (const void *s, unsigned sz)
> {
>   if (!s || IsBadReadPtr ((void *) s, sz))
>-    return set_errno (EFAULT);
>+    set_errno (EFAULT);
> 
>-  return 0;
>+  return get_errno();
> }