Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com
Date: Wed, 5 Sep 2001 12:14:16 +0200
From: Corinna Vinschen <vinschen AT redhat DOT com>
To: egor duda <cygwin-developers AT cygwin DOT com>
Subject: Re: fhandler_dev_floppy::lseek
Message-ID: <20010905121416.D30380@cygbert.vinschen.de>
Reply-To: cygdev <cygwin-developers AT cygwin DOT com>
Mail-Followup-To: egor duda <cygwin-developers AT cygwin DOT com>
References: <20010904175339 DOT H2419 AT cygbert DOT vinschen DOT de> <12176562263 DOT 20010905134453 AT logos-m DOT ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <12176562263.20010905134453@logos-m.ru>; from deo@logos-m.ru on Wed, Sep 05, 2001 at 01:44:53PM +0400

On Wed, Sep 05, 2001 at 01:44:53PM +0400, egor duda wrote:
> Hi!
> 
> Tuesday, 04 September, 2001 Corinna Vinschen vinschen AT redhat DOT com wrote:
> 
> CV> On 2001-02-28 you checked in a patch to fhandler_floppy.cc
> CV> (fhandler_dev_floppy::lseek) to determine the drive geometry.
> 
> CV> For some reason you added that using a `if (os_being_run == winNT)'
> CV> which in the meantime has been substituted by Chris by a `is (iswinnt)'.
> 
> CV> However, I don't understand why it's used at all. As far as I know
> CV> and from what I've read in MSDN, raw device access is not supported
> CV> on 9x/ME. So the above `if' wouldn't make any sense.
> 
> i'm  not sure w9x always perform appropriate parameter checking when
> driver ioctl is called. it may just crash. 
> 
> CV> The reason I'm asking is that I'm creating a OS capability class
> CV> to change all these if's to a more capability oriented view.
> CV> In the above case that could be handled by e.g.
> 
> CV>         if (wincap.can_determine_drive_geometry ())
> 
> CV> or something but if it's unneccessary I would better like to get
> CV> rid of this `if' at all.
> 
> well, i don't really know. the reason i've added this check was
> "better safe that sorry". maybe it's really unnecessary. i just don't
> fully trust MS in such matters.

Ok, thanks for that info. I will remove that check since 9x/ME will
already fail trying to open \\.\X:

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.