Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com
Message-ID: <001201c0fcaa$4f55b230$6464648a@ca.boeing.com>
From: "Michael A. Chase" <mchase AT ix DOT netcom DOT com>
To: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>,
        <cygwin-developers AT sources DOT redhat DOT com>
References: <04e801c0faa2$f9008260$0200a8c0 AT lifelesswks> <20010621222615 DOT C13746 AT redhat DOT com> <3B3324A7 DOT 49FFC98A AT yahoo DOT com> <054c01c0fbef$5f600e20$0200a8c0 AT lifelesswks> <06a001c0fc51$7a87e210$0200a8c0 AT lifelesswks>
Subject: Re: hierarchy in setup (category stuff)
Date: Sun, 24 Jun 2001 05:35:22 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4133.2400
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400

I'd like to suggest a minor format change in part of your patch:

      log (LOG_BABBLE, "[%s] action=%s trust=%s installed=%s excluded=%s"
    " src?=%s category=%s",
      pkg->name, action, trust, installed, excluded,
     pkg->srcpicked ? "yes" : "no", pkg->category);

This adds a space before "category" and makes the first line less than 80
characters long.

I've been compiling and running setup.exe with both our patches applied.  I
had to hand apply 4 hunks in choose.cc, but they were fairly simple.
Applying my patch after yours is more complicated, so if mine is approved,
I'll send you a patch for choose.cc to resolve the differences from your
latest hierarchy patch.
--
Mac :})
Give a hobbit a fish and he eats fish for a day.
Give a hobbit a ring and he eats fish for an age.