Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT sourceware DOT cygnus DOT com>
List-Archive: <http://sourceware.cygnus.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sourceware DOT cygnus DOT com>
List-Help: <mailto:cygwin-developers-help AT sourceware DOT cygnus DOT com>, <http://sourceware.cygnus.com/ml/#faqs>
Sender: cygwin-developers-owner AT sourceware DOT cygnus DOT com
Delivered-To: mailing list cygwin-developers AT sourceware DOT cygnus DOT com
From: Chris Faylor <cgf AT cygnus DOT com>
Date: Tue, 15 Feb 2000 19:08:56 -0500
To: Corinna Vinschen <corinna AT vinschen DOT de>
Cc: cygwin-developers AT sourceware DOT cygnus DOT com, Reinhard Nissl <rnissl AT gmx DOT de>
Subject: Re: cygwin-src-20000125: patch to not convert cmdline to OEM
Message-ID: <20000215190856.A12211@cygnus.com>
Reply-To: cygwin-developers AT sourceware DOT cygnus DOT com
References: <38A6E0D9 DOT 442DD5E9 AT gmx DOT de> <20000214165303 DOT A18925 AT cygnus DOT com> <38A9E4AF DOT 5E7C26BF AT vinschen DOT de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.1.3i
In-Reply-To: <38A9E4AF.5E7C26BF@vinschen.de>; from corinna@vinschen.de on Wed, Feb 16, 2000 at 12:43:43AM +0100

On Wed, Feb 16, 2000 at 12:43:43AM +0100, Corinna Vinschen wrote:
>Chris Faylor wrote:
>> On Sun, Feb 13, 2000 at 05:50:33PM +0100, Reinhard Nissl wrote:
>> >the attached patch makes cygwin1.dll only convert the cmdline to OEM when the
>> >environment variable CYGWIN_CMD_LINE_MODE is not set to ANSI. If the variable
>> >doesn't exist or is set to anything else then ANSI, the library behaves as it
>> >did before applying the patch.
>> > [...]
>> I have a few problems with this patch.
>> [...]
>> 4) I am wondering if the conditional behavior of this code should actually be
>>    the default behavior, i.e., should we always be using SetFileApisToANSI and
>>    MultiByteToWideChar.
>> 
>> 1 - 3 are obviously easy to fix but I'd like to get a better feel for 3.
									 4.