Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-developers-owner AT sourceware DOT cygnus DOT com
Delivered-To: mailing list cygwin-developers AT sourceware DOT cygnus DOT com
From: Chris Faylor <cgf AT cygnus DOT com>
Date: Thu, 29 Apr 1999 17:20:18 -0400
To: Mumit Khan <khan AT xraylith DOT wisc DOT EDU>
Cc: cygwin-developers AT sourceware DOT cygnus DOT com
Subject: Re: (patch) reg_key copy construction bug
Message-ID: <19990429172018.D13241@cygnus.com>
References: <199904292008 DOT PAA23228 AT modi DOT xraylith DOT wisc DOT edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.95.3i
In-Reply-To: <199904292008.PAA23228@modi.xraylith.wisc.edu>; from Mumit Khan on Thu, Apr 29, 1999 at 03:08:36PM -0500

Applied.

I have to note that my cygwin1.dll is not crashing on startup, however.
That is not new code, is it?  Hasn't it been there for years/

Thanks,
-chris

On Thu, Apr 29, 1999 at 03:08:36PM -0500, Mumit Khan wrote:
>The following fix is hopefully obvious. Think of what happens when you 
>pass a copy of a (open) reg_key to a function -- it calls the destructor 
>on the way back, and so the does the original and RegClose crashes trying.
>
>The current implementation of reg_key is dangerous in that it blindly
>allows a copy construction;  it should really disable copying by using
>a private copy. However that'll break the subkey generation, so it'll 
>take a bit of rework.
>
>The current code should always crash in mount_info::from_registry ()
>when Cygwin1.dll starts up.