From: corinna DOT vinschen AT cityweb DOT de (Corinna Vinschen)
Subject: b20.1 [was Re: console mode and \r, \n, etc.]
6 Dec 1998 16:30:55 -0800
Message-ID: <366B1C28.304C79E1.cygnus.cygwin32.developers@cityweb.de>
References: <19981203112448 DOT A10350 AT cygnus DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: Christopher Faylor <cgf AT cygnus DOT com>, cygwin32-developers AT cygnus DOT com

Wow!

From ChangeLog of 20.1:

Thu Dec  3 15:30:44 1998  Christopher Faylor <cgf AT cygnus DOT com>

        * select.cc (peek_console): Work around NT bug that
        caused strange behavior with ReadFile after this
        function was invoked.

How did you find, that this is a solution?
Is it a final solution or a temporary workaround?

This let fhandler_console work as expected. Also the problem
which conducts to this mail thread is removed by this patch.

Unfortunately there's still a bug in fhandler_console.cc.
In line 396, ISIG is or'd to t->c_iflags instead of t->c_lflags.

Regards,
Corinna

ChangeLog:
==========

Sun Dec  6 23:28:08 1998  Corinna Vinschen <corinna DOT vinschen AT cityweb DOT de>

	* fhandler_console.cc (fhandler_console::tcgetattr)
	In case of ENABLE_PROCESSED_INPUT, ISIG is now or'd to c_lflag
	instead of c_iflag.

Index: fhandler_console.cc
===================================================================
RCS file: /src/cvsroot/winsup-981126/fhandler_console.cc,v
retrieving revision 1.3
diff -u -p -r1.3 fhandler_console.cc
--- fhandler_console.cc 1998/12/02 23:38:50     1.3
+++ fhandler_console.cc 1998/12/06 23:28:08
@@ -393,7 +393,7 @@ fhandler_console::tcgetattr (termios *t)
        t->c_lflag |= ICANON;

       if (flags & ENABLE_PROCESSED_INPUT)
-       t->c_iflag |= ISIG;
+       t->c_lflag |= ISIG;

       /* What about ENABLE_WINDOW_INPUT
         and ENABLE_MOUSE_INPUT   ? */