From: cgf AT cygnus DOT com (Christopher Faylor) Subject: Re: handling file attributes 24 Oct 1998 18:07:22 -0700 Message-ID: <19981024203312.A12.cygnus.cygwin32.developers@cygnus.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Kazuhiro Fujieda , cygwin32-developers AT cygnus DOT com On Sat, Oct 24, 1998 at 10:53:40PM +0900, Kazuhiro Fujieda wrote: >> >The exec flag set by this code is used only to skip checking a >> >file suffix in fhandler.cc:1064-1066. get_file_attribute() is >> >too heavy for this purpose becase it read NTEA. These code can >> >be eliminted safly. >> >> Unless I'm missing something the exec`flag set there is used >> in a number of places that use path_conv. > >I checked carefully once agin, but I couldn't find another place >using the exec flag. The exec flag of the path_conv class seems >not to have curucial meaning differently from of the fhandler_base >class. My reading of the code implies that real_path.exec_p will be used, specifically in the section of code which you just changed. If we eliminate setting it in symlink_check_one it it sure seems to me that the !real_path.exec_p test in fhandler_disk_file::open will always be true unless the file has an executable extension. cgf