Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To: cygwin-apps AT cygwin DOT com
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
Message-ID: <3D032B54.5@scytek.de>
Date: Sun, 09 Jun 2002 12:17:56 +0200
From: Volker Quetschke <quetschke AT scytek DOT de>
User-Agent: Mozilla/5.0 (Windows; U; Win98; de-DE; rv:0.9.4) Gecko/20011019 Netscape6/6.2
X-Accept-Language: de-DE
MIME-Version: 1.0
To: cygwin-apps AT cygwin DOT com
Subject: Re: package offering: gnupg
References: <3D01D259 DOT 9080508 AT scytek DOT de> <8657450619 DOT 20020608141448 AT familiehaase DOT de> <20020608154613 DOT GB15922 AT redhat DOT com> <3D0250BA DOT 3000201 AT netscape DOT net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi!

> I think Chuck better look at the buildscript, there seem to be a couple 
> of (unnecessary?)kludges throughout the script.  For instance, 
> re-autoconfilizing the autoscripts shouldn't be a necessary step in the 
> user build process.  You should do that ahead of time, delete the 
> autom4ate.cache and other garbage, then make a diff against the 
> results...

Yes, but this way it keeps the diff small. I can remove the autoconf garbage
via the install script, but I thought the source package is for developers
they should know what they do. I should change the "Build instructions" part
of gnupg.README to:
-------------
Build instructions:
   unpack gnupg-1.0.7-X-src.tar.bz2
     if you use setup to install this src package, it will be
	 unpacked under /usr/src automatically

- To rebuild the binary and sourrce archiv type:
$ cd /usr/src
$ ./gnupg-1.0.7-1.sh all

This will create:
   /usr/src/gnupg-1.0.7-X.tar.bz2
   /usr/src/gnupg-1.0.7-X-src.tar.bz2

- To get the modified source to build the cygwin executables type:
$ cd /usr/src
$ ./gnupg-1.0.7-1.sh prep

This will unpack and patch gnupg to:
   /usr/src/gnupg-1.0.7-X
-------------

After the prep you can change, patch or modify whatever you like and issue
a "./gnupg-1.0.7-1.sh spkg" afterwards. You will get a small gnupg-1.0.7-1.diff
in a new source package. Befor your next "gnupg-1.0.7-1.sh all" just remove
"gnupg-1.0.7-X.*" .

> There are a few other things that could be improved in the 
> source package ( but I'll leave it to the veteran package maintainers to 
> comment ), but AFAICT the binary package works fine.


If the preferable way is a big patch and no auto* stuff, just say so and I
will change it. Also please name any problem in the source package.

Bye
    Volker