Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm Sender: cygwin-apps-owner AT cygwin DOT com List-Subscribe: List-Archive: List-Post: List-Help: , Delivered-To: mailing list cygwin-apps AT cygwin DOT com Message-ID: <3C8F1258.50600@ece.gatech.edu> Date: Wed, 13 Mar 2002 03:48:24 -0500 From: Charles Wilson User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.4) Gecko/20011019 Netscape6/6.2 X-Accept-Language: en-us MIME-Version: 1.0 To: Pavel Tsekov CC: cygwin-apps AT cygwin DOT com Subject: Re: [PATCH suggestion] aclocal wrapper script loops forever if automake-devel or automake-stable is missing References: <416981789 DOT 20020312131817 AT syntrex DOT com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Pavel Tsekov wrote: > Hey, there! :) > > Does the attached patch make any sense ? It prevents an infinite loop > if either automake-devel or automake-stable is missing. > Yes, it does -- of course, setup enforces that automake depends on automake-devel and automake-stable, so if you see this error it's because you've overridden setup.exe... Or you set the AUTO_STABLE / AUTO_DEVEL environment variables (incorrectly). I've incorporated your suggestions into the next version of the wrappers. However, as a general note, there are a few problems with your submission: 1) you patched a generated file, not a source file (aclocal is created from aclocal.in in the automake -src package). 2) you only patched one of the files -- but all scripts exhibit this behavior. You'd actually need to provide similar patches for automake: aclocal.in automake.in autoconf: autoconf.in autoupdate.in autoreconf.in autoheader.in autoscan.in ifnames.in libtool: libtool.in libtoolize.in 3) No ChangeLog entry I have done all of the above, so no worries this time. However, next time... --Chuck