Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
Message-ID: <026501c1a6fd$95bc5910$0200a8c0@lifelesswks>
From: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>
To: <cygwin-apps AT sources DOT redhat DOT com>
Subject: setup crashing - fixed?
Date: Sun, 27 Jan 2002 17:41:00 +1100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2600.0000
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000
X-OriginalArrivalTime: 27 Jan 2002 06:40:56.0410 (UTC) FILETIME=[92DEDBA0:01C1A6FD]

Right, I think I found the cause. At least I can successfully download
from *every* available site, and before I had repeatable problems doing
that.

Corinna, can you CVS update and try a fresh build?

I found a bug that could have caused the issue:

site (char const *newkey)
{
  key = new char[strlen (newkey + 1)];
                               ^^^^^
    strcpy (key, newkey);
};

However, fixing that DID NOT fix the problem (although I had isolated
the fault to this constructor by means of replacement new and new[]
calls using HeapAlloc, combined with HeapValidate().)

Moving the constructor body out of the header fixed the problem. I don't
have time to generate a testcase, but if anyone does have time, I'm sure
the gcc team would appreciate knowing about this. The fault occured when
that constructor was called from a template instantiation of list.h.

Rob