Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
Message-ID: <08c001c1a2f3$b9cae8c0$0200a8c0@lifelesswks>
From: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>
To: "Michael A Chase" <mchase AT ix DOT netcom DOT com>,
   "Cygwin-Apps" <cygwin-apps AT sources DOT redhat DOT com>
References: <20020118180305 DOT GA2312 AT dothill DOT com> <0a3501c1a074$07c97be0$0200a8c0 AT lifelesswks> <001401c1a237$c1ebc680$a100a8c0 AT mchasecompaq> <000e01c1a23d$2cba5bc0$a100a8c0 AT mchasecompaq> <046201c1a24b$8e8cbec0$0200a8c0 AT lifelesswks> <008c01c1a2a9$89121180$a100a8c0 AT mchasecompaq>
Subject: Re: Low-level progress messages in setup.log
Date: Tue, 22 Jan 2002 14:20:20 +1100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2600.0000
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000
X-OriginalArrivalTime: 22 Jan 2002 03:22:14.0679 (UTC) FILETIME=[FCE65270:01C1A2F3]

----- Original Message -----
From: "Michael A Chase" <mchase AT ix DOT netcom DOT com>

> > Sure. note that ~io_stream called belongs in setup.log.
>
> It definitely goes there now, but what benefit are we gaining by
having
> low-level progress messages in the permanent log?  I thought that was
what
> setup.log.full was for.

If someone other than I adds a new io_stream class, they may (for
whatever reason) not override the destructor. All other functions are
abstract, forcing an implementation, but the destructor cannot be
abstract.

> My original thought was to go through the source files and basically
change
> any log() calls that said 'called' or 'peeked' or similar low-level
progress
> indicators and change them from LOG_TIMESTAMP to either LOG_BABBLE or
> LOG_TIMESTAMP | LOG_BABBLE.  If some of those progress messages are
meant to
> be in setup.log, I'll need to know what policy to follow.  Just a hint
for
> now and we can finalize the plan when you see some of my patches.

For the peeked/called etc, yes they can be trimmed down, or even
eliminated (ie #ifdef DEBUG) as appropriate. They were my in-development
code debug output, and aren't really needed now :].

> It's going to take me quite a while to get really up to speed, so if
you
> have any repetative work that you haven't found time for, I'd be glad
to
> handle those for you.

Not really. There's a number of small nitpicky things in README that
need doing - new views and the like. There's also the nasty bug that is
affecting corinna, and is most probably heap corruption, but I'm
b****gered if I can figure out where it's occuring.

One useful and fairly trivial hack to get back in touch would be to move
the downloaded files from the site/path to simply path/, to allow
greatest possible hit rate when folk select different mirrors.

Rob