Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
Message-ID: <5DABF7424840D411BE9600508B6621F803794DD7@exchukthis02.experian.co.uk>
From: "Ebrey, Carl" <Carl DOT Ebrey AT uk DOT experian DOT com>
To: "'cygwin-apps AT cygwin DOT com'" <cygwin-apps AT cygwin DOT com>
Subject: RE: FIGlet (again)
Date: Wed, 12 Dec 2001 15:25:11 -0000
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2653.19)
Content-Type: text/plain

Hi Corinna,

I've changed the packages and updated the website.  Binaries are now in
/usr/bin and the figletfonts are in /usr/share.  Source is relative to the
current dir (no /usr/src prefix).

Don't worry about being nitpicky, it took all of 3 minutes to make the
changes ;)  One thing that I would point out though is that the fourth point
under http://cygwin.com/setup.html#package_contents says, "Source packages
are extracted in /usr/src".  Am I reading this wrong?

Cheers,

Carl

-----Original Message-----
From: Corinna Vinschen [mailto:vinschen AT redhat DOT com]
Sent: Wednesday, December 12, 2001 2:17 PM
To: Ebrey, Carl
Cc: cygapp
Subject: Re: FIGlet (again)


On Wed, Dec 12, 2001 at 11:32:16AM -0000, Ebrey, Carl wrote:
> Hi again everyone,
> 
> I was wondering if anyone has had chance to look at the package I put up
at
> http://straylight.eu.org/~carl/figlet/ to see if it was suitably done for
> inclusion in Cygwin.  I've had another look at
http://cygwin.com/setup.html
> and I'm fairly sure that what I've produced is satisfactory according to
> that.
> 
> Has anyone found any gaping holes that I've missed, or is it ok to be
> included?

Sorry but I have to be nitpicking here.

Could you please rebuild it using other paths?

The binaries are still in usr/local/bin whereas they should be
in usr/bin.  The subdir `figletfonts' is in usr/lib whereas
I would expect it under usr/share.  Look into the second point
of http://cygwin.com/setup.html#package_contents.

The sources dir in the source package is `usr/src/figlet22'
which is contrary to GNU and Cygwin packaging rules.  Don't
prepend the `usr/src' path and rename the source directory
so that it's identical to the Cygwin version:

	figlet-2.2-1/...

instead of

	usr/src/figlet22/...

according to the forth point under the above URL.

The setup.hint file is ok, AFAICS.

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.


=======================================================================
Information in this email and any attachments are confidential, and may
not be copied or used by anyone other than the addressee, nor disclosed
to any third party without our permission.  There is no intention to
create any legally binding contract or other commitment through the use
of this email.

Experian Limited (registration number 653331).  
Registered office: Talbot House, Talbot Street, Nottingham NG1 5HF