Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
Date: Wed, 12 Dec 2001 15:17:21 +0100
From: Corinna Vinschen <vinschen AT redhat DOT com>
To: "Ebrey, Carl" <Carl DOT Ebrey AT uk DOT experian DOT com>
Cc: cygapp <cygwin-apps AT cygwin DOT com>
Subject: Re: FIGlet (again)
Message-ID: <20011212151721.D1104@cygbert.vinschen.de>
Reply-To: cygwin-apps AT cygwin DOT com
Mail-Followup-To: "Ebrey, Carl" <Carl DOT Ebrey AT uk DOT experian DOT com>,
	cygapp <cygwin-apps AT cygwin DOT com>
References: <5DABF7424840D411BE9600508B6621F803794DCE AT exchukthis02 DOT experian DOT co DOT uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <5DABF7424840D411BE9600508B6621F803794DCE@exchukthis02.experian.co.uk>; from Carl.Ebrey@uk.experian.com on Wed, Dec 12, 2001 at 11:32:16AM -0000

On Wed, Dec 12, 2001 at 11:32:16AM -0000, Ebrey, Carl wrote:
> Hi again everyone,
> 
> I was wondering if anyone has had chance to look at the package I put up at
> http://straylight.eu.org/~carl/figlet/ to see if it was suitably done for
> inclusion in Cygwin.  I've had another look at http://cygwin.com/setup.html
> and I'm fairly sure that what I've produced is satisfactory according to
> that.
> 
> Has anyone found any gaping holes that I've missed, or is it ok to be
> included?

Sorry but I have to be nitpicking here.

Could you please rebuild it using other paths?

The binaries are still in usr/local/bin whereas they should be
in usr/bin.  The subdir `figletfonts' is in usr/lib whereas
I would expect it under usr/share.  Look into the second point
of http://cygwin.com/setup.html#package_contents.

The sources dir in the source package is `usr/src/figlet22'
which is contrary to GNU and Cygwin packaging rules.  Don't
prepend the `usr/src' path and rename the source directory
so that it's identical to the Cygwin version:

	figlet-2.2-1/...

instead of

	usr/src/figlet22/...

according to the forth point under the above URL.

The setup.hint file is ok, AFAICS.

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.