Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
Message-ID: <0ccf01c144ce$f98613f0$0200a8c0@lifelesswks>
From: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>
To: <gp AT familiehaase DOT de>, <cygwin-apps AT cygwin DOT com>
References: <3BAEF8B3 DOT 1419 DOT 46100EBC AT localhost>
Subject: Re: new 'temp' directory in CVS cinstall contains dependency WIP
Date: Mon, 24 Sep 2001 18:00:27 +1000
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4133.2400
X-MIMEOLE: Produced By Microsoft MimeOLE V5.50.4133.2400
X-OriginalArrivalTime: 24 Sep 2001 08:08:23.0498 (UTC) FILETIME=[14BE32A0:01C144D0]

please try this patch (with or without the other).

It should fix the infinite recursion.

The bug is a boundary case, where inserting into the last category, with
a package that is after all the other packages results in the boundary
moving back 1 step for every insert. Ouch.

The strcasecmp problem in mingw is still an issue :}, but it might just
be a stack exhaustion problem.

Rob

Index: choose.cc
===================================================================
RCS file: /cvs/src/src/winsup/cinstall/choose.cc,v
retrieving revision 2.47
diff -u -p -r2.47 choose.cc
--- choose.cc 2001/08/05 01:38:46 2.47
+++ choose.cc 2001/09/24 07:58:58
@@ -803,7 +803,10 @@ _view::insert_pkg (Package *pkg)
        /* this should be a generic call to list_sort_cmp */
        if (lines[n].get_category ()
     && cat->name == lines[n].get_category ()->name)
+  {
     insert_under (n, line);
+    n++;
+  }
        n++;
      }
    if (n == nlines)