Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
Date: Sat, 17 Mar 2001 21:58:28 -0500
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin-apps AT cygwin DOT com
Subject: Re: gcc 2.95.3-1 and -mwin32
Message-ID: <20010317215828.A28473@redhat.com>
Reply-To: cygwin-apps AT cygwin DOT com
Mail-Followup-To: cygwin-apps AT cygwin DOT com
References: <20010317172830 DOT A24346 AT redhat DOT com> <011b01c0af4b$62f44ec0$0200a8c0 AT voyager> <014301c0af4f$ec386550$0200a8c0 AT lifelesswks>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.11i
In-Reply-To: <014301c0af4f$ec386550$0200a8c0@lifelesswks>; from robert.collins@itdomain.com.au on Sun, Mar 18, 2001 at 01:05:34PM +1100

On Sun, Mar 18, 2001 at 01:05:34PM +1100, Robert Collins wrote:
>> w32api/windef.h
>>
>> #ifndef WIN32
>> #define WIN32
>> #endif
>> #ifndef _WIN32
>> #define _WIN32
>> #endif
>>
>> Comments?
>
>I don't think the software being ported should ever define WIN32 itself.
>It'd be like defining glibc_version (or whatever that value is called)
>yourself.
>
>Setting it for gcc is one thing, and quite appropriate. As far as w32api
>goes, I haven't investigated and thus won't comment..

Including /usr/include/w32api and not allowing the header files to define
WIN32 constants would be equivalent to not including /usr/include/w32api
at all.  The users would get confusing error messages.

Microsoft's windows headers seem to define WIN32 constants in a number of
places.  I don't see anything wrong with this practice.

cgf