Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To: cygwin-apps AT cygwin DOT com
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
Date: Tue, 28 May 2002 13:44:02 -0400
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin-apps AT cygwin DOT com, binutils AT sources DOT redhat DOT com
Subject: Re: question about objdump output format ?
Message-ID: <20020528174402.GA2897@redhat.com>
Reply-To: cygwin-apps AT cygwin DOT com
Mail-Followup-To: cygwin-apps AT cygwin DOT com, binutils AT sources DOT redhat DOT com
References: <m3u1osbn1c DOT fsf AT north-pole DOT nickc DOT cambridge DOT redhat DOT com> <003e01c2063a$384808f0$651c440a AT BRAMSCHE>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <003e01c2063a$384808f0$651c440a@BRAMSCHE>
User-Agent: Mutt/1.3.23.1i

On Tue, May 28, 2002 at 01:24:24PM +0200, Ralf Habacker wrote:
>> Hi Ralf,
>>
>> > Here is the patch. It is based on the "objdump_ai_segfault_2.patch",
>> > which I have send in before.
>
>See note below
>
>> >
>> > Changelog entry for bfd dir ----------------------
>> >
>> > 2002-05-22 Ralf Habacker <ralf DOT habacker AT freenet DOT de>
>> >
>> >   * peXXigen.c (pe_print_idata()): removed double printed
>> >   import table lines, added Bound-To comment.
>> >
>> > I hope, the changelog entry is clear. It may be, that the indents
>> > ate 100% pure, please correct if necessary
>>
>> Unfortunately I have some problems with this patch:
>>
>>   * It does not apply against the current sources in the CVS
>>     repository.  In fact it is not even close.  There has been some
>>     recent work on this code by Laurent Pinchart
>>     <laurent DOT pinchart AT skynet DOT be> which chnages the layout for the
>>     code.
>
>This patch is based on Laurants work (peXXigen.c cvs version 1.7) and(1) on the
>patch in
>http://www.cygwin.com/ml/cygwin-apps/2002-05/msg00346.html, which fixes some
>additional seg fault fixes relating to auto-import.
>It is called "objdump_ai_segfault_2.patch" on the top of this mail and is also
>based on Laurants work.
>
>So this is the way:
>
>1. apply objdump_ai_segfault_2 patch
>
>2. apply objdump_no_double_import_table_printing patch.
>
>I have send patch (1) to binutils and cygwin-apps, but unfortunally noone has
>checked this in.

I was waiting for success reports from someone besides you.

Regardless, basic patch management would dictate that you provide
patches against plain CVS.  You shouldn't expect maintainers to apply
unrelated patches in order to check your changes in.

cgf