Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To: cygwin-apps AT cygwin DOT com
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
Date: Mon, 06 May 2002 10:56:30 -0400
From: Jason Tishler <jason AT tishler DOT net>
Subject: Re: rebasing new packages?!
In-reply-to: 
 <FC169E059D1A0442A04C40F86D9BA7600C5FAE AT itdomain003 DOT itdomain DOT net DOT au>
To: Robert Collins <robert DOT collins AT itdomain DOT com DOT au>
Cc: cygwin-apps AT cygwin DOT com
Mail-followup-to: Robert Collins <robert DOT collins AT itdomain DOT com DOT au>,
 cygwin-apps AT cygwin DOT com
Message-id: <20020506145630.GM1668@tishler.net>
MIME-version: 1.0
Content-type: multipart/mixed; boundary="Boundary_(ID_5yr6vdU2qiiMJewC9anGrA)"
User-Agent: Mutt/1.3.24i
References: <FC169E059D1A0442A04C40F86D9BA7600C5FAE AT itdomain003 DOT itdomain DOT net DOT au>


--Boundary_(ID_5yr6vdU2qiiMJewC9anGrA)
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7BIT
Content-disposition: inline

Rob,

On Sat, May 04, 2002 at 09:37:48AM +1000, Robert Collins wrote:
> > -----Original Message-----
> > From: Jason Tishler [mailto:jason AT tishler DOT net] 
> > Sent: Saturday, May 04, 2002 3:34 AM
> > 
> > Can we remove the "-Werror" option and start using STL in setup.exe?
> 
> [snip]
>
> Perhaps removing the explicit inline from the definition is appropriate?

Bingo.  That fixed the problem.  Sorry, for being sloppy.

Should I send the attached patch to the Cygwin gcc maintainer?

> (-O3 will automatically inline it, and probably get that warning again,
> but casual users would be safe.

I tried the "-O3" option and the warning did *not* occur.

If the attached patch is accepted, can I start using STL in setup.exe
now?

Thanks,
Jason

--Boundary_(ID_5yr6vdU2qiiMJewC9anGrA)
Content-type: text/plain; charset=us-ascii; NAME=stl_tree.h.diff
Content-transfer-encoding: 7BIT
Content-disposition: attachment; filename=stl_tree.h.diff

--- stl_tree.h.orig	Mon May  6 10:38:33 2002
+++ stl_tree.h	Mon May  6 10:38:52 2002
@@ -1253,7 +1253,7 @@ _Rb_tree<_Key, _Value, _KoV, _Compare, _
                                              upper_bound(__k));
 }
 
-inline int 
+int 
 __black_count(_Rb_tree_node_base* __node, _Rb_tree_node_base* __root)
 {
   if (__node == 0)

--Boundary_(ID_5yr6vdU2qiiMJewC9anGrA)--