Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To: cygwin-apps AT cygwin DOT com
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
From: "Gary R. Van Sickle" <g DOT r DOT vansickle AT worldnet DOT att DOT net>
To: <cygwin-apps AT cygwin DOT com>
Subject: RE: Patch for Setup.exe problem and for mklink2.cc
Date: Wed, 27 Mar 2002 21:25:35 -0600
Message-ID: <NCBBIHCHBLCMLBLOBONKKEGCCMAA.g.r.vansickle@worldnet.att.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
In-Reply-To: <FC169E059D1A0442A04C40F86D9BA76008ABCD@itdomain003.itdomain.net.au>
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000
Importance: Normal

[snip]
> >
> > There have been a few of these off-by-ones in Setup.  Is it
> > possible your habit of using 1-based arrays is a contributing
> > factor Rob?  This isn't a convention I see much (modulo
> > "Numerical Recipies"); is there a reason you use this convention?
>
> Errm, there aren't any 1 based arrayts at the moment IIRC. Are do you
> mean the list class with the index postion as the parameter?

Yes, I believe that's one of the places I was referring to.  Also, I was
(incorrectly it turns out) thinking of this from choose.cc(listview_proc):

...
for (int i = 1; i <= chooser->last_col; i++)
  chooser->headers[i].x =
    chooser->headers[i - 1].x + chooser->headers[i - 1].width;
...

I spotted this just last night, but of course there's nothing 1-based there.

Yes.  Well then, carry on. ;-)

--
Gary R. Van Sickle
Brewer.  Patriot.