Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To: cygwin-apps AT cygwin DOT com
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
content-class: urn:content-classes:message
Subject: RE: Patch for Setup.exe problem and for mklink2.cc
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Date: Thu, 28 Mar 2002 07:21:02 +1100
Message-ID: <FC169E059D1A0442A04C40F86D9BA76008ABCD@itdomain003.itdomain.net.au>
X-MimeOLE: Produced By Microsoft Exchange V6.0.5762.3
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
From: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>
To: "Gary R Van Sickle" <tiberius AT braemarinc DOT com>, <cygwin-apps AT cygwin DOT com>
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id g2RKLKO23347



> -----Original Message-----
> From: cygwin-apps-owner AT cygwin DOT com 
> [mailto:cygwin-apps-owner AT cygwin DOT com] On Behalf Of Gary R Van Sickle
> Sent: Thursday, March 28, 2002 4:48 AM
> To: cygwin-apps AT cygwin DOT com
> Subject: RE: Patch for Setup.exe problem and for mklink2.cc
> 
> 
> [snip]
>  
> > > Found the problem causing the segment violation and probably
> > > causing Jonas Eriksson's problem. It is a typical case of 
> > > 'off by 1'. In PickView::set_headers the loop filling the 
> > > window header does one iteration too much, resulting in a 
> > > call to DoInsertItem with a NULL string pointer and hence a 
> > > crash following. While debugging this I could not compile the 
> > > new mklink2.cc ( the
> > > c++ version of the original mklink2.c). It seems three &
> > (address of
> > > c++ operator)
> > > have disappeared in the transition. Putting them back made
> > > the compiler happy. Is this OK Robert ?
> > 
> > I'll check the off-by-one fix in tomorrow, as I'm off to bed now.
> > 
> 
> [snip]
> 
> There have been a few of these off-by-ones in Setup.  Is it 
> possible your habit of using 1-based arrays is a contributing 
> factor Rob?  This isn't a convention I see much (modulo 
> "Numerical Recipies"); is there a reason you use this convention?

Errm, there aren't any 1 based arrayts at the moment IIRC. Are do you
mean the list class with the index postion as the parameter?

Well that's different, uhmm, yeah, yeah it is.

Rob