Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
Message-ID: <008c01c1a2a9$89121180$a100a8c0@mchasecompaq>
From: "Michael A Chase" <mchase AT ix DOT netcom DOT com>
To: "Cygwin-Apps" <cygwin-apps AT sources DOT redhat DOT com>
References: <20020118180305 DOT GA2312 AT dothill DOT com> <0a3501c1a074$07c97be0$0200a8c0 AT lifelesswks> <001401c1a237$c1ebc680$a100a8c0 AT mchasecompaq> <000e01c1a23d$2cba5bc0$a100a8c0 AT mchasecompaq> <046201c1a24b$8e8cbec0$0200a8c0 AT lifelesswks>
Subject: Re: Low-level progress messages in setup.log
Date: Mon, 21 Jan 2002 10:27:09 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2600.0000
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000

----- Original Message -----
From: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>
To: "Michael A Chase" <mchase AT ix DOT netcom DOT com>; "Cygwin-Apps"
<cygwin-apps AT sources DOT redhat DOT com>
Sent: Sunday, January 20, 2002 23:16
Subject: Re: Low-level progress messages in setup.log


>
> ===
> ----- Original Message -----
> From: "Michael A Chase" <mchase AT ix DOT netcom DOT com>
> To: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>; "Cygwin-Apps"
> <cygwin-apps AT sources DOT redhat DOT com>
> Sent: Monday, January 21, 2002 4:33 PM
> Subject: Low-level progress messages in setup.log
>
>
> > log() appears to be called for a lot of progress messages without
> > LOG_BABBLE.  This causes the messages to be saved in both setup.log
> and
> > setup.log.full.  "io_stream::~io_stream called" in io_stream.cc in
> > particular
> > adds a lot of bulk to setup.log.
> >
> > I think I can identify many of those low-level progress messages that
> would
> > be better not included in setup.log.  Would you be interested in a
> patch?
>
> Sure. note that ~io_stream called belongs in setup.log.


It definitely goes there now, but what benefit are we gaining by having
low-level progress messages in the permanent log?  I thought that was what
setup.log.full was for.

My original thought was to go through the source files and basically change
any log() calls that said 'called' or 'peeked' or similar low-level progress
indicators and change them from LOG_TIMESTAMP to either LOG_BABBLE or
LOG_TIMESTAMP | LOG_BABBLE.  If some of those progress messages are meant to
be in setup.log, I'll need to know what policy to follow.  Just a hint for
now and we can finalize the plan when you see some of my patches.

It's going to take me quite a while to get really up to speed, so if you
have any repetative work that you haven't found time for, I'd be glad to
handle those for you.
--
Mac :})
** I normally forward private questions to the appropriate mail list. **
Give a hobbit a fish and he eats fish for a day.
Give a hobbit a ring and he eats fish for an age.