DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 5ARLBsSk3965089
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 415723858C78
Message-ID: <956df1ad-b196-4c19-9ae2-94528ad4a33c@dronecode.org.uk>
Date: Thu, 27 Nov 2025 21:11:23 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: cygport no longer archives
 ${NAME}-${VERSION}-${RELEASE}.cygwin.patch into source package automatically
References: <20251127165737 DOT 97e1d550925978036c854cfd AT nifty DOT ne DOT jp>
 <20251127224642 DOT 8edb5934f4df01416675d4b6 AT nifty DOT ne DOT jp>
 <e72596fb-ae95-4e94-a100-26e8aec0b9e5 AT dronecode DOT org DOT uk>
 <20251127235915 DOT 5909aa3624e28dc314ad5773 AT nifty DOT ne DOT jp>
 <aSh_VFlmN_58NfNH AT calimero DOT vinschen DOT de>
Content-Language: en-US
Cc: cygwin AT cygwin DOT com
In-Reply-To: <aSh_VFlmN_58NfNH@calimero.vinschen.de>
Precedence: list
From: Jon Turney via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Jon Turney <jon DOT turney AT dronecode DOT org DOT uk>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

On 27/11/2025 16:41, Corinna Vinschen via Cygwin wrote:
> On Nov 27 23:59, Takashi Yano via Cygwin wrote:
>> On Thu, 27 Nov 2025 14:20:31 +0000
>> Jon Turney wrote:
>>> On 27/11/2025 13:46, Takashi Yano via Cygwin wrote:
>>>> On Thu, 27 Nov 2025 16:57:37 +0900
>>>> Takashi Yano wrote:
>>>>> One year ago, cygport archives ${NAME}-${VERSION}-${RELEASE}.cygwin.patch
>>>>> into source package automatically. However, it does not seem to archive now.
>>>>>
>>>>> Is this intentional behaviour?
>>>
>>> Yes.
>>>
>>> I did some work a while ago to simplify the functionality this ancient
>>> and confusing mechanism provided.
>>>
>>> Briefly, the .cygwin.patch file is applied to an empty ${C} directory to
>>> create a set of files. Cygwin READMEs, custom post-install/pre-remove
>>> scripts and shell profile scripts found in ${C} are then automatically
>>> installed (as per the "Postinstall" chapter in the cygport reference
>>> manual).
>>>
>>> This is just strange, and kind of awkward to work with when building
>>> from a packaging repo, as you can't work directly with these files, only
>>> a patch which makes them.
>>>
>>> So I added a new mechanism where these files can be named in CYGWN_FILES
>>> and are directly included in the source archive, instead.
>>>
>>> [1]
>>> https://cygwin.com/cgit/cygwin-apps/cygport/commit/?id=0b0066f3e778f760ca36a4454fe52eb603f9cf9d
>>>
>>>> Downgrading diffutils to 3.10-1 solve the issue.
>>>
>>> I though this was a different change where there's a new (benign)
>>> warning in diff (about diff-ing against an empty or non-existent
>>> directory?) which leaks out through cygport (that I maybe need to work
>>> out how to squelch or avoid).
>>>
>>> But now you have me thinking that it's more serious than that?
>>
>> Yes. For example, currently, the source package of bvi includes
>> bvi-1.4.2-1.cygwin.patch, however, it will be lost if the source
>> package is rebuild in current environment.
> 
> Wouldn't it be better to drop .cygwin.patch entirely and create
> explicit patch files applied via PATCH_URI?

Imho, these things don't belong in patches at all, since they are just 
plain files.

Since the .cygwin.patch file in the bvi package only creates a README 
file (to be installed in usr/share/doc/Cygwin), the 'modern' solution is 
place it next to the cygport. (You don't even need to write 
CYGWIN_FILES="README", since that's the default if a file with that name 
exists).

(Of course, if you have other files (not the aforementioned README, 
post-install/pre-remove and shell profile scripts) that you want to add 
to the source package, you can (as always) just add them to SRC_URI, and 
then write instructions in your cygport to install them from $S as needed.


However, Takashi-san has identified a bug here:

cygport uses 'diff || true' to generate the patch (to avoid seeing the 
exit status of 1 that diff generates if there are differences), so 
cygport is swallowing any error reported by diff (exit status 2).

But it seems that diff 3.11 or 3.12 now considers it an error to diff 
against a non-existent directory (which is what cygport has been diffing 
  ${C} against to generate the .cygwin.patch file, since forever).

This is the cause of the 'diff: <blah> Is a directory' message seen 
while building a package - I'd thought this was just a warning, not 
realizing that it's an error but being ignored, and obviously prevents 
the .cygwin.patch file from being generated.

Anyhow, the fix seems relatively simple (to diff against an empty but 
existing directory instead), so I'll release a fixed version of cygport 
as soon as I'm able to...

(probably need to cook up some regression test to check that these 
.cygwin.patch files are generated, since I'd completely failed to notice 
that! Thanks very much to Takashi for pointing that out!)


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple