DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 5ARH8fjN3882255
Authentication-Results: delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results: delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter: OpenDKIM Filter v2.11.0 delorie.com 5ARH8fjN3882255
Authentication-Results: delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=LCVENqK0
X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 60C0E3858023
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1764263320;
	bh=eSuivo/H+Cay2KADb3OsXqyJBOkXPz6XZ8jfWAEsz08=;
	h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:
	 From;
	b=LCVENqK0vmGjwkMrLl3XE/wTFIhuckQXLO0hzj+BsjkuebHmjJO1FlBb9jUvGVI9k
	 QaeI3gANZiTPBaIQXgDrIFFXlYGTFyK1T0YqpSOPWmsuMme+9GyWhemtrRqA0/vQWu
	 HTBpPiCuDQw5E895b5tg5d8AD3viv01vnOG/hXO4=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1B163858C24
Date: Thu, 27 Nov 2025 17:41:56 +0100
To: cygwin AT cygwin DOT com
Subject: Re: cygport no longer archives
 ${NAME}-${VERSION}-${RELEASE}.cygwin.patch into source package automatically
Message-ID: <aSh_VFlmN_58NfNH@calimero.vinschen.de>
Mail-Followup-To: cygwin AT cygwin DOT com
References: <20251127165737 DOT 97e1d550925978036c854cfd AT nifty DOT ne DOT jp>
 <20251127224642 DOT 8edb5934f4df01416675d4b6 AT nifty DOT ne DOT jp>
 <e72596fb-ae95-4e94-a100-26e8aec0b9e5 AT dronecode DOT org DOT uk>
 <20251127235915 DOT 5909aa3624e28dc314ad5773 AT nifty DOT ne DOT jp>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20251127235915.5909aa3624e28dc314ad5773@nifty.ne.jp>
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Corinna Vinschen via Cygwin <cygwin AT cygwin DOT com>
Reply-To: cygwin AT cygwin DOT com
Cc: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

On Nov 27 23:59, Takashi Yano via Cygwin wrote:
> On Thu, 27 Nov 2025 14:20:31 +0000
> Jon Turney wrote:
> > On 27/11/2025 13:46, Takashi Yano via Cygwin wrote:
> > > On Thu, 27 Nov 2025 16:57:37 +0900
> > > Takashi Yano wrote:
> > >> One year ago, cygport archives ${NAME}-${VERSION}-${RELEASE}.cygwin.patch
> > >> into source package automatically. However, it does not seem to archive now.
> > >>
> > >> Is this intentional behaviour?
> > 
> > Yes.
> > 
> > I did some work a while ago to simplify the functionality this ancient 
> > and confusing mechanism provided.
> > 
> > Briefly, the .cygwin.patch file is applied to an empty ${C} directory to 
> > create a set of files. Cygwin READMEs, custom post-install/pre-remove 
> > scripts and shell profile scripts found in ${C} are then automatically 
> > installed (as per the "Postinstall" chapter in the cygport reference 
> > manual).
> > 
> > This is just strange, and kind of awkward to work with when building 
> > from a packaging repo, as you can't work directly with these files, only 
> > a patch which makes them.
> > 
> > So I added a new mechanism where these files can be named in CYGWN_FILES 
> > and are directly included in the source archive, instead.
> > 
> > [1] 
> > https://cygwin.com/cgit/cygwin-apps/cygport/commit/?id=0b0066f3e778f760ca36a4454fe52eb603f9cf9d
> > 
> > > Downgrading diffutils to 3.10-1 solve the issue.
> > 
> > I though this was a different change where there's a new (benign) 
> > warning in diff (about diff-ing against an empty or non-existent 
> > directory?) which leaks out through cygport (that I maybe need to work 
> > out how to squelch or avoid).
> > 
> > But now you have me thinking that it's more serious than that?
> 
> Yes. For example, currently, the source package of bvi includes
> bvi-1.4.2-1.cygwin.patch, however, it will be lost if the source
> package is rebuild in current environment.

Wouldn't it be better to drop .cygwin.patch entirely and create 
explicit patch files applied via PATCH_URI?


Corinna

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple