DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 56I9AeDQ2468963
Authentication-Results: delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results: delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter: OpenDKIM Filter v2.11.0 delorie.com 56I9AeDQ2468963
Authentication-Results: delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=ZYDCSxaP
X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1114E385274A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1752829840;
	bh=ILACykhsV+b2USwULoRgPcP0xkiia6toDZNjc6FpAJM=;
	h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:
	 From;
	b=ZYDCSxaPTuteA0taAUBtDHdlXBtVLMV6ud53U1m6ICHYufCWkHlGEpG8ot1fM5BcN
	 r6Ralzl+1ltzncFSEbimzBQW/R0YoUvWHg5mfWDVt4dphz7uQDk6xc5PKXCoYLSNaz
	 Pr3it5q3rcRkSaJb66Gt4z5iNexEOCEkf62XjtyA=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 86EDE385EC3B
Date: Fri, 18 Jul 2025 11:10:14 +0200
To: cygwin AT cygwin DOT com
Subject: Re: Calling system() in multi-threads.
Message-ID: <aHoPdvE4a2cln1-O@calimero.vinschen.de>
Mail-Followup-To: cygwin AT cygwin DOT com
References: <20250617215411 DOT ebf69d1c18b55191a1b76c01 AT nifty DOT ne DOT jp>
 <eb7786ee-dc7a-4689-9d17-b842e581d7c7 AT maxrnd DOT com>
 <20250618203127 DOT 71ac180de11230a9a6055185 AT nifty DOT ne DOT jp>
 <20250716235236 DOT 96055ec145d9a0528b50c357 AT nifty DOT ne DOT jp>
 <aHfHCqD2xZcdyu7u AT calimero DOT vinschen DOT de>
 <20250717231421 DOT 56b54f7e96266311101d4c08 AT nifty DOT ne DOT jp>
 <aHkUldQHKjA-lZrw AT calimero DOT vinschen DOT de>
 <20250718004446 DOT 9ce9f7f208566ded1a676fd5 AT nifty DOT ne DOT jp>
 <aHn871v7YwBUOQfs AT calimero DOT vinschen DOT de>
 <20250718174108 DOT 9044c793dc3363562a80833b AT nifty DOT ne DOT jp>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250718174108.9044c793dc3363562a80833b@nifty.ne.jp>
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Corinna Vinschen via Cygwin <cygwin AT cygwin DOT com>
Reply-To: cygwin AT cygwin DOT com
Cc: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

On Jul 18 17:41, Takashi Yano via Cygwin wrote:
> On Fri, 18 Jul 2025 09:51:11 +0200
> Corinna Vinschen via Cygwin <cygwin AT cygwin DOT com> wrote:
> > Yes, that's what I meant with my above paragraph, i.e.
> > 
> > > > > > I checked the sources and I don't see any dependency to ch_spawn
> > > > > > from a spawning process, in contrast to an exec'ing process.  That
> > > > > > doesn't mean there is none, just that I didn't find any.
> > 
> > These external dependencies *should* only be of interest when performing
> > an execve, but not when performing a spawnve.
> 
> So, the previous patch might not correct.
> The following makes more sense, I suppose.
> 
> diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
> index cb58b6eed..56fca6e45 100644
> --- a/winsup/cygwin/spawn.cc
> +++ b/winsup/cygwin/spawn.cc
> @@ -944,6 +944,7 @@ spawnve (int mode, const char *path, const char *const *argv,
>    int ret;
>  
>    syscall_printf ("spawnve (%s, %s, %p)", path, argv[0], envp);
> +  child_info_spawn ch_spawn_local;
>  
>    if (!envp)
>      envp = empty_env;
> @@ -961,7 +962,7 @@ spawnve (int mode, const char *path, const char *const *argv,
>      case _P_WAIT:
>      case _P_DETACH:
>      case _P_SYSTEM:
> -      ret = ch_spawn.worker (path, argv, envp, mode);
> +      ret = ch_spawn_local.worker (path, argv, envp, mode);
>        break;
>      default:
>        set_errno (EINVAL);

Yep, indeed.

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple