DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 54GJ8wD04164928
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F77A3865C2C
Message-ID: <ee7e023c-e5ba-4381-a9f3-e1cc595a730a@cornell.edu>
Date: Fri, 16 May 2025 15:08:16 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: FIFO hangs (Probably a bug of cygwin fifo)
To: cygwin AT cygwin DOT com
References: <20250514182934 DOT ee8ff6c46ecfc44c69e70b72 AT nifty DOT ne DOT jp>
 <adf4f021-6a6f-4bc1-96db-f0ea5b9cd2f9 AT cornell DOT edu>
 <20250516084640 DOT 2b20feda1c8f65cddbd264bc AT nifty DOT ne DOT jp>
 <20250516175923 DOT 680fc55b6aa2c3cd9d83199d AT nifty DOT ne DOT jp>
Content-Language: en-US
In-Reply-To: <20250516175923.680fc55b6aa2c3cd9d83199d@nifty.ne.jp>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFFSeVNBMHlYeHBid2JhSktnd1IxczlUS0FoK3JraTNSRFg2SWROTUFMUVNr?=
 =?utf-8?B?aXlzSER1TEtzVy9pOHRUd1hKTnpZb2VtbmVjK0lYanlwTEFvWWxkVVVsUTVi?=
 =?utf-8?B?bzMrd1pQWC9na05UN2xZbjZSbjNCeGJvTWREUXVwNlBuZHFRZlZkTFBQUVg1?=
 =?utf-8?B?L3UyZkNmRmg1eWh0Zzhhbm84VU8rS2dBZ0dJMnNMSUZLQzhGU1FZK3JiUkhV?=
 =?utf-8?B?dytVS3I2dnZJMlY4UDB6bXJOY29YdCt1czkzMlcxdEYwSzduZlVnVHZYRGRw?=
 =?utf-8?B?MTBRNkVBUXF4eWlMZWx1WWpwNFNGOVpoaGc5OGJ0Z1d6L2lrTmpJelo5cEdY?=
 =?utf-8?B?b2w1dmU4QWZBQzduTllIV2VoZHJlb1pHSUVablVVeFBGaXpIRWFqNFExam9s?=
 =?utf-8?B?UUkyUm5yWTF5WTZFRlZQTUJuR0p0UWt3R3plaUNLZHdqSGxSVlJXVU42QlBU?=
 =?utf-8?B?WkM3bjFGVXhJUUZsTzMyT0t2Q2c1Qld3TnZaOEgyd2oxNStZVWVyeWNNcHgv?=
 =?utf-8?B?N216WGc0Q1l5TWQrUmpHeHlqSHZ6a0xUN1ZYYVcxakRESVg5RHRXYlgvbkZq?=
 =?utf-8?B?OWthemhPWW03NlhxdlNwVk9TcHBNbUNobm54YkRrWWgxaFZ6UTJ2dUkySVE3?=
 =?utf-8?B?NU84M3p0UVlJZ2VENy9ZSGtmS0I5SEpVZmpEUDB3cE5XaW9Vajg5MlZMa0l0?=
 =?utf-8?B?OVAzTDJiN2JuK1VCT1B0NnF3a1NKUDBuS0JhRGdNNnV4dGtpakFWR3ZMTUFD?=
 =?utf-8?B?WmRZSmpHdHlUYXcrdWpGNE5XUGtqSjJxRmN3T3Y4WWYvakFJcno3aGQ2eFB4?=
 =?utf-8?B?VW9VcUNlNHpxYjF1QlZxLzlSQUpsaVp2V0dzdUlQSEJuaEdWVGZ0UVJxZVJH?=
 =?utf-8?B?OUJYelo5amxxQnZ2Q2ljSVBDQ1JFZUxTZmtJVkVmSU54MmhCQVRsc0ljazFZ?=
 =?utf-8?B?aW1yNDdwMzFoK3dNbHdkOS9CZjBQNm9mdXRqYXZnR01xUU5wSEk3aTgyVVRm?=
 =?utf-8?B?Yk9UK3YrdjZ2LzNBSVB5ZGFOMVkxRkpyZ0tXbWp6S2hKWXRHbDRIdFg0NGdF?=
 =?utf-8?B?N1ZDbzN1cnNQendoSThYbXhyRDdzakR1UytpVHJCL2pWTHZmTi9QT1I3WE4r?=
 =?utf-8?B?ZzdzektDQmh4ajFpUVZJMDk5b1F6a0h1YmgyMkh0WFRlemxaOXVGUjhGb2Z4?=
 =?utf-8?B?L1htZ1A4MDBENnpSQ3VoVVB3eEl3d2pwWHB5RlNWUzR1SjRlVkkwMGFJMWQ0?=
 =?utf-8?B?YjJQNGpYb0hNWlMrVFZIUXJleTZUemRYaStSbHFSTE1nQitOTkYrSXN3cEo4?=
 =?utf-8?B?UXdhREIzWnpKN0IwSmg3K25WRUFBVE41cE9HSUZBMy8vSURpV1JuV09QWkZs?=
 =?utf-8?B?dTEzQjVySWRHbDM2ZjZFNjFZV1FWVmNwTmI4L0VpakJPeFZZK1plUzY3eDhz?=
 =?utf-8?B?VTRwRHE2K2Y4cWpGelVvK21YM3E4L0dhTDJWdTlKWWlJbWZUbTNMZm9TUTB5?=
 =?utf-8?B?WjR3cERTWExLOTFtY3V5dDZGaWlEY3lCRS95cmFGcmFHQkMxNTNqbCtaY3Uy?=
 =?utf-8?B?aUw0VkpSbFhzelZET1UybDBUMVFad0hoV1NZYllzT0ZucENKdXFScEVVMnA3?=
 =?utf-8?B?cFJMSllXU1lkRjNhTkZ1UGtMS1FrRDdQNVkvdEpVQXl4VE1VTGVDa1NIanpM?=
 =?utf-8?B?WHkzTk1oN3BFMlI2S1JSMWowV3NPcmd2bTNZTENYN3R1UGJ5c3FRbk1MbVBv?=
 =?utf-8?B?WUpwQmFzbnA4VkdncnBQUXovdUd1bmlkWHJRb3ZjQnF1a2RVVHlmSDRLMUE5?=
 =?utf-8?B?ZXprVU5SQVFsU0RibHBoRExobW1WWFRZSlYveVZMK0N6WG5neFhuSmxXVTBL?=
 =?utf-8?B?MWdhekNnNXpyYUU1cnprbkh4UjM4M2VadVFYeWVqbUVNbTdpamIzaVZZQVB5?=
 =?utf-8?B?Umt1blVtU3JxVnlyNnZabWVQVWF2YTd2bGVmcmtrc2l3bVlsUFpRa2psZkxh?=
 =?utf-8?B?WjlOa0NvVGxkTTltTnczOVJYamZtV3VqVGs2UlM1VDIzOXhiOUhFak5TYUEx?=
 =?utf-8?B?N0VscUhlZDh5VGJ2UGZZMERxUkdvTU1rL2w0VjI1TzQvWWgzZHMwYVNRclJV?=
 =?utf-8?Q?uB+yLTzb6MMa8sD40OSBf1DOg?=
X-OriginatorOrg: cornell.edu
X-MS-Exchange-CrossTenant-Network-Message-Id: d8767a89-06df-4ac0-fca5-08dd94ad0552
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR04MB7470.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2025 19:08:19.7215 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tt0vWyhZ3ccwI+GsezbzpA6DDZrHxtwyuTJeTTmuKcRZVMRGLDSjaqeXuwoIe2RFEUrX9TYI6eGiip3pLl6FVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB8423
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Ken Brown via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Ken Brown <kbrown AT cornell DOT edu>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

On 5/16/2025 4:59 AM, Takashi Yano via Cygwin wrote:
> On Fri, 16 May 2025 08:46:40 +0900
> Takashi Yano wrote:
>> diff --git a/winsup/cygwin/local_includes/cygheap.h b/winsup/cygwin/local_includes/cygheap.h
>> index fed87ec2b..7d11fbb37 100644
>> --- a/winsup/cygwin/local_includes/cygheap.h
>> +++ b/winsup/cygwin/local_includes/cygheap.h
>> @@ -604,6 +604,8 @@ class cygheap_fdnew : public cygheap_fdmanip
>>     {
>>       if (cygheap->fdtab[fd])
>>         cygheap->fdtab[fd]->inc_refcnt ();
>> +    if (locked)
>> +      cygheap->fdtab.unlock ();
>>     }
>>     void operator = (fhandler_base *fh) {cygheap->fdtab[fd] = fh;}
>>   };
> 
> This should not be done, because the parent class cygheap_fdmanip
> does that.
Right.  But the other part of the patch (to syscalls.cc) looks right to 
me, and I agree that it fixes the hang.  Here's my understanding of why 
it works: The main thread tries to open the fifo for reading, but 
fhandler_fifo::open blocks until it detects that someone is opening the 
fifo for writing.  The other thread wants to do that, but it never gets 
to the point of calling fhandler_fifo::open because it is stuck waiting 
for the lock on cygheap->fdtab.  To fix this, we need to delay the 
construction of the cygheap_fdnew object fd until after 
fhandler_fifo::open has been called.

Do you agree with this explanation, or is there something else going on? 
  In either case, I think it would be good to include at least a brief 
explanation in your commit message, since this is a pretty subtle bug. 
And thanks for finding the fix!

Ken

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple