DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 53L8a23X876842
Authentication-Results: delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results: delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter: OpenDKIM Filter v2.11.0 delorie.com 53L8a23X876842
Authentication-Results: delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=gicWDgSd
X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 03EDA3858C50
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1745224562;
	bh=euewJhzH+TgfGMmVmByvWFMAC3ckjO14zHXgQmxFnzc=;
	h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	 From;
	b=gicWDgSdckO2yxGDnnUKkzuWpmnmD7/5dzWua9fVQGG9WQWcBDyikyIag897gTVDE
	 v0n5C/huJvmYBluoIPDcb3Vmre+4ZWhOTkThQ1d7661LMKUDc8eD2Ztw8wBDNYwKRP
	 olFxbK53IL/HHwkMNmKeATkPF04qc1OEMgVEiTcI=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2E2C3858C42
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A2E2C3858C42
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745224492; cv=none;
 b=UpG44TFipPT93S6sZvZdRifyz3agqFRErCr4o2muniB0YA5g/sRdFQFvFsQ5aGcsq6odlLsi9KLNofsOBE1TPYXd9y+knpSSndls9Qp2GDuopng2ae1qismMpiGwkBINQfbbGnBZMVjj5iil3UYnoFmkpNIQol9EutzlqTXNTlY=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
 t=1745224492; c=relaxed/simple;
 bh=HG4kVpuii0ycNgI7o8IH7/qjRQu84FXzisJFPC951SA=;
 h=Message-ID:Date:MIME-Version:Subject:To:From;
 b=dVTO6osH/eyH9zc7Sy4p/xdJhoDYf3wfVGnF7wY3H3yelTscsQyk3v324jffVK2P/+1WIZa7M267o1X2Fg6Lp98cNqFWJT4dUK9XUMkhBc8er3E6kjuVhmJ/H3pYf77aZLbYPlF8q/aQZnuYVJvsLNXeoOKFa4oWdrpTvhdE6d4=
ARC-Authentication-Results: i=1; server2.sourceware.org
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A2E2C3858C42
Message-ID: <2b2ab41b-f430-4d5e-9cc3-3d498a79c448@maxrnd.com>
Date: Mon, 21 Apr 2025 01:34:46 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: cygstart: buffer overflow when a URI is passed
 (cygutils-1.4.17-[23])
To: cygwin AT cygwin DOT com
References: <502f1b04-bc0e-4aba-b150-7b9ea3c5ba3b AT gmail DOT com>
 <aa2914e5-9a39-cc64-09b0-4fb4563a8706 AT t-online DOT de>
Content-Language: en-US
In-Reply-To: <aa2914e5-9a39-cc64-09b0-4fb4563a8706@t-online.de>
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Mark Geisert via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Mark Geisert <mark AT maxrnd DOT com>
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by delorie.com id 53L8a23X876842

Hi Christian,

On 4/12/2025 9:37 AM, Christian Franke via Cygwin wrote:
> ggl329 via Cygwin wrote:
>> Hi all,
>>
>> I've encountered a possible bug in cygstart.
>> It seems to abort when a URI is passed to it.
>>
>>
>> $ cygcheck -dc | grep cygutils
>> cygutils                                1.4.17-3
>> $ cygstart https://www.google.com
>> *** buffer overflow detected ***: terminated
>> Aborted
> 
> Possibly no regression but longstanding bug which is now detected thanks 
> to gcc12's __builtin_dynamic_object_size() feature and -D_FORTIFY_SOURCE=3:
> 
> cygstart.c:
> 
> cygstart_mbs_to_wcs (const char *mbs_path, wchar_t **wcs_path)
> {
>    ...
>    *wcs_path = (wchar_t *) malloc ((len + 1) * sizeof (wchar_t));
>    ...
>    // *** buffer overflow detected *** because the length parameter
>    // should specify the number of characters instead of bytes:
>    if (mbstowcs (*wcs_path, mbs_path, (len + 1) * sizeof (wchar_t)) ...
>    ...
> }

Apologies for the delayed response.  Thanks ggl329 for the report and 
you for the diagnosis!  I will look into repairing this bug shortly.
Regards,

..mark

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple