DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 532E3AB72818097
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70D7A3858D34
Subject: cygutils 1.4.17-2: lssparse -H does not print hole at offset 0 if
 more data exists
To: cygwin AT cygwin DOT com
Message-ID: <5e2eb205-c863-7575-628e-74a968b90a7c@t-online.de>
Date: Wed, 2 Apr 2025 16:01:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:128.0) Gecko/20100101
 SeaMonkey/2.53.20
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------E25E9A9547F8260DA59C6AB9"
From: Christian Franke via Cygwin <cygwin AT cygwin DOT com>
Reply-To: cygwin AT cygwin DOT com
Cc: Christian Franke <Christian DOT Franke AT t-online DOT de>
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

This is a multi-part message in MIME format.
--------------E25E9A9547F8260DA59C6AB9
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Testcase for a minor issue:

$ > sparse_file

$ chattr +S sparse_file

$ dd if=/dev/zero bs=1M count=1 conv=sparse,notrunc of=sparse_file
...
$ lssparse sparse_file # OK

$ lssparse -H sparse_file # OK
Hole range[0]: offset=0x0,      length=0x100000

$ printf X >> sparse_file

$ lssparse sparse_file # OK
Data range[1]: offset=0x100000, length=0x1

$ lssparse -H sparse_file # Missing 'Hole range[0]'
Data range[1]: offset=0x100000, length=0x1

The condition at lssparse.c:161 is never true:

    141      for (i=1 ;;) {
    ...
    161          if (print_holes && (i == 0) && (data_start > 0)) {

Possible patch attached. Important: Not tested with other corner cases.

-- 
Regards,
Christian


--------------E25E9A9547F8260DA59C6AB9
Content-Type: text/plain; charset=UTF-8;
 name="lsparse.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="lsparse.patch"

LS0tIGxzc3BhcnNlLmMub3JpZwkyMDI1LTA0LTAxIDEwOjQ4OjU0LjAwMDAwMDAwMCArMDIw
MAorKysgbHNzcGFyc2UuYwkyMDI1LTA0LTAyIDE1OjQ1OjU0LjE3OTc5NDMwMCArMDIwMApA
QCAtMTM4LDcgKzEzOCw3IEBACiAgICAgICogJCAvY3lnZHJpdmUvYy9XaW5kb3dzL3N5c3Rl
bTMyL2ZzdXRpbCBzcGFyc2UgcXVlcnlyYW5nZSAuLi4gIwogICAgICAqIG91dHB1dAogICAg
ICAqLwotICAgIGZvciAoaT0xIDs7KSB7CisgICAgZm9yIChpPTAgOzspIHsKICAgICAgICAg
ZGF0YV9zdGFydCA9IGxzZWVrKGZkLCBvZmZzZXQsIFNFRUtfREFUQSk7CiAgICAgICAgIGlm
IChkYXRhX3N0YXJ0ID09IC0xKQogICAgICAgICAgICAgYnJlYWs7Cg==
--------------E25E9A9547F8260DA59C6AB9
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

--------------E25E9A9547F8260DA59C6AB9--