DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 52SIcEva416828 Authentication-Results: delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com Authentication-Results: delorie.com; spf=pass smtp.mailfrom=cygwin.com DKIM-Filter: OpenDKIM Filter v2.11.0 delorie.com 52SIcEva416828 Authentication-Results: delorie.com; dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=eR6nKuMk X-Recipient: archive-cygwin AT delorie DOT com DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6557A3830602 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com; s=default; t=1743187092; bh=l2nJZC0DsUQrGKzkhHI6faWrbmJ4baRqdy83217iMx0=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=eR6nKuMk62CHcmm4/ZqvexGFK4zJ7QAvNjDQHWzKMAPvYfLCPY29yoK51JIdRk6dQ ss3jSXzwCBTry20zoPuiTA5NyYIbytsJOPHAiDfL6HkdE/AIDc+5UUhugiJtk8Dw6o efEv2SpgD9/kVVlaFFwTPb64UsJy8Gcpv55nNX4g= X-Original-To: cygwin AT cygwin DOT com Delivered-To: cygwin AT cygwin DOT com DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 885BB3857BA5 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 885BB3857BA5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743187065; cv=none; b=NRg3xoHO5Iyu7mLFtD5UNRcFEL6pe7DKla3kEBqFVLJngeZ9bLarjuODDinIBquuyy1N2i2vR4sNy0uiR2aafBDOlZMgTjhJLffj7/M5lmqkPXiXYUuPoj+6nWLcY7ahf2va3Y0/nOc7L7YgB5pQBO3shKewAOldC7f/lBvYtLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743187065; c=relaxed/simple; bh=gv7awrdvUAAsjCmi38ku+dcv7p4xeqTBhB9w4LnrGOE=; h=Message-ID:Date:MIME-Version:From:Subject:To:DKIM-Signature; b=J59FfA9As6yrgTLv6dpFYOnxW0sLtJKvNA8aVptYPNWuv5HEPj9aGJ9AFApi69+VQjC+mrmVlxbWW0DJNBSosSL76FHaEje7CWm0T+wmQTP40pGTPOoMOb9Z5hri0Psm5CNQrGHXUBA6kRRcDg7Q2muwiuCXgTy8A5phQOQ7ajQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 885BB3857BA5 Message-ID: Date: Fri, 28 Mar 2025 12:37:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: symbolic link curiousity in 3.6.0 Content-Language: en-CA To: cygwin AT cygwin DOT com References: <11037686 DOT 3WhfQktd6Z AT nimes> Autocrypt: addr=Brian DOT Inglis AT SystematicSW DOT ab DOT ca; keydata= xjMEXopx8xYJKwYBBAHaRw8BAQdAnCK0qv/xwUCCZQoA9BHRYpstERrspfT0NkUWQVuoePbN LkJyaWFuIEluZ2xpcyA8QnJpYW4uSW5nbGlzQFN5c3RlbWF0aWNTdy5hYi5jYT7ClgQTFggA PhYhBMM5/lbU970GBS2bZB62lxu92I8YBQJeinHzAhsDBQkJZgGABQsJCAcCBhUKCQgLAgQW AgMBAh4BAheAAAoJEB62lxu92I8Y0ioBAI8xrggNxziAVmr+Xm6nnyjoujMqWcq3oEhlYGAO WacZAQDFtdDx2koSVSoOmfaOyRTbIWSf9/Cjai29060fsmdsDM44BF6KcfMSCisGAQQBl1UB BQEBB0Awv8kHI2PaEgViDqzbnoe8B9KMHoBZLS92HdC7ZPh8HQMBCAfCfgQYFggAJhYhBMM5 /lbU970GBS2bZB62lxu92I8YBQJeinHzAhsMBQkJZgGAAAoJEB62lxu92I8YZwUBAJw/74rF IyaSsGI7ewCdCy88Lce/kdwX7zGwid+f8NZ3AQC/ezTFFi5obXnyMxZJN464nPXiggtT9gN5 RSyTY8X+AQ== Organization: Systematic Software In-Reply-To: <11037686.3WhfQktd6Z@nimes> X-Rspamd-Server: rspamout08 X-Rspamd-Queue-Id: 70D0C18 X-Stat-Signature: kramdo1zoy95usxirhs3z3jxpgyp5yua X-Session-Marker: 427269616E2E496E676C69734053797374656D6174696353572E61622E6361 X-Session-ID: U2FsdGVkX1/9PkWDFOfH8+E20LNsa6fBTl2De1SuddU= X-HE-Tag: 1743187062-918556 X-HE-Meta: U2FsdGVkX19Ttmn8bUhmPc6gT7l+Dg5uyminqg4bQKsGlE7bF6pgWR0PdYOuAmbnUISZpkYkafoCyGXF4LQMQMM5MOwUHYjgn5ZmZV4kp7krP9j6F2/wsGGYqX8l/zsnM11UpVzSDe6zyr/JcewCR7dYV/CnU782460f3y9fQwkcYDSeoqM18l533ItPwO+NOPhlaCoAsENCDf6GqGJaRutOyeugiHyO5TVDOzmx2x1N+odFdEZXiCPpu8ZvoQ6aMz2FIH6gccrIokr22hDrwKqkvOo1MNwc2hNobqnpiMV3Sbxf0fRPsDbWmjvbEIKU+vczm8MjXR3mRsetkFKILSpHKAvi/w/AYOxQB8fgCJh2dVE60XrTeJA3w0e0iskHqKidW01gLy+Ln2GS1QuWkKWTrWb/UP7dxdHCwpOOF73SKXjHhQqLzpuF5ZLe7VYdtcDx2qllVNleJULqrOyOgMBbZ89zvB9i X-BeenThere: cygwin AT cygwin DOT com X-Mailman-Version: 2.1.30 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Brian Inglis via Cygwin Reply-To: cygwin AT cygwin DOT com Cc: Brian Inglis , Gnulib bugs , Bruno Haible Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com Sender: "Cygwin" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by delorie.com id 52SIcEva416828 On 2025-03-28 08:30, Bruno Haible via Cygwin wrote: > [CCing bug-gnulib] > > Corinna Vinschen wrote in > : >> I found the problem, it's in a gnulib header. See below. >> ... >> Gnulib's acl-internal.h contains this: >> >> /* Linux-specific */ >> /* Cygwin >= 2.5 implements this function, but it returns 1 for all >> directories, thus is unusable. */ >> # if !defined HAVE_ACL_EXTENDED_FILE || defined __CYGWIN__ >> # undef HAVE_ACL_EXTENDED_FILE >> # define HAVE_ACL_EXTENDED_FILE false >> # define acl_extended_file(name) (-1) >> # endif >> >> This is simply not true. Cygwin's acl_extended_file only returns >> 1 on dirs, if they actually contain more than the 3 default entries >> to emulate POSIX access. I just tried it and it works exactly >> as required. >> >> Can this be fixed, please? > > If I comment out that part: > /* || defined __CYGWIN__ */ > I get three test failures > > FAIL: test-file-has-acl.sh > ========================== > > file_has_acl("tmpdir0") returned yes, expected no > FAIL test-file-has-acl.sh (exit status: 1) > > FAIL: test-file-has-acl-1.sh > ============================ > > file_has_acl("tmpdir0") returned yes, expected no > FAIL test-file-has-acl-1.sh (exit status: 1) > > FAIL: test-file-has-acl-2.sh > ============================ > > file_has_acl("tmpdir0") returned yes, expected no > FAIL test-file-has-acl-2.sh (exit status: 1) Expectations are incorrect: all NTFS files under Cygwin have ACLs and directories have ACLS and DACLs, and probably also NFS files and directories, unless you can access a FAT or other filesystem; but not on my local, nor probably our CI, whether GH or Appveyor? Some package tests are skipped because they can not find suitable files or directories: for example, accessible but not owned by the build owner IIRC. Perhaps these should also be such cases If any test does any ftw, it should test all the cases required, as ftw seems to crawl all over our filesystems, taking ages, possibly because symlinks are maybe not checked for everywhere, or cygdrive is mapped to /mnt a la Linux? > from a testdir created with > $ ./gnulib-tool --create-testdir --dir=../testdir1 --single-configure acl acl-permissions file-has-acl copy-file > > This is reproducible with both Cygwin 2.9 and 3.6.0. > > So, from my point of view, the situation is still the same as when > I introduced this workaround, in > https://lists.gnu.org/archive/html/bug-gnulib/2018-09/msg00089.html > > Therefore, I see two possible ways forward: > a) The Cygwin function acl_extended_file gets modified so that it > is actually usable by Gnulib (i.e. does not cause test failures), > or > b) Investigate how to deal with the "Not supported" error in coreutils. > (Maybe silence and ignore this error?) Or could translate "readlink/at" ENOENT to EACCESS, although POSIX says EACCESS means "Search permission is denied for a component of the path prefix of path" or "The access mode of the open file description associated with fd is not O_SEARCH and the permissions of the directory underlying fd do not permit directory searches."? I already maintain a bunch of Cygwin coreutils patches: one more will just delay starting to build a while longer, while I work around the latest releases changes! ;^> -- Take care. Thanks, Brian Inglis Calgary, Alberta, Canada La perfection est atteinte Perfection is achieved non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add mais lorsqu'il n'y a plus rien à retrancher but when there is no more to cut -- Antoine de Saint-Exupéry -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation: https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple