DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 50B2Ppcm1710356
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 062CB385843B
To: "cygwin AT cygwin DOT com" <cygwin AT cygwin DOT com>
CC: Whitney Schmidt <whschm AT microsoft DOT com>,
        Sebastian Hernandez
 <sebhernandez AT microsoft DOT com>
Subject: [Bug check/report] UnDocumented call to
 ntdll.dll!NtAssignProcessToJobObject in msys2.0.dll / cygwin - included in
 mingit/Git for Windows
Thread-Topic: [Bug check/report] UnDocumented call to
 ntdll.dll!NtAssignProcessToJobObject in msys2.0.dll / cygwin - included in
 mingit/Git for Windows
Thread-Index: Adtjz7Dcw6j7xJUNQkiXzhJq8xXTeA==
Date: Sat, 11 Jan 2025 02:25:16 +0000
Message-ID: <IA3PR21MB42696BB656E25C4E405BDB3E8C1D2@IA3PR21MB4269.namprd21.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=c7f9c758-e5cc-4669-b5f0-a3af4ca05ba6;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2025-01-11T01:48:47Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Tag=10, 3, 0, 1;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: IA3PR21MB4269:EE_|IA3PR21MB4221:EE_
x-ms-office365-filtering-correlation-id: 693dd872-a4a7-4223-82ac-08dd31e72fc2
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
 ARA:13230040|1800799024|366016|376014|38070700018|13003099004|8096899003; 
x-microsoft-antispam-message-info: =?us-ascii?Q?ipX/zg4nhYtU6oawXCDzLHHngNazJVtfSySnmYWEQwsM5+du/gBF/v4QYc7m?=
 =?us-ascii?Q?K0gd/RGgqlP38CRGCUj0AAVAKXQ+NR0/Btfk+DuHokny1vlkm1X/hGiBaAv7?=
 =?us-ascii?Q?QEkSvY3PSESdr1zMUpX5aINpZZTZu5Ah7LXTIGoDPlba1aCTR+9RJltOwBdm?=
 =?us-ascii?Q?mPReFkanx76leqvMdMVlvOqnEdqgprXEktk2v6IVJCjuUKDq68lzcT4Y7Ata?=
 =?us-ascii?Q?peEP+I/RDe/WPfC850HlCbxB0f2RM/ur44PCAZLzj+4bDVoLCkJegiDpOwqz?=
 =?us-ascii?Q?uX4GJ78O8JYZH5+Kdd3UL/Bket/rQ4x/hzULGhZZxbo7j1pFiT4O3e4+x7ps?=
 =?us-ascii?Q?a0hE3+RhdVXaY66y+eJorOMI8qQLfOhljlMkly8Mwsj5qP9dwgurVhlAtamm?=
 =?us-ascii?Q?EtQzz98ohQycgESYfTFMuS8uLpy2HyzkscJQs1hxZC8JQkqMP+kKScgcgqvF?=
 =?us-ascii?Q?xxA9Djq2bG5gxe2xvQ2OMF1AgvS0pU42TcRfIeNGyEcSbuDS1Czug5vaMTLW?=
 =?us-ascii?Q?5shYNjWOMQujDe843vxWnOjOlE9TgbIzkCmrk2xfaoLq7EmkDKTRuytpEaiQ?=
 =?us-ascii?Q?08rgrqp6cVS+GYYamX1ZiY6DQO58rc7TPRs/M5OtnXjiVq6zEcHRyR4CVwD+?=
 =?us-ascii?Q?QB9wMqCPvuduL1SlyRLgDbITYIqg75nLkqhMw4OmD2hfWmFLI5GLyiZas9dm?=
 =?us-ascii?Q?ulZ3TL+Ythfe4uRKR69vk3fOmP7T79O9Q5VmIFgCjEGQ4WdjegZpzzJi05EB?=
 =?us-ascii?Q?RTURLCqN/UmvzYn69KotwwiEEGEMNnABAPrrzd3qpRAckijWz0T9StuIvTh/?=
 =?us-ascii?Q?gNno6WySZcsrPy0sOXwS+JfS70ZFntmnLpX6z6O3/5osjXr6xVSgSC0d3Jrg?=
 =?us-ascii?Q?uDMevGIPTOamkhLJGyvpUEEXkI9VR0fqy0i3b2rhnywWtIDXTtY2pmp2c36y?=
 =?us-ascii?Q?eleZpWWCh0+QKiiKAyZ1+lPUTo3gwnye1oIRzuUzXY41nqm0bONrkf1Ar7kx?=
 =?us-ascii?Q?c1GSBvIhcCBdRmBRubOI326cmnvmdMNeDbKoge3xfC9ICUTx/ycRa82JvvOP?=
 =?us-ascii?Q?i909pdcgBypZNndQOEPGkPn34piRdzJboCnKg0t4KQiVmse1UMG3/Ko1t1Iu?=
 =?us-ascii?Q?nIBFKPjY32lXPVNgAh4cUPAbeWi9bWtdeZwvkhTtOsd38nV5ZiYHfrKXfc0I?=
 =?us-ascii?Q?Gmrk9R8Lpw4p5Dv0ZQsDoz/JIjAoml+M2tVxHZ7HN3otk+ugDbHo65k542WD?=
 =?us-ascii?Q?8AP1VGHJG+QBw5Nzh5Fhbjjor3CXYE3iUovRvdKSD8VXcG0VkgEdplmal8Mu?=
 =?us-ascii?Q?zYUbP0+08WdunnPdx76etqb0gXXpGrkaIoN/GwPhcHrdOg+sUvGWV0c3qclC?=
 =?us-ascii?Q?F0JKYppbcqtPXrRZjX23POS9i4TUWkGWDEySnTFYVqH3UpW1lQ=3D=3D?=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:IA3PR21MB4269.namprd21.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230040)(1800799024)(366016)(376014)(38070700018)(13003099004)(8096899003);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BY0tNToW649Dq7WLVhOx4ROzh4OSiKmYMJdMpoMIc6B6gN+psXMHCZ8+eW6q?=
 =?us-ascii?Q?xsVTviuBoSsnbBtipWgazK3xOxhk0bf8gra2tDQB5UFj5FuvwE1UHyKj6ecD?=
 =?us-ascii?Q?HYZQ3tYWPiEZcBliEYrzJBBrSJ532o7o64j4knPHHxrijEolnzoMp0lVN+8W?=
 =?us-ascii?Q?2Piy3SSMFeyN3khMwZGEniccc60yRHozM1KJWl4gXpsu0trrefom/X/2VzIT?=
 =?us-ascii?Q?CJY9r0GcK/MfWqeDwEHKV9D28TVJtQeqUC28+dU8mET2DYBR4odHpEhe7om1?=
 =?us-ascii?Q?Vbd+jJdCn6pJEMu2tvONVoYGodZbCKhDh5b+eh1oAOilHrj77y/5zVw/cAgU?=
 =?us-ascii?Q?5bnvsD9QNM4YnbggcHpMWq3pUGaTGOPXkoFZfkIazYFyy7fZDJ4OaHaIYgqH?=
 =?us-ascii?Q?fRbhpoOty0IQRan4N5eukVwaHA2lFJLIHimxf2+V9rLszya4pE+ugn9DWbpV?=
 =?us-ascii?Q?q1uN+lfzMgZi1CvASqG/AXMP9c7wZskwGr1VcxyPiePe0KkIZiEfBNKTMD++?=
 =?us-ascii?Q?b/LmiSXh8Yjv6kOjJkDBaXmO65pT4tJEskiEpFNuthtuBKf7ovoI5FRqG+R8?=
 =?us-ascii?Q?JRUu7C1WEpClvAijI1EOJ/KYpoHOKeF80AkfACQN0EQBRmJP4AFcgKDLuN7A?=
 =?us-ascii?Q?k96OBrRJDEk2oe3mih9q2bhoORlEmVWqBuqdycEjl4a8ZgD29H8JRiaCWy1O?=
 =?us-ascii?Q?UI6b6nOAiLPhec1aqXkuD/asDzLmSQv+++djT1f1OSymVcuQ286+b8GVslRD?=
 =?us-ascii?Q?S2zFpBfuMn4TsChxIz8yx9JS1LW/ZJK/BCUNU+unUgvUgC+6auySDh7/YEK9?=
 =?us-ascii?Q?btg++30bRWlLU30Px+HenugBxqagT/WYFA41VYpZtvucT8xq+yhZDePz/6IV?=
 =?us-ascii?Q?44qE+SVQFthq6CMDyS0uXAf6KDezDJEXkt1Y76PDEGDmV2J6rtxXezsTOoa2?=
 =?us-ascii?Q?VAneNGFrtQyldn9+ZBcEPbRkXeeAwYkZgnLpin9QTf9IPpVebmal94nFQxbr?=
 =?us-ascii?Q?P2j2bsnyx/Xnz3BXqZStJDdrxRFzGLgY1n+QzKPorhNeWvWKBKyhxIdSOGxq?=
 =?us-ascii?Q?/Wt0qMeCO150/PSCJJ9e/DbbsZqsbKfzsevghXJINjvRdo2l0SgMARVDznik?=
 =?us-ascii?Q?5QOdCPDYKrDlBEkXvD+LcF4RwzMR3YtS1M9PdLUEYS+SA3x+4nMaMvnBMXS1?=
 =?us-ascii?Q?GSHGSmHizdMM4YNo2OGozO65TQYKbthdTGCx4QBkSnNRPSfZKnN0IYAvLCHL?=
 =?us-ascii?Q?YyfYE3IAud1TrwmHIkJcgrQ4iH3c+6oiaKW+rcojq6D61D+0L8iPbffx8ap5?=
 =?us-ascii?Q?mBRu++E2UZL6x8TRQ0BzPbqCkmJdITqOdkua6bDWHwFqUjENAEhLHCd2f0Ch?=
 =?us-ascii?Q?mnx9YGFPVV29ZIjant5ev4g723PzHXnNDYLXxEPRz2qzY5QXrB6v3tKE8wCP?=
 =?us-ascii?Q?x6eNIOBaOcGZiBEniWtuFwlhgIKepojjsenKZD6eIOIprW25T95LrR16a/hE?=
 =?us-ascii?Q?sJ56F7GsuuCm3yg891JYdPsMYnM8QKhn0AVKYWIyY4PRJEu8cUhRgcw27tDk?=
 =?us-ascii?Q?Jtuzkifq6iVTYENvg7j1/AjSdxzbNjLL6aaEKe4b?=
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA3PR21MB4269.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 693dd872-a4a7-4223-82ac-08dd31e72fc2
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2025 02:25:16.4679 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pFKThscpo8E5pdj2W1fY1EjVj+hkqVt0o8CxhsHBDFDk1jlNy0OsqmF/7/LMN631hWoiWcHJsRgjoCiH6t6y1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR21MB4221
X-Content-Filtered-By: Mailman/MimeDel 2.1.30
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Veronica Giaudrone via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Veronica Giaudrone <Veronica DOT Giaudrone AT microsoft DOT com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

Hello Cygwin list,
I'm part of the Visual Studio team at Microsoft which includes mingit/Git for Windows in our product for Git tooling integration (I'm copying a couple of folks from my team in this email too). One of our API scanning tools has identified msys2.0.dll calling undocumented Windows APIs like ntdll.dll!NtAssignProcessToJobObject:

  *   In cygwin - https://github.com/search?q=repo%3Acygwin%2Fcygwin+NtAssignProcessToJobObject&type=code with a caller: cygwin/winsup/cygwin/resource.cc at 21a2c9db6952954608cdf92638b411b15e7606c6 * cygwin/cygwin<https://github.com/cygwin/cygwin/blob/21a2c9db6952954608cdf92638b411b15e7606c6/winsup/cygwin/resource.cc#L246>
     *   Looks like it was introduced ~3 years ago: https://github.com/cygwin/cygwin/commit/1c7384f9d1b692c8b58af4db8c81d2ce0b10ad06#diff-bc84d57ac99958a694cb56b977bac1360e35040f9aa421972702219e11055ae8R290
     *   The code indicates to have come from oneTBB/test/tbbmalloc/test_malloc_compliance.cpp at bd291eb0d1c7f802ca5081a8755562ab786db2a2 * uxlfoundation/oneTBB<https://github.com/uxlfoundation/oneTBB/blob/bd291eb0d1c7f802ca5081a8755562ab786db2a2/test/tbbmalloc/test_malloc_compliance.cpp#L56-L78>, though in that case the usage is of the documented API instead.

We believe the above call should get replaced by the following documented API - AssignProcessToJobObject function (jobapi2.h) - Win32 apps | Microsoft Learn<https://learn.microsoft.com/en-us/windows/win32/api/jobapi2/nf-jobapi2-assignprocesstojobobject>

Are you aware of this undocumented API call or a reason to not attempt updating them to documented ones?

The scan identified a few others like:

  *   NtOpenJobObject
  *   NtCreateJobObject
  *   NtOpenMutant - we're not sure yet of the documented call for this one.
  *   NtQueryInformationJobObject
  *   NtSetInformationJobObject
We need to further investigate as the documented calls may not be identical.

I would appreciate any thoughts/feedback or pointing us on the right direction. My team would be looking into proposing a change if the above sounds reasonable to this list.
Thanks,
Veronica


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple