DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 4BIFkGpR495149 Authentication-Results: delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com Authentication-Results: delorie.com; spf=pass smtp.mailfrom=cygwin.com DKIM-Filter: OpenDKIM Filter v2.11.0 delorie.com 4BIFkGpR495149 Authentication-Results: delorie.com; dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=ScCvsb9g X-Recipient: archive-cygwin AT delorie DOT com DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A6473858C2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com; s=default; t=1734536774; bh=YsXpuYyiSEH0nA6zcCeMsLxg/hGUbvFTfkR4Q4e9y/g=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ScCvsb9gUA0tNBEM+us3VL+8/I511BLFJw544jRl01uE/P8iEozXd2f/N6GpZvUAI 081jDPeyKwE28p3xSivbsqWj8ZaiA3zzI2du57u6BTLAWZMXtyn2PcX/5Nq7tFFNMf 8rt9NRWYCZX47vhoJC0dnxcmeVjbYB+uhzv9l5Uk= X-Original-To: cygwin AT cygwin DOT com Delivered-To: cygwin AT cygwin DOT com DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 46B263858D38 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 46B263858D38 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1734536741; cv=pass; b=GhExW4ZlHBCJunHKZXlo0nLW4l/XV38BciDPqsqiNO7193Gbe89XHa8zUbouwAxTs7re+uUmSptRzG6iJ1fPduGLuE/xsAKHEH8E5UqsATpkc3YwV27YIbTLGNePsyueWzQorx4BL0mohh0z0vwT6txVKBPaRsDhO4T2EhoYqmU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1734536741; c=relaxed/simple; bh=HKntVdejV37APN/cin4Zm3n9gDl548zSpn7sdnW1qYo=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=eqO/EMCjKaoj0+H9H1CkkIJXf1acKT9To0pjzqXaHTG5zGNTPF6NqillUcXOhYi9EmNpISStATF2RlgZzBE3/OAjWld4VuooGhX8w4sBoqoYX1GgAndaFbHGCQn2haEdhTrD1q7SFLm3m1arK/e7itDjwU5zAOdLGgqIZBv4NOw= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 46B263858D38 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c98TNQtot3cexYLKtC+rsxNHRnaCR4Brq7EP/pj2jy50tfTZfF2u2nIFh7W3xwt9hUIWhMJlowlYHP/JjCkfnVko1TTs9e+06+6e05cJd7DkYf1vNXtwqLbMwcF4jF+AuTqBohuQy86qN++q0A8gZqjR6Mqr2rMeInJLUkdm8r/ewZgD7EyFbkMsut+43zBXrBgck7M+9oinFRzX+L4cr8/iZwV6SAfg5R58o5fxY3Ms/13uwaQ7gbtOxzxic2TmHAc0HEhwXRw8w6/uhqDXjnZh2WTqGKPEGGCAMLHrklONmTA4aurGVVzqlP5ucjHNVwqgaKtbeoeuf/R9w6peDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kFt/zacBAsDrcUwbqt3cTY+lXRG8nb/MflZxghHyIkA=; b=mzBhX/609aiv6cJ8u94IX90UK81/crKuh8GfhO5EAytJzj/wGZWdf5ka7OtyWToWbVF1y5jZ5ZDcQeQVq+EUgKu3fYMCJAk4WPgquiON5iZyqjUn0/B1ASMBir+55XBwqdMFFlholeBYb41wCW/GD29CEeQjQoSgQUmNT6tZsxG7ZZk7bUc3afG/vhLuCjBt7pHMnAw0F/AfnReRxPBXCd2HWfENX1G3Hf6qYaQ4D3+kqgq4w3024pzQlfISvFuHRvOpn5bcVzq38yNmohFUO/+zwfpeqbdJnSFbitI/T3e7m52ZtU1ZXVUB/pLoc8jAqZtHRV1IhxtCPyPMZDiM+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none Message-ID: Date: Wed, 18 Dec 2024 10:45:36 -0500 User-Agent: Mozilla Thunderbird Subject: Re: Atomic mmap replacement To: cygwin AT cygwin DOT com References: <66bf4f86-4618-b9a3-3e33-2c240b9204d0 AT cornell DOT edu> <20180219090042 DOT GC3417 AT calimero DOT vinschen DOT de> Content-Language: en-US In-Reply-To: X-ClientProxiedBy: BL0PR1501CA0004.namprd15.prod.outlook.com (2603:10b6:207:17::17) To SN6PR04MB5151.namprd04.prod.outlook.com (2603:10b6:805:90::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR04MB5151:EE_|DS0PR04MB8761:EE_ X-MS-Office365-Filtering-Correlation-Id: b137c68f-c3b8-44ee-b934-08dd1f7b052c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dHVCM2xOMHNsNURmN2ZVdzRGZGZaV1JHZHk5eVRIaHN5TXR2Y3p2TExIU205?= =?utf-8?B?YVdRUjdMNXR4TWhleEZFWEtIU28zZlBQendYQUhNN3UxNDVsMzBZUkk2cFp0?= =?utf-8?B?VDlqZ0NPQmhJU2tTNnM4cVNTLzhjVDZaRm9CeTZDQUo4K0VqWUxmQmYyZ0Jm?= =?utf-8?B?Y0wyejVFMWROY0V6clIxUXFSMy9VSGlVbmR6YSt5Mkl3ekdTVFRsTTRrd1RO?= =?utf-8?B?Nkk4cFRGR0lKdjVBcC93NDk2aVFuNlgzbEJOSnJqdTZBejdXb3dmUGd4WlVE?= =?utf-8?B?Y1VUR3p3amhQbmxXNERvTW50dk01L0tEZ1B3OG9RTGEwbjlpSXpDQ2M3eVlr?= =?utf-8?B?OGVCbEtyMm1ibWxaWlNDT09rTTJIRm9TZjRvZ2lwanU0TmhEQlpFMHlybGRV?= =?utf-8?B?MmFhNmhNVHN2SGpJT3BxVlVSdDBINVR6TjJ3NUpXekNPa2dINkNaUVpVVkRS?= =?utf-8?B?OE4zek9lY3dzL1Y2Tnp4R0NzcVJvZllHcmJ1YkY1TEk0ZmpLdVpxVU1XQ1Ey?= =?utf-8?B?S3VSUWVoOUVMTGU2SXpaV21ETjlNZnBsRE5aWWJyaW4zQmFrdGdmTFYxQ2E0?= =?utf-8?B?MGdOUHM5VXJCS2xsYyszQ3Z5WlkzcmxRSFRGdFllUHNSQm9jQk95QVQwckRY?= =?utf-8?B?dXlKM3RBZ2s4RTNoWHNvTVREOWVXc0YxR0hqcTRCTVkyMzV4dFZkdllCbms1?= =?utf-8?B?TEZXcG9rK2dkcnI1bFNrNFkwa0lmTW1ZcXpGczUxV2lnOSt6bWdrRit4amVs?= =?utf-8?B?N242SElPMmdDNXFtUUxTMnBjbjJ5bFBHR0I0WWZ3MFdOOFJmdXB4TGEzNEk0?= =?utf-8?B?VjU1d0o4NnBzL1huODVXbm9ZczJaalN1QlVaN3ZPenErYVpaZVlTUk5PNjlR?= =?utf-8?B?Q2IvbU1VWVdoU3FoTExFSlczVkoxT0xRY0IwOVNLK2ZnRmxTakhxdklVaEw3?= =?utf-8?B?aTBhRHU2eU1FaEIrOWh1V3gxZU5SWTJ0S09Sc2s2bnBzc2ZJSnM5YTJINDFh?= =?utf-8?B?QWNPY0ZVVnJXMk5uZm9Sc2ZUSzZqcFZBTUxRaWRNTW5ScitNOWVZbXUzNG1P?= =?utf-8?B?LzZKbVh2aGdvM2RuYTR5eWVzejdyNCs1ZVordVdNNEVaL3p2MnRMbVpFWkJL?= =?utf-8?B?RDJ2RXluZVNPNEQ2YytIeERyN3BtbkZacjNQYWIzY0I2VU9QZzZ1S0ZnYTl3?= =?utf-8?B?Mlh6dFp3QlVnc2NpRHBTQmd5cmlBWGlHRXM5U3VlSnFNaldJaEhFQVVIY2Rv?= =?utf-8?B?OXJkYXNVZTR2dENqWW9IU3pzOTNvdDBQMWNKcm5kd2pkeVFlMXBONERsZytB?= =?utf-8?B?TUlEOE1VVkhRNDZZemZxOUJkTm1FWmRBMFhQNkpRUkhHSW9MeFYxT294ckVw?= =?utf-8?B?TE11ekp0RUhKOHZYUmxteWxxZGc4eDVNZHA3N2syd1Z2NU9HWTFraUp2WlM1?= =?utf-8?B?aC9QM0FiU2srcko0VmlFdXRuQ3hDdDB2K3BuaWUveXkrVHZhYWd0eTV2bW5o?= =?utf-8?B?TytxMC8xUVBOM1k5aXhVcnhrejBtdjZucEE3N3REamNPWVljTGdxMmRoeDBT?= =?utf-8?B?U1FlSkhJak00T1JCSmY5cUR0YWdjdVlncmZyMHpkMWUrMHp2c3BpMktOSjg1?= =?utf-8?B?M1NCV3h5RDAzNlNtZ1d5R0NneDhCbnZtOTJFSlgzeEtmL1ZsQnUzZ0RJMDdy?= =?utf-8?B?bjFwbWxURW5HTFFCc20rUGIwM0lRVVJ5Uk5HeTM1RE82MWpWS3ZNZEsvNnho?= =?utf-8?B?SnExYVZ0OUJ5dlVBREZlOWJsK3Bnd3BBenlaWlpQUlJxWk5MUjFVWUgxdnlq?= =?utf-8?B?NkxQa1BrMWpua3VpaGZEdU1Sb1VrTU81ZVAyMDR5ODVvSjlrS0ZHM3k1UDNy?= =?utf-8?Q?TvHlE8A1EEa2C?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR04MB5151.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODRMeUNWNVR1eWZVUW5ic2xWZnd0dVNUdzFmcVpLY2Z3WUdFNkdwVmNQUzdT?= =?utf-8?B?aVhCbHIzL0xUd3Jra0trMWhEeHNoOUh6bDBlTkxaekM0bk1obkV1VytueU1X?= =?utf-8?B?MlZUNmhRaUZLcnF5ZUtjT0VWZlRzQ1VRTm11amFkQUQ3eGkwa1VqWlY2ZmIy?= =?utf-8?B?RU1qZUhVM0NueVFUZ1J6V3dUZ0dxOFFyUjlDVlVEdFNidCtkbTZrMy8zMEJ0?= =?utf-8?B?ZWQ1YjNYbkY5NWYrZDZWYTZmbnM3bjg5Rkh2Q1dyMjlMK1dRRHlGWllmRE5Q?= =?utf-8?B?SkUzaEZ3ODd6VjZrRkNIK3NqampIY2plN3FmYmNrb1F0cWMwL1RjSm4rWWtj?= =?utf-8?B?TnhzUTZrVTU3Z1M2cEx0YUV1SXJXT1gyaWMrNlB0cGw5OHg4ZGYwVFdxajRa?= =?utf-8?B?dm43OEpCaU1YVlBWNUs0dEZxWENTV3QvMWNVVDV1VURhS2x2UGZOTlQ0aXE2?= =?utf-8?B?SktuSmU4cWlBdVRTdmExRXJmVDJ2ZmVXUmJ2SXd2YXpQVXZTZHErbU9weUhF?= =?utf-8?B?aUNGblpSNGdudFFoMGlTclYvSUIvTnQycEdYZ2FseXNWK2IvS2t3cUhZQTY0?= =?utf-8?B?TUErRTNUcitJeWluK2IxMGYvRE14Tk13VysyRTNORWhhSitNMTRib3hlMGsx?= =?utf-8?B?RDE5dW00NDJLZVNCQ2d2dHcxNi9Ob3lOUiswcXpOeGRkUUwySnNVYmc0dlpS?= =?utf-8?B?TUtYUkRzRXl2eUpCVmNvU3FuWEtFMGRabmdpUC92N2l5d1FMOE1YRmxHaUFz?= =?utf-8?B?YjZ5aGJ2eFBIZGd2VmlwK3ppMThFV01kUmx6ZHloa05NajYzTTZlbTZxQlZK?= =?utf-8?B?VUtwcFlueFU0TTdadGs5MTNOcVdRZWpmTlhSd0RxN0hmVitBVFpTOEFXUVVk?= =?utf-8?B?NTJtVmJBSDRLU0hPaFFaTmcrSWdqUmk4NUpTZHE3TTI2QjhxdkxCTG8xenVC?= =?utf-8?B?YzRZTmFmdFdNOEloZUMwWXpBUk05Ymh1cENPa3NqcTRUUkttQzREbnRRUDZH?= =?utf-8?B?eFVCbFo0R3M0WU9KT0tKRzd3QmhJVGdQbExTbEI0SHJWd1dkQStrMHR1S3BU?= =?utf-8?B?RmY1eXEvb09BTHVUblhrMkZITi9DOVBBU2RoR3o5NHQrOXc5R2x4Z1BYTzd0?= =?utf-8?B?QXUvckdRWHpnRHhYQW54ZmpsMzdjTVlxMlBmRDA2RUE5R0JBZzBjTFJQNUhl?= =?utf-8?B?bXA1T1psdnNVY3N3ZDBvRnZPVmVVWWljNURVa0xwVCtKYUc1aFZ5clFvczB1?= =?utf-8?B?QWN6c2hlZkhrWW9jeW1LeHJMNU90d1UxYllMd2REMWpCcVpCK2VsbHYzSklG?= =?utf-8?B?bTE1SE1jcXVhc251ejdwbUVCQXFUajBWOFk3QUdXYm9ZakxZbjJvTFhXamtU?= =?utf-8?B?UFA0czBJTDk0d1NzMmpSdnBvbnVSL2JlMldab3NPcnViTDJuRWdYSkNpaHMz?= =?utf-8?B?WlJ5Ykd4S0lNNTkxb0ZyT1JoRExMcG1tMzZlTjNadGFWc2VFM0FRSGVCcmt4?= =?utf-8?B?eHpNY2FpbTE4NFk5UGNLVUNFbEZHYVg3MndzeVFEYkRVSU1PUFUzT0RNN1VO?= =?utf-8?B?c2tRNDlRMDd5SHZpMnpnU1kvMi9hOFpNcVc2UXVKWm9mejd0cTltVUliR1V5?= =?utf-8?B?dThRMDJUMzFLUDY4QzYydmN1UThUQWxXeXZnOG5KZVpsTU9SbHBFMy8zKzhV?= =?utf-8?B?ZE1KZk51V0xZQkR0NVVhTWg1WjM3YXFDeTdvR0t6U2FJaDUxbVBQeURzNXV3?= =?utf-8?B?Vk1hTmt1MWRnc1dITmRKbXJkcmZmMk1JM2JNLzA1QTJla0R5a01uSjg0VEUz?= =?utf-8?B?S1JQdTI3anJpSkZnNXJGWWRPZzl1bVFnWkVyOGtoVm9zdDlrVnBWQjFDczg1?= =?utf-8?B?K0J6V2dPNXM0dTBJUnpyKytCYjRVQ3RodlFtTkZOVkpLVlRaMFJ0Y3RWZWM5?= =?utf-8?B?WW4rSU1iNmlzK2d1Q1BhWTd1cHhmM1loQ3hTRUQ0aE5BUzNiS1ZaSmc3U1VG?= =?utf-8?B?dXJISEl2aTFkTmlmTzkzN3NMbTFGb0YxR0lSSkIyM3hjRUcyeEUzV0thUnVt?= =?utf-8?B?NitLR0Nia1NVeWRCRkcyTFN0N2ROVjVKSzFzVmVlZm1Qd2J5VUtxQlk3NUxk?= =?utf-8?Q?5+0qs+fI/UlXwFI/ErVYfko8K?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: b137c68f-c3b8-44ee-b934-08dd1f7b052c X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB5151.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2024 15:45:38.9677 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: We223Sa18tIsyTKNmgyRoibL3Ll3lhJ3Kg8axykxNHopU3srPV3GyIAqSIpbKO7/KHthK5hytWQCwnP/6NAhaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR04MB8761 X-BeenThere: cygwin AT cygwin DOT com X-Mailman-Version: 2.1.30 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Ken Brown via Cygwin Reply-To: Ken Brown Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com Sender: "Cygwin" On 12/18/2024 9:28 AM, Corinna Vinschen via Cygwin wrote: > Hi Ken, > > On Dec 17 15:23, Ken Brown via Cygwin wrote: >> Hi Corinna, >> >> On 12/17/2024 11:38 AM, Corinna Vinschen via Cygwin wrote: >>> Ideally a separate patch. If you see a chance to send it to cygwin-patches >>> this week, we can even merge it into 3.5.5, which I'm planning to release >>> end of this week (after that --> vacation :))) >> That should be no problem. By the way, I think I found a second bug. >> Shouldn't mmap:649 be >> >> (*) if (u_addr > (caddr_t) addr || u_len < len >> >> instead of >> >> (**) if (u_addr > (caddr_t) addr || u_addr + len < (caddr_t) addr + len >> >> ? >> >> If the first condition in (**) fails, then u_addr == addr, so the second >> condition is automatically false. But what we want to be testing at this >> point is whether the matched region is big enough, as in (*). Or am I >> confused? > > u_addr could be < addr. We have two areas, the free area in u_addr and > u_len, and the requested area in addr and len. > > So we have to check that addr is >= u_addr and addr + len is <= u_len: > > |----------------------------------------------------| > u_addr u_addr + u_len > > |--------------------| > addr addr + len > > Make sense? No, I'm still confused. I thought that the interval determined by u_addr and u_len was the intersection of the requested interval and the whole interval of the mmap_record; this implies u_addr >= addr. Back in the definition of mmap_record::match, we set low = max (addr, get_address ()), and then on success we set m_addr = low. Doesn't that imply m_addr >= addr? Sorry if I'm just being dense. Ken -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation: https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple