DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 4BHKO91L125972
Authentication-Results: delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results: delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter: OpenDKIM Filter v2.11.0 delorie.com 4BHKO91L125972
Authentication-Results: delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=i8Er38K+
X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 117673858C48
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1734467047;
	bh=o1HgIQo964wAeCQIM4zldHEJ36eemAGqDTrCnuDdb00=;
	h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	 From;
	b=i8Er38K+ikqtOJPeM40OAivU/0yuBqBfkChOteS8zTyNV0J2uBJkuRoId/sWUydbu
	 yVIEqP8jKTcMB2Pt4AbgwSejwGVtVPoHvSSkGiPLJgmeRDmsJHbXyP9s/AHlVoorUS
	 uqRK4d/djWzoV16dNfrf6awojXr5e+HWuZBHF+Nw=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC2803858D1E
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DC2803858D1E
ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1734467018; cv=pass;
 b=r791Wx9afh+apXS7crg0Q09s9t9kydPo8dG+l/fMSBKVGShX8I+pjeZghavm2qyWDpfaANxMlMiJDUtuLh6V29Ek1joFMe/rlQOxDT6gKn0dPlRKMp1Je1fu2Mzuk/90JNZw25WBkbV/ignmQqACVEGm8vidzRwpxwE8lclPcUM=
ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key;
 t=1734467018; c=relaxed/simple;
 bh=+VxiV81rTKkeRoRDQCURjpKrg6xlhzaluOC41T+V+Z8=;
 h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version;
 b=bCS4GBd3KGfdGDoZr2/P63R6dTLi22PoNdHBcskTyhWxwi0eAOs32+ov+8zeFcHsrw/IHqqaKtHJA4HoU51ptQQl/d+cajrXDSRBdm5fMsjjRTYMGtzzY6XpXHjsJb6ol/vevrCMxopJ0dLgdQgMXj2dyqgi0n5XwgzXHjuZq8s=
ARC-Authentication-Results: i=2; server2.sourceware.org
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC2803858D1E
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
 b=ZmYvYYqlIheYvXE6O5yykcmv/9zCSB93oHgjF7eZxv0EKUnQ9ZjjWRcBGvpp1ZnHIsqbhuiROrmWcKCOkcqRHSpbsJL0RV06gZdz/N/9Uvq/a+0catvkdnT0rfEirEcOsHhrIQhPxLhI+EVzhIHnlWOvhj8p1ircx3GIN739M6vhXh8JZctvAoGJaQWeCyuK0inLSIpbKQcjgtdJ6LVIN7WSJFc7e05tiVB18jl3kJ9bdtQ4B+uUPOKT8g1v/TIk6FAasJyxJ2cihGGtp6QcRtNc8w6tqMn9tXRHYBICC8tbZdWN+cFGJBwK8vA75z5IDJGgBCbQJ4nfwNUrSnxNkQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector10001;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KFGZUEdutznuSC+LAmRxxFq/fKnZ0KWgNoaaI30vN1o=;
 b=pNkDO8WZtRNzhjAaoruNpRYqszOoGFMj0HeozAMxW1JR5KJIUuh1195Lr1CGvBXnVdVO0eikPT6nC3BWIDOfG82jFJ7f/PO2aKilN9m/H6hphAbWo1elodOtXJjX1lvguBnmLcZGPYbW4TGFkbiweYLc/w7n1lWVhff7CF0chpGxfFPygpUWFToX0UWd14a+iU2jiki12bo5yS4uyyi6casl2ka5WB7VLRGXyszbqNcyUVlVmZ5auyafM6D3bsZ+/fN/Rc5bqMahgTYVMtlSCGl+JKytvilGx4DybT68JUYlM25aS5eBoa7ogUKa/QHPAQKw8CJreZxfFPZBs4iK0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu;
 dkim=pass header.d=cornell.edu; arc=none
Message-ID: <cbeac0c9-70a1-4be9-acbb-eceadfde2e1e@cornell.edu>
Date: Tue, 17 Dec 2024 15:23:32 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: Atomic mmap replacement
To: cygwin AT cygwin DOT com
References: <66bf4f86-4618-b9a3-3e33-2c240b9204d0 AT cornell DOT edu>
 <20180219090042 DOT GC3417 AT calimero DOT vinschen DOT de>
 <e6b3bd42-f981-405e-b65b-529693598735 AT cornell DOT edu>
 <d84f7f6c-5527-4f39-83a5-1aa16d8e451f AT cornell DOT edu>
 <Z2AsCg7Oo4FyHFjG AT calimero DOT vinschen DOT de>
 <b7564609-6a87-4691-b5ec-1f56b51543df AT cornell DOT edu>
 <bb796c13-c2b7-48a0-899b-cc7485fee783 AT cornell DOT edu>
 <Z2GpCxIUDMqp6yen AT calimero DOT vinschen DOT de>
Content-Language: en-US
In-Reply-To: <Z2GpCxIUDMqp6yen@calimero.vinschen.de>
X-ClientProxiedBy: BLAPR03CA0045.namprd03.prod.outlook.com
 (2603:10b6:208:32d::20) To BL0PR04MB5140.namprd04.prod.outlook.com
 (2603:10b6:208:56::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BL0PR04MB5140:EE_|CO6PR04MB7522:EE_
X-MS-Office365-Filtering-Correlation-Id: 765a54bf-378e-42bc-e29a-08dd1ed8aeb3
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016;
X-Microsoft-Antispam-Message-Info: =?utf-8?B?SzdTK25LaTgxV3FVUFN1YStyTW50OWdjOFVYcmJpTktnaVMyRHBSdmdGYnFV?=
 =?utf-8?B?N1hwV3J4Y2IvOWw5N3ZjdFQ5bVR5VWNSRjlDOUxTQnJlZXpxVE1ielg0MlVa?=
 =?utf-8?B?cDNoOXB4K1VrVnZnNXloc3RjNmtOcXM1WVhsMXppeEhGN3hXaDNaajBsc2JI?=
 =?utf-8?B?Rm1hT3dFczE3N3M0bmlZZEVEN2xkN1Z1K1plWEdYVHJFL0VPUjN6OGNXV3RU?=
 =?utf-8?B?b1dBM2x2TEZqNDVCck4xd0hZZXNSY3BpOFJFRWM1YVZkZEtBS09Za2ZVcGRS?=
 =?utf-8?B?L0hXaWl3K2ZmV2VHUDZFbXFIV2IzQXZUL0ZFcEQ1QkJIU1BCQmIyYit2S3hD?=
 =?utf-8?B?ZSt3TVUxOTRMWFhCQzRJK1VpV1QrdnYzYkRsV2NDUTd3Z0xzN0VPckdHSUQ0?=
 =?utf-8?B?NkRENzU1NDYrY0cvMDRNZ1gxM25lSVFSelYweFFNMSt4NjBWWVE0enRwL1Vl?=
 =?utf-8?B?R0IxUEJCVkZ1R0dlU0IramxKb2svdmVnem51TWVTMmVMMk5yYmZFMWZESklO?=
 =?utf-8?B?SGF3L2dvTTY5UmptaHYvRzh5eHMvTkpoeHJTVk5PNDU3RDUzVWhYRlZJUHFB?=
 =?utf-8?B?akRkQUNVVVlqYnY4Q2VjNHBoTEFLR29ySVVGeE1HNVI2bkRhQ1ZGcnl1QnY2?=
 =?utf-8?B?bGtPd1B5NkhLOUM5MlE1aURhMkdQMjZnbitlMm1mZmwwMHBEWk84UG5SOTgv?=
 =?utf-8?B?M25iWkpIbFFINjl1ZHpYbGh4RjVpbnY1Y3ZqUWx0U2VZcUwxTUJjSWppcG4w?=
 =?utf-8?B?OVhoN1c2TnVjcndrS3pwVUFUTUFFaWl3ZHJRYzJFUkdiL0pQa0ZZZnluSWpN?=
 =?utf-8?B?UG1NTmtWT1B2VEtnb1pPZEEzbUZGbW1sYitaUUY2enh4bVZZMGdhUmRFRjZV?=
 =?utf-8?B?ZjRyMkZ6TGppOFI5ZWpjb1owNWxTaUkvYkVzYXNseXVzcCs2UVNWTkRuOURm?=
 =?utf-8?B?UlZ2UEJPVm1pdGhyRHZ1Zzk2UUpoTy9MQ010WkVxeThGeDl2Ynh6UWJCeHlo?=
 =?utf-8?B?aEY2cE4wcVZmUzZDNm1YTHJkNlRQY3RPZDlHcytPeUhKU3hBVE1BTWZsMUdh?=
 =?utf-8?B?c0xSUEx5ajhaN1NXdm1iVzRnME5wN2NDbWw0NzIwc0pyd2JjSlZqd2ZXKzYy?=
 =?utf-8?B?NVlUM1l1WUFDV1RtR2pJc1JUYWI1c3FEYXJDMXIrS3M4b2hCeGFrcDJYc1BJ?=
 =?utf-8?B?dWZGeCtjVDNucDIzVW9KTTJWVVdHWExmR1RjTmtiaE5SdFpPbWk2QS9qQW1Z?=
 =?utf-8?B?ZnRsTmZNcVlSME5MU25xNC9lcU8ra21qNGVLa2VRUjZmMjByRnkwdFYrbkNr?=
 =?utf-8?B?WmFrRGJJU0FyWExMQXR5VzNVZU4wdy9GVE5LWGxrNVhkUTM5RFRTc1pnTkQz?=
 =?utf-8?B?RzdxMWgrZS9hYXlmWm1KaWp4TGg5R2xvVk9lVUxVRGZ4NkhDaFVHSWw3WlFU?=
 =?utf-8?B?ckswbUV0eEJ2QlAzTzNCVE83QVUrRE5TN1I1RUg5dEhlVU9QK0pQRVIyZnlM?=
 =?utf-8?B?cXYzQ2NHUi9RSGNFYmxnVHBjVmZLbU1GTSs0VjR6MEw5UzdaTENuUXNVazh6?=
 =?utf-8?B?YnYxdUNNd01lUkx5bXU1VzVrVnRSQjVQNEZ4YjVJc0dETkVJU3ZmREhvOFhm?=
 =?utf-8?B?UkE2VmcyMFI4ZmgyVlhhdllVMkg4aGFKenZNbVN6RVZLSEpQclFoZlRPQXU1?=
 =?utf-8?B?WlB5VDMwUWNSMUl2MXMyc3BvdVBMQUlTRnBuNUJkcDJLL29tNkxRcUVaa3NV?=
 =?utf-8?B?OUJTRkpkS3RaM1dTTURsNmtpaXN0aDBJbi82cG9wUWQwUDBPT1pNVEM3cUZ4?=
 =?utf-8?B?c1RWbWlBNEd5TjNmVDN0UktpK3FLc1BKREhMc3dVci83K2tNenZlSkNDZmtq?=
 =?utf-8?Q?Bmq2xWqaDJinT?=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:BL0PR04MB5140.namprd04.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1102; 
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1ZLRjB1TVg3UTVXZCtObTNCcmFUUEk2Qi9pVlBUTktUYU53MHMwMTBpc09S?=
 =?utf-8?B?OWZabUVuVmZwRE5peUxyeHM1TDlFaTVxMjNoZW9zSTE4eGZsY1dJeCtJWVhI?=
 =?utf-8?B?WDdCNGIwc0ZLMGFEelhJRC9uTlBXeHFMN1lVT0dRdDRNSTM2Wjh6dy9EOEM1?=
 =?utf-8?B?WWZIVlRmK2JWQ1hwcHZoRE1ZaGZaRDNGV3FsRUpTRnIwZkptd1R0UFY3eUZQ?=
 =?utf-8?B?dGJYMCs2ZkFvcXBIL3J4UFNaWTNVZlZwSUxkMjRMQndzUW56ZldsNHJRdDBm?=
 =?utf-8?B?UTVVQmhXR0dRM0lXZTQxZ0RUZFgvMmNLRmV2QW9helFNMnU0Vkl6UXRwU1V4?=
 =?utf-8?B?TEIwbXBHTnd5QXVZZUpvMnlBNGRwMURtTTNQUmFaL1ZadHRPNllFdG04NjE4?=
 =?utf-8?B?K1hwZ0kwTkkxSmJ2YjM0OHJLcUFqNEpFVUphUnlLT1Vvc2piQTJwNk41ejlx?=
 =?utf-8?B?YXliUWtCMTlwakJ3c3NmekE2NXFhTk8wQU8xcUdMVWhjbHhoWFArOEI2TTlB?=
 =?utf-8?B?ejlLZDVyLzlwWUtUbDYxOUhLcFhENDZVNnZST2l5bW5TV1BLU1A0UnBzbEhS?=
 =?utf-8?B?WDJpODJuME9RRkNKQmZrVU8zOFM0bTZLeTFxa1VzTHBRU1NEK1dKRXk1Sisy?=
 =?utf-8?B?Z3RkZzdFVDFFTmE5b0ttN3lWUmVwcmFIL1Zkb0ZuSTdGbGdVRGJDZDg3YVJs?=
 =?utf-8?B?VkxIOVdjQUZYODNRRnRESERnTkpXOUFmVnVvYzhwVEpXV2RucmkrZHU5a3lU?=
 =?utf-8?B?elREeUN6Y0FBdmo4MlEwakNsVk5GVkFwcXkvYm5NVmR4Z0xocjNGNURKTy9R?=
 =?utf-8?B?aHJYSzlwalBJM2hyR0VQT0VUS1hHTXc0OUVzSHZBRHAyYXZrUmFLK0xicWZ5?=
 =?utf-8?B?THk1OEQrVXFac1lMdzBFMmx6cmJNSFgvekt1MUJMKzBiRnVZN1BjdjZ5TGxn?=
 =?utf-8?B?UXFiQjlLN2U4SXJ4K0FGa0lSUWY4ZHYwVGdIa1MyZ055VFRnQURydDN4OTk5?=
 =?utf-8?B?KzBNTzNURDlKeTJnK3l3ZGkrSC81YjByTXFnaGVTT2ZwdzFVZ1NzTUZsbVNY?=
 =?utf-8?B?V3RUcjl6amZMTzBhZllUVjhrV2RWOGJQNzZDaU9OOVdKcm5DSUtKbW5ETEph?=
 =?utf-8?B?MmZtS0g1d1ZuVnJkTTEvNElyK2JrdVliYnV2aVFHcitVSm1FVHpVWjR3MVhE?=
 =?utf-8?B?Y0xQY2JMcTJFalgvcDdxY0VxMXd0akpGV2hKdklsalErZHhrSTNNQ1BSbXJr?=
 =?utf-8?B?dDlVREFYRlQ5MGhWc0NaRmtXWlBjK1hVb2lKSXFWdzAyMSsyK2hpS0xWaEI5?=
 =?utf-8?B?a0E0c3FNNFRVdjdTeG80Y0kwcGtXQTdnOG5ac0c5YlVuWlhwMVFjQTk2a29a?=
 =?utf-8?B?MWJ1aTB4c2VnYWhlais5c2RELzVhcVBTL1hYQk41SGs0TzMxM3BLR00zUEdG?=
 =?utf-8?B?THYyclVXd2JSVWtvaGpmS3phV29Pb1pmdmVYYXQ2WGhLLzcwaTZRYk9pc1Fq?=
 =?utf-8?B?UFV0ODlPbmNEWXQzblpoaUFvNHJLYTR1QlhiSGQyblNsRW5MQ3VDQ2l4OUpp?=
 =?utf-8?B?ZVllTnNwdm5rRVRPNXFjN1hJSExRNjBsZ0FXWVVkZXdmWFlCR2gwM0JLMjRY?=
 =?utf-8?B?MkNMWEwvSno0UzF2c3hUVng1MmZqNDBOZFNXWTQxM280bGZEbElGYnZWSGg4?=
 =?utf-8?B?dE0vTm92K3Z2MGliUnRFbWlEb29adVdWN2ZWYkI5MWpjZnBiSGpPdVhwN3Nx?=
 =?utf-8?B?RXlpdllDSTFLVHBXUFRjY0FqS1BSREwrSGRObkthb01tVHpTMkpJZkRzS0JD?=
 =?utf-8?B?M2d6TVRpc2JGdTJKdFZyZ0ZLdnA5UFBGV0pVSXJidWxmL2VJOHAzZkRYeUly?=
 =?utf-8?B?WWdBVnpWZDhnQ0ExYjRwWmpTWmZqM3FVZUhGaE5sNVZPZVYvYlhySHovbk9o?=
 =?utf-8?B?YytnOVhMNTRBRnY5RVdRNDJER1dKQ09QWE9xSW4rYnNPc1JzYWJQdTlxQUtI?=
 =?utf-8?B?SFJuNnBDUTFrd3BKejVCZzJydGRFVU9PSVVUSXZvdnZsQlVpaFYwYWVJWVlH?=
 =?utf-8?B?bDRML01XcTZDb0o0Rkh3ZUtUYmFLd3krZStLUDJsL2tKMnp2Q3l2bXFrVng3?=
 =?utf-8?Q?RSn+8S3CZN59Dxtj8JJe0JGx1?=
X-OriginatorOrg: cornell.edu
X-MS-Exchange-CrossTenant-Network-Message-Id: 765a54bf-378e-42bc-e29a-08dd1ed8aeb3
X-MS-Exchange-CrossTenant-AuthSource: BL0PR04MB5140.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2024 20:23:35.1261 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lArtIeTZjrWmbN9KisoQoSW72lF06s2cR0/3b/327q5oS3bsgGHpIRIvR5Y3GSAD57bPKXDlHfQM2q5KYTAwKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR04MB7522
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Ken Brown via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Ken Brown <kbrown AT cornell DOT edu>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

Hi Corinna,

On 12/17/2024 11:38 AM, Corinna Vinschen via Cygwin wrote:
> Ideally a separate patch.  If you see a chance to send it to cygwin-patches
> this week, we can even merge it into 3.5.5, which I'm planning to release
> end of this week (after that --> vacation :)))
That should be no problem.  By the way, I think I found a second bug. 
Shouldn't mmap:649 be

(*)  if (u_addr > (caddr_t) addr || u_len < len

instead of

(**)  if (u_addr > (caddr_t) addr || u_addr + len < (caddr_t) addr + len

?

If the first condition in (**) fails, then u_addr == addr, so the second 
condition is automatically false.  But what we want to be testing at 
this point is whether the matched region is big enough, as in (*).  Or 
am I confused?

Ken

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple