DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 4BGJx8Ut3831587
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E050A3857C5D
Message-ID: <b7564609-6a87-4691-b5ec-1f56b51543df@cornell.edu>
Date: Mon, 16 Dec 2024 14:58:35 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: Atomic mmap replacement
To: cygwin AT cygwin DOT com
References: <66bf4f86-4618-b9a3-3e33-2c240b9204d0 AT cornell DOT edu>
 <20180219090042 DOT GC3417 AT calimero DOT vinschen DOT de>
 <e6b3bd42-f981-405e-b65b-529693598735 AT cornell DOT edu>
 <d84f7f6c-5527-4f39-83a5-1aa16d8e451f AT cornell DOT edu>
 <Z2AsCg7Oo4FyHFjG AT calimero DOT vinschen DOT de>
Content-Language: en-US
In-Reply-To: <Z2AsCg7Oo4FyHFjG@calimero.vinschen.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0x4M2ZLazBDSFN0cjZ0QWtUMkRYWDNnZEJWN0lZcDZ4VURTNFZsUjNBcmlS?=
 =?utf-8?B?VGdKUzFvbW5ZdEk5aG4yZXVodW83Q3ZaNDNMZnYwNEZOejBYSkZGVWdwaUFG?=
 =?utf-8?B?UUo1U1k3a3k4Mk9zNVBManBNKy9YMTd1Z3VBUjl0S0ZPUXN5bnZFNzN5bklG?=
 =?utf-8?B?VkRCQTRjQUF4ZnVPNW54b0JROGhFSjRzQkRpV1ZvaWxvU2FqZlhsZ2d1eXlW?=
 =?utf-8?B?OHVjTUdCN08zdkFHMHBkZ0QydXdJRCtFcjdaNm9waWZSTHlRRVIwUkFHbTgw?=
 =?utf-8?B?YkJOTm93TWZGR2xhL0RESys0NDN3c0s3empQV1lmNnlPSlM2UzR0OS9kUEVG?=
 =?utf-8?B?ajFib2E4dm1vaFBCVUhQR3FtWjZObEMxODg1WFdRTEZtSkxUWGl3cVpXVmhK?=
 =?utf-8?B?N1ZtMWp3b2FaczQ2VzQ1RDQ2elJFYXNiOE4zbG00eTIwRlFjeUN3eDBIMXVq?=
 =?utf-8?B?RHFOYTRmUkE4MEN5TGNPT2FnQllMZ2JHNUlSSFk5R3U0OVg2NXFYZCszRnFY?=
 =?utf-8?B?cG9HS3p2TW9oNXp5NW85L0FCTVdWVktOSUZMTXhjOXZuRGRGeEw2MWkxZ1hZ?=
 =?utf-8?B?d1lGeEhMY3I0R29GdXNuRXhOVC9XOWw4dGQ5SkJGdGJCa2RGMnREV1BhRHRK?=
 =?utf-8?B?ZE5XTXljelRzbXNWbmxlNW9zWE9hUVlGbUljcmNxaTVCSDYvVE91c0x4bzRX?=
 =?utf-8?B?aEVab2ZWVHo5dFJaOERma2FhQ1lvbzJGQStrK0JidXpSd0w3VmhmQVJtSHdN?=
 =?utf-8?B?SnpwWjIwMHhsTlB0M0orTVlncEl4cWt1TFh0SHAwV0JIOWZJU2hTSnZoeGxT?=
 =?utf-8?B?bWI0QlRnWnZaZjVETVRsdTFoWjMzRitqeEJMVHhLSzNBNXE2aFBxc1JpZ1BE?=
 =?utf-8?B?eCs5RmF2dTIxaGJSdFlCYVhML2pESnhDbG9kZDlHZmtLNXBmUkxvazNDMEdn?=
 =?utf-8?B?MU8yQ1FGUE8rS1o3VVhjd2I5cEtLOXAwQWNYMG1lcTcxQU5vQzFQVWJ0bjQ4?=
 =?utf-8?B?Ym5pa2hhL0MrSitTajNQdUtqQVozYm9ROG9zVFAvTHVwc25RZXZVdUozR1Zm?=
 =?utf-8?B?a0t1aUo0OHdRdEhTU3dTd1h1dGVZQythZlRVa2Z4KzVScFRQdXNQODFVTTNi?=
 =?utf-8?B?SlFlWGppcnpTYjIvWW1sZlhicXpVdDRLbm1WVkNuSmVWTGk2dVNHd0d5VzN1?=
 =?utf-8?B?QUxTdC9BNGlLQ3FZYVBLbUw5ZDdweDNBSGEwN0l2SytBUGRpaTFydWI4VGtR?=
 =?utf-8?B?OTRQcDY3UUVHZ2htOUNjeGtyTlpjN1pFcWZYd2RObHNrVGd6cEVVTndITVVI?=
 =?utf-8?B?clhCejdEcXNKYytXVmJ6OFlNR0t6TlpweTkyRVllYnczWmVoSmR3YmlwSmJ5?=
 =?utf-8?B?bjY4bFppa2dUcjZwWGd4aFdzQkk2ZmxucjhZb1VBR0xVRGZ6R0l2VkdhbjRG?=
 =?utf-8?B?MzU1TEg4UW1Nc3BqRUdoUlNmaEdyOE9pdis5cWFIUmhJU09Pbzg4bmxKVEd1?=
 =?utf-8?B?alFaWTR2azVQYlVUQUdmazFTdFl1Sk5KdGMyRWdrV0FEWFVkOG5tOGtDU3lF?=
 =?utf-8?B?ajBJMWZDUHhpZlh5OUwzNElwRkZGSmt0YWJ3UndGaGI2Tkp0RnErY1lYZzQ3?=
 =?utf-8?B?d3dUbVhGNjJ1SVhYcEdrVy9WczZSVmk0UlRkelFTOFdVQU0vT1g2ZkMycUps?=
 =?utf-8?B?bFJEaGtRencwMDlDTHp2K1hVUGhvMVl3NlpIUWJFWm42czE5bzNpMldleVg1?=
 =?utf-8?B?c21uc3ZoTDNrbjhVQ1ErSUFDOXZSbEppdTg5bno4TFVLb0JqR1pRWGtKenda?=
 =?utf-8?B?V2dpZ1JITDcrNzExRzl1eHRaRFdJTFoxS3hCemp1ZG9SZ2E2WnFMaFpWNGxV?=
 =?utf-8?B?OGV2WThtdDdabG5BSm84K3E5dHhnQjlJajZVbk9TeFl5Z2l1WTNiS1dLbEs5?=
 =?utf-8?B?cXIxMWd6bmRFU25aSzdKZXk4eFM2UkRjVk52eUxQdHJsT202MTRRUVprOVRF?=
 =?utf-8?B?L05HMmllckx6bnJGcHVYa2ZOdE1WQlNJbE83SkZQbTJPMXVBejBJTC9YUlNE?=
 =?utf-8?B?VzdZcHhWL2hWWVAvMzdiUmxBenNneWpyaEVjd1EzSkJteDlneThGSFlwM2Vm?=
 =?utf-8?Q?8nQyms76yQdmX/XTQEPQaWu2s?=
X-OriginatorOrg: cornell.edu
X-MS-Exchange-CrossTenant-Network-Message-Id: af7b2050-69b4-4d30-bf2e-08dd1e0c0756
X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB5151.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2024 19:58:36.9710 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NdH+/1++B77k1hszyxmmkA+Gk0E9U3pGXVdlxDtqOS3IHtZt6xaMkVz7HMZ4WhiuSsDijLujRYICT57PFFXlLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7255
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Ken Brown via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Ken Brown <kbrown AT cornell DOT edu>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

On 12/16/2024 8:32 AM, Corinna Vinschen via Cygwin wrote:
> Right now, mmaping with PROT_NONE and then re-mmaping with PROT_WRITE
> doesn't work.  Cygwin implements PROT_NONE not as MAP_RESERVE, but as
> MEM_COMMIT with PAGE_NOACCESS.  mmap() doesn't check if the requested
> pages are already allocated with PAGE_NOACCESS and then succeeds while
> in fact just changing the page protection.  This is basically what
> you want.  Right now, you'd have to call mprotect() instead.
> 
> With anonymous mappings only, this is all just adding a bit of code to
> mmap() to do what mprotect() does in this case.

[...]

> So only anonymous mappings would be possible, assuming we tweak mmap()
> to check if the old mapping was anonymous either and then allow to
> just change the page protection, as if mprotect has been called.
> 
> And, funny enough, something pretty similar already exists in mmap().
> See mmap.cc, line 1051 and the mmap_list::try_map() method.  Right
> now it only checks if an anonymous mapping has been partially unmapped
> and can be recycled.  But it could be improved by allowing to recycle
> the anonymous mapping either way, as long as the new mapping is also
> anonymous and the SHARED/PRIVATE flags match.
Thanks!  This looks doable.  I hope to get back to you with a patch in 
the not-too-distant future.

Ken

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple