DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2EA4E385DDC7
To: "cygwin AT cygwin DOT com" <cygwin AT cygwin DOT com>
Subject: setup.exe: Improvements of DPI handling
Thread-Topic: setup.exe: Improvements of DPI handling
Thread-Index: AQHa0BEvXUoMMieH+UGUq4V/eG36DQ==
Date: Sun, 7 Jul 2024 02:46:27 +0000
Message-ID: <CY8PR10MB6562B602DC0709BA00E404F5A2D92@CY8PR10MB6562.namprd10.prod.outlook.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
msip_labels: 
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [GAYkyj3uSSrdrXAml9sapA9xAJFsSHxf]
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CY8PR10MB6562:EE_|DS0PR10MB7979:EE_
x-ms-office365-filtering-correlation-id: 2680d942-2787-4dc1-d71e-08dc9e2effc8
x-microsoft-antispam: BCL:0;
 ARA:14566002|8060799006|9400799024|461199028|19110799003|1602099012|440099028|4302099013|3412199025|102099032|3430499032;
x-microsoft-antispam-message-info: D/yRRAbB3qj6HcLvRcGOLhXInOD/BNfwwt4CAkXBktvfwxETvbf4BwdJ8+U/axrYToCiryBRrOQO72DtN9mgrSNZLPUIoxf43TKPkjdXMvVrdgu+CUwEZCbIEfh+eqSN7MgCp1NQqra8tUIbQEdcORKzayXlQvdouzfk/bNKWW9NQKrnPVujsTbbnZUHdjiADYXGfT2q7+YUeZAxgBmYEdPNfD6Vc8fGXSImXPMHPZqWCLlzyo6IIkffqeKFxQDdRuxqDPGfYdUftHtYtdJ6N3umevZuBGJNQ4uLawjnFyX5MMQfZkGoI70JmYuzDIpweOBuT9Arz6vEp1HfVxbOu8zUvSmpXg4pcOoZ1rvnIii6NcNkzs3Ij78C2LAz4KFejVCW8u+svgkDWJ8VpVOoci490P8a7fg2sdMjSVVs8dy2fsuUffcgdcWEEme9sj0nZfCTgnmGsUJqjuHhNQWG1j+m3JRFeid5a4mXzZfQCtu20rBY3uwsMJWQHZRcf8D5z5Pbhk2dtcex3dDYbGSHmJDYBYJ8IzjxHv5BeighcDUvb7d9LVS08jlx64I3itf0lah+0uc367pgXVE4MI63stSzK+Epejg9bneNmA5vcxg/UMDaM/B3eqKJ2x86Zz/PxzBktn1IH9Q3ICR1esO//r1tAnFD32kWWhXGAdPCkSMuZuyU/+/OphsuBxuGetD4jPcl72471Oy+RFKN433jgmOwO7tDYYdsOLvPj3y1KBqE8/ypb0Ojr2f645i6PrxaLBINWEelaRkB6A7OaplY8oUjNbLqntEe0/95JSLnuWc=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?gb2312?B?NlAxTjdoTTlSclJ5bU9ZaWwrQklSaTZRWHlxYnJLMEtLTHI0YnJhSFhFZWFh?=
 =?gb2312?B?WitzZ243SGY5QVFzZHVac2pUdlUwSldYeEtxdHRocEhzOGRJMllpbC9PMGlS?=
 =?gb2312?B?bXk3K1ZkRWhsSlduZGcxdmk2M2VOa2p5cGxINTEvaUpLMGJGR3RYUjdpR3l5?=
 =?gb2312?B?cVNEbWtQdjFaTmVOMERjWENmbm45dGdZTzY4dWhveVRXRFA4S3JwMVozb3E5?=
 =?gb2312?B?dkpmV0tLYmFEaEZySlA2Nk44YTRiVnlYa2g1cThDSzQzMzVvTHMvaFZub3BO?=
 =?gb2312?B?c0xxTHNMV3llc0Z1WUVaM0JpWkVkMk5ONnpxV1dpeGxzdTN5dGhCb0VtMjQ2?=
 =?gb2312?B?T29FdVdTR05JSGFaNHh0RUdsY1BiNHVaY3lHa1N3STJwODhuOUZyRHlEQ05X?=
 =?gb2312?B?VmtNTmJJeEE3ditzL3pKRnU3YmZDaVBZTFB5TUJUSmYramxkRmNhTjNIVjAv?=
 =?gb2312?B?YUhHSzE3YldNbTg5cWhvcjYyNktXT0ZtYThFaGhNR05OVXcyL1RiNS81QzlH?=
 =?gb2312?B?eWgrNGJ1T29jNUdjaG1mMGVncy8yOVNMUjJDU2kvS0RFcUhvOVBOZmhwWXg4?=
 =?gb2312?B?SXNyRXZNeTh1Yzg2TFo0SWRzQURadmdkbGFDT0hUY095Q1k1RDVrOWpUb3Bh?=
 =?gb2312?B?MnRmdm9keGNUN3l2S1o2QkNFQmk2UnhxOENWZ3p0T0xYK21jRlNOZjhRaXFt?=
 =?gb2312?B?UUgxNWVCUjltUzVtVnVCellPVlM2TUVEV0RRTVRLWUhmSldBVTB0QlRleGlB?=
 =?gb2312?B?VzljcWZHU0VBQXBIbXJ3QWNTRGxwaGNsdGtFb1c1TFNUNThiTEFVT2xQd1N2?=
 =?gb2312?B?SW5zZG1WMndIYlMvWGxVWUQzRGRFQk9pTERtRTRkVG04ZVVYcXV6bnlQUVRC?=
 =?gb2312?B?bHh3dXB1S3ZFM0JqM0pidW9Fdk9qUGtFcmpxWEgwbnk2bFhVVzhXRlFCNllq?=
 =?gb2312?B?YUprY2xibzlNbEhRUmlnM1Q3T0VsdTdNQ3ViL3hoOXJWMENBZFM0MUZZTnNT?=
 =?gb2312?B?ZmdoYlh2ZUs1M3FVVWZmWEpKR0FjMlVJT2x4VE1LUnIwRy8vMzJDdkVieXZ6?=
 =?gb2312?B?MFA3MlZPaTVwZWhmV3ZQb21Ha1dCQUFoWlgrOVdGZzFlcnMybWJZbnBEQVlO?=
 =?gb2312?B?dzN0TUhHRmdYb2JCeWlSemU2TFIxWEZXS0k5a1ZWUHpmd1BESkdyM2xWbklE?=
 =?gb2312?B?MTdHSDY0dmZ6ckhaMHNqUmlNNTBoZ3p4R0VteFU0UkZmaEwxN0EwTWxsNktI?=
 =?gb2312?B?M3VEb01KTERWaWtQdnpnYVRxOGRmdkNqS3ZFeFNGbS81d0cwY0ZoR3FDZUpC?=
 =?gb2312?B?VjVVK21kV3V5MWovRVZ1bHUvZHdMa0xHYUg4aXFJY0NwejZaL0loWVI5Tmlh?=
 =?gb2312?B?QXNHVEFXVEtsV1prWXduM1JvanlFTlQ3QVZERm9ha0pjdHVwaXhPK09oSDFL?=
 =?gb2312?B?SW9GZ0NhOXdIb1dLdHhnVE5HTTZVak9qN3pJTUFVS21GTTV6WjVILzFyVXoy?=
 =?gb2312?B?aFRlRmFqcHdCVzVYbzVHbitqeVZDWGp4ZHp3cnM1TlZSblZJaU4wRlJrVUh3?=
 =?gb2312?B?YVlGbFZ5Mm1QbzdPcE9OYlpya3JGaWFpT3lLN3ZpNTRQd014SENXMEZEZ3F0?=
 =?gb2312?Q?iLtXAd8MF6FLexlSfBQA0Xq0I5Z6Wc4hogjeXY2cEAZ0=3D?=
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-28291.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB6562.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 2680d942-2787-4dc1-d71e-08dc9e2effc8
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2024 02:46:27.6365 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7979
X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP,
 URI_TRY_3LD autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-Content-Filtered-By: Mailman/MimeDel 2.1.30
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Yang Yu Lin via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Yang Yu Lin <yylofficial AT hotmail DOT com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

When running setup on my device (Windows 11, connected with 2 screens which use different DPI revolutions), the setup appears bluury on my secondary screen (not on the primary screen).

Because current setup.exe.manifest just set the dpiAware element, which causes the setup cannot handle different DPI on different screen, the current solution is to add dpiAwareness element and change the value of dpiAware to true/pm to handle DPI in per-moniter mode (patch attached). More infomation can be found at https://learn.microsoft.com/windows/win32/sbscs/application-manifests#dpiAware and https://learn.microsoft.com/windows/win32/hidpi/high-dpi-desktop-application-development-on-windows<https://learn.microsoft.com/zh-cn/windows/win32/hidpi/high-dpi-desktop-application-development-on-windows>

Also, the necessary options to use the Unicode version of the Windows API functions is also added in another patch to avoid localized message is incorrectly encoded when using the --lang option.

From b9d42a8fa57f76e637672f1772780f21eb17da57 Mon Sep 17 00:00:00 2001
From: Yang Yulin <yylofficial AT hotmail DOT com>
Date: Sun, 7 Jul 2024 09:07:58 +0800
Subject: [PATCH setup 1/2] Added Unicode Support

---
 Makefile.am | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 72c6610..5afea69 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -22,13 +22,13 @@ SUBDIRS := @subdirs@ tests
 BASECXXFLAGS = -Werror -Wall -Wpointer-arith -Wcomments \
               -Wcast-align -Wwrite-strings -fno-builtin-sscanf \
               -Wno-attributes
-AM_CXXFLAGS = $(BASECXXFLAGS) -std=gnu++11 ${$(*F)_CXXFLAGS}
+AM_CXXFLAGS = $(BASECXXFLAGS) -std=gnu++11 -municode ${$(*F)_CXXFLAGS}
 AM_CFLAGS = $(BASECXXFLAGS) -Wmissing-declarations -Winline \
-           -Wstrict-prototypes -Wmissing-prototypes
+           -Wstrict-prototypes -Wmissing-prototypes -municode
 AM_YFLAGS = -d
 AM_LFLAGS = -8
 WINDRES = @WINDRES@
-AM_CPPFLAGS = -D__USE_MINGW_ANSI_STDIO=1 -D_FILE_OFFSET_BITS=64 -DLZMA_API_STATIC \
+AM_CPPFLAGS = -D__USE_MINGW_ANSI_STDIO=1 -D_FILE_OFFSET_BITS=64 -DLZMA_API_STATIC -DUNICODE -D_UNICODE \
               -I$(srcdir)/libgetopt++/include \
               $(ZLIB_CFLAGS) $(LZMA_CFLAGS) $(ZSTD_CFLAGS) $(LIBCRYPT_CFLAGS) $(LIBSOLV_CFLAGS)

--
2.45.2.windows.1


From 288e01f0c55e6aa5a9f93b0a633278a2ca1d8d6a Mon Sep 17 00:00:00 2001
From: Yang Yulin <yylofficial AT hotmail DOT com>
Date: Sun, 7 Jul 2024 09:37:05 +0800
Subject: [PATCH setup 2/2] Added dpiAwareness Element to Manifest

This causes top-level and child HWNDs are notified of DPI change,
which keeps the content of window not appear blurry when changing DPI.
---
 setup.exe.manifest | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/setup.exe.manifest b/setup.exe.manifest
index 45a5f08..f3820fa 100755
--- a/setup.exe.manifest
+++ b/setup.exe.manifest
@@ -40,8 +40,9 @@
     </application>
   </compatibility>
   <asmv3:application xmlns:asmv3="urn:schemas-microsoft-com:asm.v3">
-    <asmv3:windowsSettings xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">
-      <dpiAware>true</dpiAware>
+    <asmv3:windowsSettings>
+      <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true/pm</dpiAware>
+      <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitorV2</dpiAwareness>
     </asmv3:windowsSettings>
   </asmv3:application>
 </assembly>
--
2.45.2.windows.1


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple