DKIM-Filter: OpenDKIM Filter v2.11.0 delorie.com 451LCOh53069514
Authentication-Results: delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=ECFnMamW
X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 237383890000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1717276343;
	bh=5586Tne2jvTLc2WtUcKGsJRoprF9zXK8nwui0j17jgg=;
	h=Date:To:Cc:Subject:In-Reply-To:References:List-Id:
	 List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
	 From:Reply-To:From;
	b=ECFnMamWDqVbm/d6QSjL52LkZMxrvU3prUzwUV0iEH2nUvIx5U9PveIf5nEZooiwK
	 IaiLDXdcqqzV6Scxbpoim0zI2BRGDqb/qKayuQp1Xo5ssUXxbXdYnCTLQsydewAJ4G
	 LEiVeJx3ABrhnSwORclp8HgoM61dbKd89DFWV0UU=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66451388982B
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 66451388982B
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717276291; cv=none;
 b=DU5xc9+HLYWeQYZc/gfVpmv/3JvaqyjxqbaAS4GVuaJt9f0RErc+K4/1h7oDCJ91fYXJE0Y/HZPQzC3TWip9tJHQuYZfgL55JNzeetabAWSPQS+If4H4xM3Mqo7gpewvreFDWcVcPYiznWuoMm+OEpRW0wVXdGn1yPUn+chZym4=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
 t=1717276291; c=relaxed/simple;
 bh=0H57UQECAt+l5YpRXH9wNWQxtGUUA0dd3TVtktl1bvA=;
 h=Date:From:To:Subject:Message-Id:Mime-Version:DKIM-Signature;
 b=kD5ngfAYrI2ziTjj6d9xEdfFX1JThgxmA1sUDI8HiLOQh8W4tDL3XQDz9aL5kN8KlujyShIOg3Zt0WTib84InHyDxuFnrmmC1VLCkey9ez4WdZv6ntFVeO1awmfsVRsYK+DyHho99+OiWXnKL+H4ZuYYA93dGX9jFe8rgkRWW8E=
ARC-Authentication-Results: i=1; server2.sourceware.org
Date: Sun, 2 Jun 2024 06:11:26 +0900
To: cygwin AT cygwin DOT com
Cc: Bruno Haible <bruno AT clisp DOT org>
Subject: Re: [PATCH v2] Cygwin: pthread: Fix a race issue introduced by the
 commit 2c5433e5da82
Message-Id: <20240602061126.ecd712bdefb5e6cf5b00674e@nifty.ne.jp>
In-Reply-To: <8f6e5346-52ff-4682-ae9b-de345399b28c@cornell.edu>
References: <20240530050538 DOT 53724-1-takashi DOT yano AT nifty DOT ne DOT jp>
 <20240530205012 DOT 2aff4d507acac144e50df2a4 AT nifty DOT ne DOT jp>
 <20240530205918 DOT 7c730117b567bb3bec3a0c3f AT nifty DOT ne DOT jp>
 <4338587 DOT 3DMzsUbDvx AT nimes>
 <20240601231830 DOT 882dc56aadb9c3087bcf4b9c AT nifty DOT ne DOT jp>
 <8f6e5346-52ff-4682-ae9b-de345399b28c AT cornell DOT edu>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32)
Mime-Version: 1.0
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, NICE_REPLY_A,
 RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Takashi Yano via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

On Sat, 1 Jun 2024 12:08:51 -0400
Ken Brown wrote:
> Hi Takashi,
> 
> On 6/1/2024 10:18 AM, Takashi Yano via Cygwin wrote:
> > int
> > pthread::once (pthread_once_t *once_control, void (*init_routine) (void))
> > {
> >    /* Sign bit of once_control->state is used as done flag.
> >       Similary, the next significant bit is used as destroyed flag. */
> 
>          Typo: Similarly
> 
> >    const int done = INT_MIN;		/* 0b1000000000000000 */
> >    const int destroyed = INT_MIN >> 1;	/* 0b1100000000000000 */
> 
> Shouldn't the constants in the comments have 32 bits?  Other than that, 
> LGTM.  (But you should wait for Bruno to confirm before you commit.)

Thanks for checking!

-- 
Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple