DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC29738708DA
Message-ID: <8f6e5346-52ff-4682-ae9b-de345399b28c@cornell.edu>
Date: Sat, 1 Jun 2024 12:08:51 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] Cygwin: pthread: Fix a race issue introduced by the
 commit 2c5433e5da82
To: Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>, Bruno Haible <bruno AT clisp DOT org>
Cc: cygwin AT cygwin DOT com
References: <20240530050538 DOT 53724-1-takashi DOT yano AT nifty DOT ne DOT jp>
 <20240530205012 DOT 2aff4d507acac144e50df2a4 AT nifty DOT ne DOT jp>
 <20240530205918 DOT 7c730117b567bb3bec3a0c3f AT nifty DOT ne DOT jp>
 <4338587 DOT 3DMzsUbDvx AT nimes>
 <20240601231830 DOT 882dc56aadb9c3087bcf4b9c AT nifty DOT ne DOT jp>
Content-Language: en-US
In-Reply-To: <20240601231830.882dc56aadb9c3087bcf4b9c@nifty.ne.jp>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVhxbEhwdnlKaFI0WGRIZDNGYjVscWNKSHYwakpEeFkwdlhBc0RJMjFEVXJM?=
 =?utf-8?B?YTBlVFo0RUNZTkswWmIwb1lHRG5BbTdheUZsSmFEZ2tVMzd6NVJLWUxmNktY?=
 =?utf-8?B?bDJCMGtlZlVkYU11eVRQT3RWdnpzNTNWL3hISGVOV0piNXljTXJ6czVKY21R?=
 =?utf-8?B?NUtiYUErMjNQRDVzRHorWjk2UFFQRkZqOUIxYm9jUFlsVG1YaGg5WWFDc25D?=
 =?utf-8?B?SldYdGc3Nm9HUVRYSzdDb01uZmpwaktua0ZzZVBQc2N0aE14R3lpbEhmam95?=
 =?utf-8?B?emI3QVRmMUx1WC9McTA2Ly9oUjR6K2hxNURtdHRFWWExM0U3Yldkd29kVHJL?=
 =?utf-8?B?M3dINENmVWYzK3pNSGhpZjFTdThiVGlYejhnNzBsc3ZNZDQyallDWmFiUjJC?=
 =?utf-8?B?eWRsNGlIdGtTZUFSRmxiZ0dVVE1BMlh4RnVmQXBCYjJhclo3aFF0ZnFtMlZk?=
 =?utf-8?B?N2lMMi84Y1RjTjZ5UVVYaXpOWmQ3bFAvSk41TGRSZlllOW1NYVF5Z0NGRkw1?=
 =?utf-8?B?YUpaL05paUtiSEhHaExtUTl1QWpYY3lYUG1wbjVSR1N4eFcwV1VjeVFxUGZ6?=
 =?utf-8?B?cTRqcVRyZGhMN0I5clF3dGZoenFSY3FnVjR6Z0pwQVNnV0pTWXMvcXRuYVp5?=
 =?utf-8?B?ays3bURnckZ4ekxnRm53SnFsUlMzekZMYnNTdVVhellBdjJ0L2dUdnJzMkdl?=
 =?utf-8?B?RmM5clJLVXFsYmVLYXI5QllBRmFpeHUwTWF6UThRWmEyc3htNURZd1RESmVN?=
 =?utf-8?B?VDR1RWxtblZvTVlzNmYvV3daNGJEQXJFc01WQTJmZXdlVWk5SHNjQ2xDUmJO?=
 =?utf-8?B?c1dDbjNlS3VORnNIYmdNWjljUDYvREtkSitDZDNncnU3S1cwOTlaM1IyRzN1?=
 =?utf-8?B?OFhBNTFHblRtN0NhOG02VkxLZTFpQTJSSDdxSVdnMkJSc2dMaVhSeUlRWm5w?=
 =?utf-8?B?ckREOERNeUhpMjRoWlROY3l2M3BXN2F0TXlxM21WNEk4YjlXellRdUVCei9Z?=
 =?utf-8?B?WGZyN2FPUmhaRDdJMFpyS1NoVzRhV2dGVHlMM2pGZDdJQkVHWXg2SEx2UHFo?=
 =?utf-8?B?TFRYck5SRFlKL29nb3BOOFB4TG9IT1lhMTkvak5LNUl5eWNFYmkwbzQybWYv?=
 =?utf-8?B?SDJjc0NZZ0lLbEJUWnVrWG1qQ2V2aGVhblVQSzR6elVjSFFWOGNBcWZRTkVF?=
 =?utf-8?B?dExRMjdvZ0ZaUk1YNWlEcjVwVFB1Y0k5bEQxMHZMckVCN2pFbHQ2QkVCRkh4?=
 =?utf-8?B?S3JyNEZDK2JhOEJkYzJZVlhhWEJ2NU5PNkZjMTRITm9qS2pOclpzV3hsOVgx?=
 =?utf-8?B?TXJsZlpkSE0wamNoZUJvODRPeGhhUFA2SFdyOXpPN1BhOEVRSVQ3WTFEcjNj?=
 =?utf-8?B?T25LTThib3VsMTcwRENYNE41a01TUjVYQUlHT1ZseE80QlFnKzJzMk1WSlB1?=
 =?utf-8?B?N2RLUTFKT1dDUkpKOXVjTWNXTWR0UzJLY00ra2RSSGs0V25CZkhUZ1JYWEw4?=
 =?utf-8?B?QVptRGhRSGg3dCsra0kybVhrWjJKemI3N3hKd1R0SFRSazhFamNGOFRSdnBL?=
 =?utf-8?B?NnhIaVhtbmFVb05xUWZIYUtnaFJZaVJFalB0MkpQdklQcjN2Q2JLKzIyUkoy?=
 =?utf-8?B?V09iazYwYlB1L1EzVlFwS016N3NHZ2gvVmN4M2NRb0NoM0NZVzRGT0Q1RGJI?=
 =?utf-8?B?MUR6clUyMGZzSWZUYmZMbitHUjI2UTFwaU14QXpxUmQ5azY3OHo5T0ZxcW0z?=
 =?utf-8?B?NlpZOExXOCtXNE96djg1Lzg2R0hLUlFXdmMwQW9hOFdGSzlXN28yMXpuRllQ?=
 =?utf-8?B?NDdBNm5PcUFVVlJnTDFyaU9JZ1I3TFFwajU0NHEvVm53eGc5aXNVY09Xcllw?=
 =?utf-8?B?MVowSEZhZjJGemVrWlBlZE1OaGNKMGQva2krWlF4QzdKUjQyRXN3RmpnbVZr?=
 =?utf-8?B?QmcvaTNCSGFvRlh3bUcyb1AvVjhDUUtGQVpRblFIN2dNKytxT1IvbHBrTFlt?=
 =?utf-8?B?Q1ZMbVdmajY0UEZMdGNrSnF0MUp4Tk50WlFtb3NVQlFmMzAveGgwTDZubXdM?=
 =?utf-8?B?VUtpVjkvb3pteUVFSnQvK0dSbzRNQlgwUng5RnRBZkw2a2Mwa216aDBIODVB?=
 =?utf-8?Q?63Zk5JodrREnCaOjIVYlpNAiq?=
X-OriginatorOrg: cornell.edu
X-MS-Exchange-CrossTenant-Network-Message-Id: 6185cf3f-bb07-439d-8e0d-08dc825522d5
X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB5151.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2024 16:08:54.9375 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ct8ILQWQuygeT6/5+tVRsigNQOu16xuU71Wuto+rBq6t869UQfAPy0Q8rc7NNq7A4fH47ISFN3K8TNUJlpK/Gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR04MB9187
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, KAM_NUMSUBJECT,
 SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Ken Brown via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Ken Brown <kbrown AT cornell DOT edu>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

Hi Takashi,

On 6/1/2024 10:18 AM, Takashi Yano via Cygwin wrote:
> int
> pthread::once (pthread_once_t *once_control, void (*init_routine) (void))
> {
>    /* Sign bit of once_control->state is used as done flag.
>       Similary, the next significant bit is used as destroyed flag. */

         Typo: Similarly

>    const int done = INT_MIN;		/* 0b1000000000000000 */
>    const int destroyed = INT_MIN >> 1;	/* 0b1100000000000000 */

Shouldn't the constants in the comments have 32 bits?  Other than that, 
LGTM.  (But you should wait for Bruno to confirm before you commit.)

Ken

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple