X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5BA513858C74
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1712048277;
	bh=hdv1ME+NU7tSRTn4ICWngM5elFRHuDSLdrzbhtzhnf8=;
	h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	 From;
	b=tIMLwXvCoHO/O3Mfo6LEbImV++AB53Tkswpn4YNZnEtmVd57zgpzVSwUePdeUJuyY
	 hl9icq35tYJQmgHXguavI76bifh9rNSvIsUbBEcpIR8NcROiEf+Av2l4WvnAuErV8U
	 3XO5BfkyqFcrmvzdeypwaGfMDBiirIQIzH23TBYU=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13F413858C32
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 13F413858C32
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712048251; cv=none;
 b=NKJdaeUe1sPS3yy7aSKDuRSx7Y0WqOrxw9yAeSasKlcl2MDWzlpPJB5OQ6cFhiUcWm6/kVj2jNoyjBHNNVTAOX8HxuhbVON/VhWVAqeLHImCDf4tjmmZs/w8zv+O0OxbWm1gD6MnIFUErdWmoSGSNeQZOD3eLn457WdSJtq37ps=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
 t=1712048251; c=relaxed/simple;
 bh=NriCXiwuQuNzNBFxXUzxW1ZliSrndDL7HAhzrn9SrIw=;
 h=Message-ID:Date:MIME-Version:Subject:To:From;
 b=qvSVuwTI2L0pdPJmejdJof1H0EXZ3tWXbEv4RHLiM9tb6emX7Tj8gPzuFQqx2Brgfco/iy8NwnSNH+FU3E10rLrVANT4WBvegTZE6XfahbqpvMheff1eVgvncKDKWSRwHrA0z6o0QacwdHqM1eHQz0a0XQzNTfZiA0vcIU9AP0M=
ARC-Authentication-Results: i=1; server2.sourceware.org
Message-ID: <72594c25-f142-42f0-b4cd-e2650e8044db@maxrnd.com>
Date: Tue, 2 Apr 2024 01:57:19 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: util-linux-2.39.3-1: libblkid returns invalid physical_sector_size
To: cygwin AT cygwin DOT com
References: <0fb74540-3878-206d-b623-15437fe79b01 AT t-online DOT de>
Content-Language: en-US
In-Reply-To: <0fb74540-3878-206d-b623-15437fe79b01@t-online.de>
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Mark Geisert via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Mark Geisert <mark AT maxrnd DOT com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

Hi Christian,

On 3/31/2024 1:11 AM, Christian Franke via Cygwin wrote:
> Testcase:
> 
> # cygcheck -f /sbin/fdisk.exe
> util-linux-2.39.3-1
> 
> # /sbin/fdisk.exe -l /dev/sdd
> Disk /dev/sdd: 465.76 GiB, 500107862016 bytes, 976773168 sectors
> Units: sectors of 1 * 512 = 512 bytes
> Sector size (logical/physical): 512 bytes / 34359738880 bytes
> I/O size (minimum/optimal): 34359738880 bytes / 34359738880 bytes
[...valuable investigation and patch suggestion elided...]

Your suggested patch looks fine to me.  I have added it to the patch 
deck for a new util-linux 2.39.3-2, which has just been uploaded.  The 
patch allows fdisk.exe to report the three correct values in my limited 
testing.
Thanks for the report and the patch!

..mark


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple