DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 341973858D28
To: "=?ISO-8859-1?B?Y3lnd2lu?=" <cygwin AT cygwin DOT com>
Subject: BUG: gettimeofday() didn't handle first argument being NULL
Mime-Version: 1.0
Date: Tue, 20 Feb 2024 19:15:34 +0800
Message-ID: <tencent_ADE1F2996E16CBB6F3A2956A2044485DD105@qq.com>
From: 109224573 via Cygwin <cygwin AT cygwin DOT com>
Reply-To: =?ISO-8859-1?B?MTA5MjI0NTcz?= <109224573 AT qq DOT com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

this code works on Linux, but not msys2:

#include<stdio.h>
#include<sys time.h="">
int main() {
&nbsp;&nbsp;&nbsp; struct timezone tz;
&nbsp;&nbsp;&nbsp; puts("a");
&nbsp;&nbsp;&nbsp; gettimeofday(NULL, &amp;tz);
&nbsp;&nbsp;&nbsp; puts("b");
}


I guess the reason would be
winsup/cygwin/times.cc

extern "C" int
gettimeofday (struct timeval *__restrict tv, void *__restrict tzvp)
{
  struct timezone *tz = (struct timezone *) tzvp;
  static bool tzflag;
  LONGLONG now = get_clock (CLOCK_REALTIME)-&gt;usecs ();

  tv-&gt;tv_sec = now / USPERSEC;
  tv-&gt;tv_usec = now % USPERSEC;


If so, the fix should be add if (tv != NULL)

I found this issue due to https://github.com/redis/redis/issues/12719</sys></stdio.h>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple