X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6FD8538582BC
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1704238027;
	bh=/JTHThoiXt175r5CkS+bmVXFwUmi0dByt4ajnG4IuDU=;
	h=Date:To:Cc:Subject:In-Reply-To:References:List-Id:
	 List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
	 From:Reply-To:From;
	b=KOVJqm6+SDbmKlO0hz4TnvWnLroTAHJHGT43yEDztkAn4cJXJVCXGp80zsqcrrNTu
	 7huQS+RHkcrxSzYHvmCCqr8aOxtN4rkVwkI+Mt2PcOJLvyUABJN/3Wb1A4wuqBCoMB
	 tCSeuDRoYJiON5K1DLGb11D1D97dfEC2VsNSsdtg=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F4683858C66
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F4683858C66
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704237961; cv=none;
 b=iEkq21STmQ5uR+N7ytVkNOznpFGYYiGr2Xo2VmtsFjsYtWA/D6ZOSBSRBNexBlAolrUtdn/JNcR068jklfwJ1uKZGWBu+7FnHhxCqgh0XLcvUEgonn260qcsYQUTK3F61TXa8GN74TUX6aJ3NnEPlNzkJkEwFT0oz1dsbaVempQ=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
 t=1704237961; c=relaxed/simple;
 bh=UnoG49IXWGShKn5rGf6jbchluX1IiCrR3741l1lZ5dc=;
 h=Date:From:To:Subject:Message-Id:Mime-Version;
 b=FjRWEe8AvWWqbsgywBdyh0Rlmq50Ic1sEpsgDsZDJXWn/HkKXX7SV4PzU+oPsdGxH8ucjPNp06sdLnAkn4jS/vO+A1toBcSS/Da+de5E/ikkPRZygZYDYdhmeK7ib2V+XVrAMaTM1U4BUdmAr1RTLthx8rvTeU2ZD10j+vOLTMU=
ARC-Authentication-Results: i=1; server2.sourceware.org
Date: Wed, 3 Jan 2024 08:25:56 +0900
To: cygwin AT cygwin DOT com
Cc: Kaz Kylheku <kaz AT kylheku DOT com>
Subject: Re: Possibly buggy use of ctype.h macros.
Message-Id: <20240103082556.8ba92d98e1023f6e6fb175e2@nifty.ne.jp>
In-Reply-To: <e7301d2e6aef776277cd6d81be0424a8@kylheku.com>
References: <e7301d2e6aef776277cd6d81be0424a8 AT kylheku DOT com>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32)
Mime-Version: 1.0
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Takashi Yano via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

On Tue, 02 Jan 2024 14:18:15 -0800
Kaz Kylheku via Cygwin <cygwin AT cygwin DOT com> wrote:
> I noticed that this macro, defined in winsup/cygwin/local_includes/path.h: 
> 
>   #define isdrive(s) (isalpha (*(s)) && (s)[1] == ':') 
> 
> is being used with arguments of type char, like dereferenced "char *" pointers. 
> 
> Unless the isalpha implementation is robust against this, it should be isalpha((unsigned char) *(s)).


https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=newlib/libc/ctype/ctype_.h;h=a73870b3e4ade5545fd41bcc6f10446a22b4b46e;hb=HEAD

https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=newlib/libc/ctype/ctype_.c;h=32ce4f3187dc528c3103d6d884708d7f364a6698;hb=HEAD#l82

-- 
Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple