X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D9B7D3858011
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1704233920;
	bh=ZQEnKTUWA4DYhJrBFSeY9zO1BJAFp1qLRH5hrjOcv3M=;
	h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:
	 List-Help:List-Subscribe:From:Reply-To:From;
	b=BodADjKYRhjy7PjYp8UVeShSkC5HayqFGuczY0IAZoGbBbu+COSBkU0KMDWJqQ/xC
	 ZflGZ87MeRcFFPnPbajn6ZYKyS9zp399hYnzAzsJeFsKaI/dL2VqU/qWipGNeMDgD5
	 0NhaNmt4FjlH/AJ+8ZV6FUEXw+x3Sut1yCJSAH+U=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E398F3858D32
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E398F3858D32
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704233900; cv=none;
 b=oxs+z3cpFV+Ou5/F9Vr8NzDRUOMlJxzCtDFjFJZlQOgfuxqvn+NNym2PCN9L6X4lyVzF2cAUGbi9CRzaeU/m20Bs1zk2kE5P8O6Cy9X576ZNt52hykDpCN8/DyLgssnGCR7nlGMtH5lHHYJp8u9b7xzzPRf4WKRHXMCqxuPtGKA=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
 t=1704233900; c=relaxed/simple;
 bh=0BXe7LtnCx6dPmf4DuuI/RKbP6B25TWq30xO0KF6Lt0=;
 h=DKIM-Signature:MIME-Version:Date:From:To:Subject:Message-ID;
 b=H+83GRRUYnq/nq/GmZ93gk4zrGPfvW1K1oZ+tC09Veei69mTgOCGD31K/BFMRHTpd09wityrxat/9xiduA+tl9C5M6c07wqzVv/2X5/V3P/7kdvekh6QRSXhmZ7QbAnHfRhp4kruN/6eVisZpxrEkG2E8aZuqOBa6Rd/bevybzc=
ARC-Authentication-Results: i=1; server2.sourceware.org
X-Authority-Analysis: v=2.4 cv=KJNJsXJo c=1 sm=1 tr=0 ts=65948ba9
 a=pMSlDXUwMa7SJ1EIez8PdQ==:117 a=pMSlDXUwMa7SJ1EIez8PdQ==:17
 a=xqWC_Br6kY4A:10 a=dEuoMetlWLkA:10 a=JxO-F9HAsX61K3wg56AA:9
 a=CjuIK1q_8ugA:10 a=qftUfvFSv24jhhKMgwsA:9 a=_W_S_7VecoQA:10 a=QEXdDO2ut3YA:10
MIME-Version: 1.0
Date: Tue, 02 Jan 2024 14:18:15 -0800
To: cygwin AT cygwin DOT com
Subject: Possibly buggy use of ctype.h macros.
User-Agent: Roundcube Webmail/1.4.15
Message-ID: <e7301d2e6aef776277cd6d81be0424a8@kylheku.com>
X-Sender: kaz AT kylheku DOT com
X-CMAE-Envelope: MS4xfMaqiMkrozWqzE6t+xEMBLxYt/zON/7Y9APP2y23gDN8BqbJ6zjYYC6Ihs9Se4LSqaU1uKQ9Lgq3SWv9T2kr3naaxImUhwpRMeZ5TT6Ac2My9KZDPEz4
 p+8iVPFN3xuS0K6UMaur5bcm30H89Z3a7EznBA9pRiY4vVGpbOksl2yD
X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,
 RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-Content-Filtered-By: Mailman/MimeDel 2.1.30
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Kaz Kylheku via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Kaz Kylheku <kaz AT kylheku DOT com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

Hi All, 

I noticed that this macro, defined in winsup/cygwin/local_includes/path.h: 

  #define isdrive(s) (isalpha (*(s)) && (s)[1] == ':') 

is being used with arguments of type char, like dereferenced "char *" pointers. 

Unless the isalpha implementation is robust against this, it should be isalpha((unsigned char) *(s)).

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple