X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 80E8E3858401
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1692913217;
	bh=So2VLp+KYec8io09tAzo/5ZVnE2vChtEncmfImZMvso=;
	h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	 From;
	b=TN3avDG9TwcKYoJnIcFg6NfH5xCJxf4V8O52jih1NLPoEWL7oWrQZ0WqBGtt8GEd5
	 7IgB3M+Y7PU4eh3Fuv7PmH93KpFdFJ0Enh89CBZ5Daz+Pb06ORgk41wOdZuycuzB/d
	 yh+q1ndHrt62AbxXVTuLolA5NQAxYtVjm6JMiuVM=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BB353858C2B
Subject: Re: can't compile coreutils-9.3 any more after upgrade to cygwin-3.4.8
To: cygwin AT cygwin DOT com
References: <83C27059-CB24-48F5-AC91-AB0622DF82CD AT Denis-Excoffier DOT org>
Message-ID: <aa38a12e-875a-bfaf-6427-2f8d05c0bc47@maxrnd.com>
Date: Thu, 24 Aug 2023 14:39:36 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Firefox/52.0 SeaMonkey/2.49.4
MIME-Version: 1.0
In-Reply-To: <83C27059-CB24-48F5-AC91-AB0622DF82CD@Denis-Excoffier.org>
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, NICE_REPLY_A, SPF_HELO_NONE,
 SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Mark Geisert via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Mark Geisert <mark AT maxrnd DOT com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

Hi Denis,

Thanks for the report.  More below...

Denis Excoffier via Cygwin wrote:
> Hello,
> When i try to compile coreutils-9.3 under cygwin-3.4.8 i get the following error messages (see below).
> There seems to be a kind of loop in the hierarchy of #includes.
> Moreover, with cygwin-3.4.7, this is ok. Also, if under cygwin-3.4.8 i remove the 2 #includes from /usr/include/sys/cpuset.h,
> this is also ok.
> 
> Regards,
> 
> Denis Excoffier.
> 
> 
> 
> In file included from /usr/include/sys/signal.h:23,
>                   from /usr/include/signal.h:6,
>                   from ./lib/signal.h:52,
>                   from /usr/include/time.h:158,
>                   from ./lib/time.h:47,
>                   from ./lib/sys/stat.h:44,
>                   from ./lib/fcntl.h:64,
>                   from ./lib/unistd.h:99,
>                   from ./lib/stdlib.h:98,
>                   from /usr/include/sys/cpuset.h:12,
>                   from /usr/include/sys/_pthreadtypes.h:12,
>                   from /usr/include/sys/types.h:221,
>                   from ./lib/sys/types.h:39,
>                   from ./lib/stdio.h:69,
>                   from src/chroot.c:21:
> /usr/include/cygwin/signal.h:121:3: error: unknown type name 'pthread_attr_t'
>    121 |   pthread_attr_t *sigev_notify_attributes; /* notification attributes */
>        |   ^~~~~~~~~~~~~~
> In file included from /usr/include/signal.h:6,
>                   from ./lib/signal.h:52,
>                   from /usr/include/time.h:158,
>                   from ./lib/time.h:47,
>                   from ./lib/sys/stat.h:44,
>                   from ./lib/fcntl.h:64,
>                   from ./lib/unistd.h:99,
>                   from ./lib/stdlib.h:98,
>                   from /usr/include/sys/cpuset.h:12,
>                   from /usr/include/sys/_pthreadtypes.h:12,
>                   from /usr/include/sys/types.h:221,
>                   from ./lib/sys/#include <sys/cpuset.h>types.h:39,
>                   from ./lib/stdio.h:69,
>                   from src/chroot.c:21:
> /usr/include/sys/signal.h:227:29: error: expected ')' before 'int'
>    227 | int pthread_kill (pthread_t, int);
>        |                             ^~~~
>        |                             )

ISTM the above could be fixed by moving "#include <sys/cpuset.h>" after all the 
typedefs in <sys/_pthreadtypes.h>.  That would be an odd location for an #include 
though.  Another approach would be to have explicit external refs for the needed 
two functions in <sys/cpuset.h> and remove the #includes there.

> In file included from /usr/include/sys/stat.h:22,
>                   from ./lib/sys/stat.h:47,
>                   from ./lib/fcntl.h:64,
>                   from ./lib/unistd.h:99,
>                   from ./lib/stdlib.h:98,
>                   from /usr/include/sys/cpuset.h:12,
>                   from /usr/include/sys/_pthreadtypes.h:12,
>                   from /usr/include/sys/types.h:221,
>                   from ./lib/sys/types.h:39,
>                   from ./lib/stdio.h:69,
>                   from src/chroot.c:21:
> /usr/include/cygwin/stat.h:27:3: error: unknown type name 'timestruc_t'
>     27 |   timestruc_t   st_atim;
>        |   ^~~~~~~~~~~
> /usr/include/cygwin/stat.h:28:3: error: unknown type name 'timestruc_t'
>     28 |   timestruc_t   st_mtim;
>        |   ^~~~~~~~~~~
> /usr/include/cygwin/stat.h:29:3: error: unknown type name 'timestruc_t'
>     29 |   timestruc_t   st_ctim;
>        |   ^~~~~~~~~~~
> /usr/include/cygwin/stat.h:32:3: error: unknown type name 'timestruc_t'
>     32 |   timestruc_t   st_birthtim;
>        |   ^~~~~~~~~~~

I don't have an answer for these.  Awaiting more input from our wizards.  I'm 
willing to submit the patch for any agreed solution.

..mark

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple