DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DED553858C50
Message-ID: <5b6899da-555a-6574-6e8b-43c2288f636e@cornell.edu>
Date: Fri, 24 Mar 2023 09:57:31 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: newlocale: Linux incompatibility
Content-Language: en-US
To: cygwin AT cygwin DOT com
References: <bd7ebebc-cf90-d509-ef15-11d702a6126c AT cornell DOT edu>
 <ZBzBL2jFO7Oltjd1 AT calimero DOT vinschen DOT de>
 <ZB2U/JCFrwSUo1+U AT calimero DOT vinschen DOT de>
In-Reply-To: <ZB2U/JCFrwSUo1+U@calimero.vinschen.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEw4a2puOGpWczVKV0ZPa3cwZmVCMXJLNXg2Tk5TOTJuRjVpTG1QV0orNDZY?=
 =?utf-8?B?Wmo1Ny85dFVoUlc5MzRJVm5WcWczZnhaaU5rNjF6bFIwSzlzZDRtSDI0Q1Q5?=
 =?utf-8?B?NGZsc1BJOWtBQ2hWSldmeUVZZExybDRXUkw2QjlYRVQwb0hGMnZIaXRSUmNN?=
 =?utf-8?B?bFYxYVoxMldiSTFkaXphOVBxa0dTVDNYa1F0THpaYUF4eXFBK1dlTjBhckRO?=
 =?utf-8?B?SG9YUExTd1FjMDJONEszOGNlNXVyMlhQbGZCNmNDbkFuQnVOM0dVUjh4R011?=
 =?utf-8?B?bm1vVkxoRm1uTVZiVU1VdmFVakR4cGJkR1pIc0dnalBZM3dMTjdhbVJOcWVn?=
 =?utf-8?B?dnh3Q3BMOVE1MkxVaEViZVFZa0dwQ2h5c3dLRlFJQ2RlTWk5OEhrMW4xcUx5?=
 =?utf-8?B?aWd2aGFMOVludTlZVEdsak45bjJxc2UrQlFwN1Z2cGdNOEsreExSNXh0S1R3?=
 =?utf-8?B?cy9aVlJlQ3lkbUJ2aXZXUWg5R0VSY0k2YkkwdXdHMDJCYUYvdXE1WTdkaVRP?=
 =?utf-8?B?WWFDL2d5ZGxnQU9sanI4WVN0RUhQYjhHYlU5NXVKTFZjUkFvc2Q1Q2ZCMDdP?=
 =?utf-8?B?YU1WVEg2NXlnVmJtZTJVdVNGUjM3bEZpTVlGVyszTE5UTXFwMFVUY2RiRFk2?=
 =?utf-8?B?VGtTWGZvb05lV3ZXcTlDUkM0OFpvSTZQTGRDaXNuZmM2eFlrbWl1ZWlTZUVv?=
 =?utf-8?B?ZXlaaGM5RWt2Rnk4R1lvMk1qMzJNd0M3YmtXbENUek85NExGazVDdDlmWDl2?=
 =?utf-8?B?UHhHcldXRDF6T3BTbUJzWGhhZ2ZDSml0OTRkQjhPZzR3bFF5elN3aTQyV0Vw?=
 =?utf-8?B?eFhEQjduR05TRkZTa1JFSFlvSkUwaFhlSUdaQVVUMXhkYkJ2N0pWdUJWbVpm?=
 =?utf-8?B?S3VzUE9JdlJJK1dCaWFDM1g3dldKNVZ2cWsyYS9uVTJlYkVZa2t6cnRCd1U0?=
 =?utf-8?B?RklZZElGZ1F4MUxJUWFteXVPQ2RGdzRFWjQ2dTVQNy83VnVzeEk5VWd0R0NV?=
 =?utf-8?B?cy9FVUZUbU9UUnY0L2pEckJSTk0yT0h3TE12TExIRXcyRnJpeXhzWmN1eU5x?=
 =?utf-8?B?TW1TYzBZVnBHZUkwdll6TzMrS3g2clBiLzVTT29XaDhHbTVTc0J5ZGY5ZGJR?=
 =?utf-8?B?K3BrWlBLa0ljdGhRdTJFaE5IS29zamhWYXRsWkorcUpiL251dTNjQ2dmamdK?=
 =?utf-8?B?L0IyOXozNnlhQXBlakVuR2x2aURKUWRodFlMUUlSMmRtbmV5dkc2Wm1mN2pM?=
 =?utf-8?B?TjlTbUJtd2haMDJWcGttdW9sczVLSmhrWVFmeVFKT3FNK3ZIOU9ldGc1N3R4?=
 =?utf-8?B?WXZFU3djWit1eU5UbnRhb1E0TjRsdlRzVm5FbWdHZFl0RUJLcHdsc0I2OHZk?=
 =?utf-8?B?aGluVjBPZVVGRTVHT0owYVRDa3A5SlZwaXZkTDdiWFhJYmx4a0xpRnFJbDFX?=
 =?utf-8?B?Zm5oQlJrRm5YeHR0NlhyMGl4SzJScTREcEpvQmxISWZ5UzRQd2FrVVVGaTRC?=
 =?utf-8?B?UVFvajRhVmlRUVVyV2tzTXNLQ0tWTXBIQ2lqOFZ2MWZSZGdMZlI2YW5WcDdZ?=
 =?utf-8?B?SVUyWmszTXB5NkZLdE54MHZYQ0U1bjBwM0txYmlmN1pGcUN4VFB4M3h2UWJT?=
 =?utf-8?B?NVA0ZzJHSitKVjhtYjdsc0kvdUNoUDVkdTBscGN4RlovMm1Sck1ZU2t2d0Fp?=
 =?utf-8?B?L0xOSVFQZzBZaWk2VTQ4QzZNczBJaXc2SjcyaHpXY2RROTFrMTExUHU4ZEFX?=
 =?utf-8?B?YU1BQVYvTEhDNzZFZ1lnQldGWGpSUGFYQ2Rabml0bXpEa1ZocGhyUVNnbU1W?=
 =?utf-8?B?aEF4aXFVaU4wUldBcFZQbG02SVBDd05iZ1lzaElkRlQ4RVJoRUVCdTJRRDhW?=
 =?utf-8?B?L3RHOWJSM0FYQk1RcW94VUp0OWNBRkdHeG5nV05JZFVRWFZVUnNmZU4xc3U4?=
 =?utf-8?B?NnIzNXUxbG9kTTdCb2RsVCtPV0V5TEVpU1hSclF0MGovMDM4SWh6cDQzVU5u?=
 =?utf-8?B?N1JPdDBsdWN2aVgyWXZPYmdYenpGT1A1Sk5hQ09iWDk3aWdlQVlEK0gwYmVG?=
 =?utf-8?B?UEp5Nkt0UTBMdndtSEdxQ3B4ODRWb0xteEp1UTFnVnBkTWZKdEFmdEpJRXFX?=
 =?utf-8?Q?F1nPJryQTdRDPk8ziOawJAJG3?=
X-OriginatorOrg: cornell.edu
X-MS-Exchange-CrossTenant-Network-Message-Id: fc3d47a1-b98e-406d-2e4b-08db2c6fb83b
X-MS-Exchange-CrossTenant-AuthSource: SA0PR04MB7322.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 13:57:34.9122 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mbGLoArkOKgkMzxbWg0Uom6aiPydrimDzACeVWkWFlpkkT1xdx1LdyEVPAQAJACRz/uRZGKkjpdbvLMV8OoM1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR04MB8584
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, NICE_REPLY_A,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Ken Brown via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Ken Brown <kbrown AT cornell DOT edu>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

On 3/24/2023 8:18 AM, Corinna Vinschen via Cygwin wrote:
> On Mar 23 22:14, Corinna Vinschen via Cygwin wrote:
>> On Mar 23 15:48, Ken Brown via Cygwin wrote:
>>> Consider the following test case:
>>>
>>> $ cat locale_test.c
>>> #include <stdio.h>
>>> #include <locale.h>
>>>
>>> int main ()
>>> {
>>>    const char *locale = "en_DE.UTF-8";
>>>    locale_t loc = newlocale (LC_COLLATE_MASK | LC_CTYPE_MASK, locale, 0);
>>>    if (!loc)
>>>      perror ("newlocale");
>>>    else
>>>      printf ("newlocale succeeded on invalid locale %s\n", locale);
>>> }
>>>
>>> $ gcc -o locale_test locale_test.c
>>>
>>> $ ./locale_test.exe
>>> newlocale succeeded on invalid locale en_DE.UTF-8
>>>
>>> On Linux, the newlocale call fails with ENOENT, as is documented on the man
>>> page.
>> Three bugs in fact.
>>
>> First, it's a bug in the Emacs testsuite.  The test simply assumes that
>> there's no en_DE locale on any system, but that's just not true.
>> Windows support the RFC 5646 locale "en-DE", which is called "English
>> (Germany)" in the "Region" settings.
>>
>> You can also check with `locale -av | less' and search for en_DE.
>>
>> For the reminder of this mail, I assume you're talking about Cygwin 3.5.
>> I won't fix this for 3.4 anymore, given how much locale handling has
>> changed for 3.5.
>>
>> The second bug is that Cygwin blindly trusts the Windows function
>> ResolveLocaleName().  That function blatantly converts even vaguely
>> similar locales into something it supports.  E.g., it converts "en-XY"
>> to "en-US".  I. .e., even if you use "en_XY.utf8" as locale, the above
>> testcase will wrongly succeed.  So I have to rethink how I resolve POSIX
>> locales to Windows locales.
>>
>> And the third bug is that Cygwin fails to set errno if it doesn't
>> support a locale, but that's a minor inconvenience in comparison.
>>
>> Thanks for the report, I totally missed the above problem with
>> ResolveLocaleName.
> 
> I pushed a couple of patches which hopefully clean up the code. 
> 
> I had to create a replacement function for ResolveLocaleName which
> doesn't return totally screwy and unexpected results, and special case
> two more locales in /proc/locales output so the output makes sense.
> 
> Oh, and I added error handling to the code so newlocale is now able to
> set errno to ENOENT if the locale is not supported.
> 
> If you want to test this, the changes are in test release
> 3.5.0-0.260.gb5b67a65f87c, which is just building.

That was fast!  I can confirm that newlocale now fails with ENOENT on 
the invalid locale en_XY.utf8.

Thanks.

Ken

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple