X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10CAF3858C52
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1668092145;
	bh=rfxymFeBnZwWKafueLS2h9fpCQO6qLxaXsppDALu4Bc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id:
	 List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
	 Reply-To:From;
	b=L02cMWpZqfACTi7OJUUf4SNq71yJILYDMUVGeQgZwWHueY7feKt/Rq2qP2RGqEC5M
	 JmLBGnTwhd7begd9a88SxV9y0scTeRW8PEPFxmQdnK42B17XO/dV8DSrxlFg+JVZaY
	 CXnF+Pr4wbso6MfzVT8UB+nChpinzwTFAzCa+r88=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 218903858D38
Authentication-Results: sourceware.org;
 dmarc=fail (p=none dis=none) header.from=cygwin.com
Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com
Date: Thu, 10 Nov 2022 15:55:10 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: "Carlo B." <carlo DOT bramini AT gmail DOT com>
Cc: The Cygwin Mailing List <cygwin AT cygwin DOT com>
Subject: Re: PATCH: TIOCMBIS/TIOCMBIC not working when using usbser.sys
Message-ID: <Y20Qzrfo+JZYlQhq@calimero.vinschen.de>
Mail-Followup-To: "Carlo B." <carlo DOT bramini AT gmail DOT com>,
 The Cygwin Mailing List <cygwin AT cygwin DOT com>
References: <CADt9575fzjVLgAwB0EScK=0CZr_dBCCs_bE3VrVuDFUH-MFRTg AT mail DOT gmail DOT com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <CADt9575fzjVLgAwB0EScK=0CZr_dBCCs_bE3VrVuDFUH-MFRTg@mail.gmail.com>
X-Provags-ID: V03:K1:n+wnmflOXpgcbbbFB+pRZvx1OBUATdmUwrlioBXxztS3CUi8lbR
 J690mOYy/VsCQp6Fkwb8TYHE102bKIZ6Eyxe2alZXTaM3hkTZi3KmTIjL/tlbX+lCGbSh8v
 Bn8dTAD9VdnvLRkvsvEhWSWL4i004+6j/2bTFj5ocPBBAfXMNoFOUlmZ8f6ZAm1zKa2pSue
 n2UctA2TCtwgSAokSBLDA==
X-UI-Out-Filterresults: notjunk:1;V03:K0:98qo3NF2Mb0=:fPXPQOddKoTaqVoDt7UpIb
 xIxwQoe7jJNaCJeSwRcSBw+WymZSICoeygtOkVFuSALVh9JqPTmqwprGKPKvPrTOaDGmwypm1
 R6gxFJNqP1mss+9VLBihUS/Uy+td1sHhs8ERS08n/AIYdZXD2q/YL6PUwFDxuPqZ7eRhpez7u
 fG4anBhQrvnrKM/nLVWTpFLT3vghLIDm9bmzIlhuu96e9S4v3Rhrk1+JjPHZWBwa1vz2AnPf0
 RIM4OdOFXAVACv+97oRYIvI9S/ELB68b/xxCGaR2yEHZ8tw3Jbg8VcyZdKsKA2infJt4owL/b
 O8YRqBMlR2yWehXJzlQW0RmH1vGnPyeBO0Eh8f9QZO7ZoinDsvbhRaal/ngkGYuA8mi/R5pbW
 Dm8svOyjVYbKjEV+BDZwU2/1z2mKN/R3c1I9phT9rsB9KdwOuLX61OhEMk8fRO+GHCMgHoyUu
 B1ZB7O0X4lFHp5qQ1XP8qz7XQdckhPsoOO5LriadA193dcj3SnuDCLrpaKRy5rTYLK+g2UmzZ
 /JwX03ZzJglot95At89p42C6Lm6N8wFYFAsvmAHDLtcKTEa587gm+JDkZ7kEt8gvKY9UErbMi
 7sNFnezqBpcBmi99IduRZIQBBwhspLp3sDB3s/k3aM8mxvDu4pGLb4fWfgnZ8IfYIdXBA3C2Z
 qtvBEJ5hRHLDAyKpPXLoDW8SCNHPqCS7YuPNxPT5di1nuqS/1s4hnvVpLO54bCedwqzUNAltU
 ludFVOAl4uUVXXJF1tdYg4aASumwU1bHHaAxc6QVhQewiGYBl9jSMxi3WVoAbDbXf+73JLwh+
 U86MwDNl7Ok9jLRPV08HyMVUsvSaKzxHMXOdm/0yieoLni+DrjbMx1diP/lPWf+GvStsBEsC7
 Stjbz+8v2wd1LVJsHuweZ19DvnbuM1X67gwa93JnSIF4Hx+RjiGkhUBxCgDF0txbc2gIKq6DS
 P2NUUfu0TCP8JY6qeIjTWQHfDsSZVog1PWlDev30beHcwLona1+JQKU3rVcJoPj1WTkaxeO2h
 8wBAgC9MZu3ltOQkrO0MxgjRC43v8NnMIO7VR2T2s9aMXPLNhsqi9P0MctPXdqnfmxfw09COh
 wmMRYaqfx5Pd30RpdYj24LULdngtzDVpo73UB8vNWCZryKThZVYA9ig1oDcPkl+5sf53JE7gC
 /JkJ3Jo9lZ3eTOp+ga+ZdeJA6pKQrk66sYq4Vrur+XGxGiYsPD6P8tOwbdgxeJtdhWFwOgcsd
 IZiecA94zT0MX4thF9JVNL10DRDlpD4108h/B/XlSDZ+uvqL3UbLAfwuCTzYC7qvAbiXARLGs
 J3W5WGXn/4tzDl+U1ONHWUqeRJjuzw==
X-Spam-Status: No, score=-95.8 required=5.0 tests=BAYES_00,
 GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE,
 RCVD_IN_MSPIKE_H2, SPF_FAIL, SPF_HELO_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Reply-To: cygwin AT cygwin DOT com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

Hi Carlo,

On Nov 10 10:07, Carlo B. wrote:
> Hello,
> into winsup/cygwin/fhandler/serial.cc, the function
> fhandler_serial::switch_modem_lines() is called when TIOCMBIS/TIOCMBIC
> are used into an ioctl() call.
> This function uses EscapeCommFunction() for setting and resetting RTS
> and DTR signals of a serial port.
> Unfortunately, this function does not work on USB CDC devices.
> This is not a true bug of a CYGWIN but an issue of the usbser.sys
> driver from Microsoft, from Windows 2000 to the latest Windows 11.
> Both 32bit and 64bit versions of the operating system are affected.
> Actually, I tested EscapeCommFunction() also when using a real UART,
> based on the traditional 16550 driver and it works fine.
> Using thirdy party CDC drivers, like the one provided by FTDI for
> their USB bridge chips, probably also works.
> However, it is also possible to drive the RTS/DTR signals by writing
> their state with SetCommState(), which proved to be working fine all
> types of connection.
> 
> Here, I attached a patch that I made for fixing this issue.

Thanks for your patch, but would you be so kind to create a complete git
patch, created by committing your patch locally on top of git master,
with a fine commit message outlining the technical details as described
above?  Then create a patch file using `git format-patch -1' and send it
here or to the cygwin-patches mailing list, please?

> I was wondering if this fix could be imported into the core of CYGWIN
> and if it could be possible to include it also into the v3.3.x branch,
> since I have seen that 32bit support has been removed from Master
> branch recently.

There will be no more 32 bit release. 3.3.6 is the last one.


Thanks,
Corinna

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple