X-Recipient: archive-cygwin AT delorie DOT com
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 85798385840E
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=maxrnd.com
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=maxrnd.com
Subject: Re: Python regression related to unix sockets
From: Mark Geisert <mark AT maxrnd DOT com>
To: Cygwin Mailing List <cygwin AT cygwin DOT com>
References: <AM0P194MB03245439474B7D5A1DC8A872EA809 AT AM0P194MB0324 DOT EURP194 DOT PROD DOT OUTLOOK DOT COM>
 <b168f64c-9065-e10b-e3eb-fa1f19f9ec9b AT maxrnd DOT com>
 <VI1P194MB03021C28AABC67D3CD441E7CEA399 AT VI1P194MB0302 DOT EURP194 DOT PROD DOT OUTLOOK DOT COM>
 <b9ccb2c9-e909-72c4-4eca-7fa992afcd4f AT maxrnd DOT com>
Message-ID: <b7450b9a-206c-2894-cac6-b7d8b510fadf@maxrnd.com>
Date: Mon, 7 Nov 2022 22:51:01 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Firefox/52.0 SeaMonkey/2.49.4
MIME-Version: 1.0
In-Reply-To: <b9ccb2c9-e909-72c4-4eca-7fa992afcd4f@maxrnd.com>
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by delorie.com id 2A86qRbQ002220

Following up to myself...
Mark Geisert wrote:
> Hi Fabian,
> 
> Fabian Henze wrote:
>> Hi all,
>>
>> This is a follow-up on a mail thread from February 2021.
>>
>> Mark Geisert via Cygwin wrote:
>>> Fabian Henze via Cygwin wrote:
>>>> Hi Cygwin users,
>>>> I noticed a regression in the recent Python packages: Between version
>>>> 3.6.10-1 and 3.6.12-2, accessing the SSH agent via the paramiko python
>>>> package broke. When a ssh agent is used, paramiko tries to connect to
>>>> it via the unix socket and just freezes. Python 3.8 is also affected,
>>>> but I don't know which was the last working one.
>>>> I was able to pinpoint that error to 3.6.12-socketmodule.patch [1].
>>>> Reverting/removing the patch fixes the ssh agent access.
[...]
>>>> Can you please check if you are able to reproduce that? I uploaded a
>>>> script [3] for that.
>>>>
>>>> Best regards,
>>>> Fabian Henze
>>>
>>> Thanks for the report and sorry you've run into this.  The patch is a 
>>> workaround that's evidently too draconian.  I will debug the situation using 
>>> your testcase.
>>> Thank you very much for the testcase.
>>
>> Did you (or anyone else) make any progress on this that you can share?
>> Unfortunately the issue still persists in all current python versions.
>> If no one has time to debug and fix this, would it be an option to remove the
>> 3.6.12-socketmodule.patch that is causing the regression since it only fixes a
>> theoretical problem in unit tests, but causes real-world issues? Maybe the
>> upcoming (?) Python 3.10 or 3.11 bump would be a good candidate to do so?
[...]
> Let me find my notes for this issue and see if I can improve on the patch or find 
> some other solution for now-current versions of Python and/or Cygwin DLL.

Right. I determined there was nothing further I could do. The conclusion I stated 
in the thread you quoted from was this (and it still applies):
--------8<--------
It's a limitation of the patch.  It was meant to allow Python programs on the same
computer to communicate via AF_UNIX sockets, by working around less than perfect
support in the Cygwin DLL.  But you've got a Python program trying to communicate
with a non-Python program, and that fails because the patch is only applied on the
Python end of the connection.

If you can continue to run without the problematic patch, that's your best option.
-------->8--------

BTW, what you called "a theoretical problem in unit tests" was of great concern to 
the Cygwin Python maintainer at the time. We test our Python builds before 
releasing them.

The best "solution" I can think of ATM, and it's not great, is to have the 
behavior you want be the default and an environment variable such as 
PYTHON_NET_DISABLE_CREDENTIALS to choose the other behavior. I will consult the 
Cygwin Python maintainer to see if this is acceptable.

..mark


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple