X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 538523839808
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1651160063;
	bh=xfhwmhSIGHhIdR9ZmA4H6MgZ20RwvVPXyJHNuraSAz4=;
	h=Date:From:To:Subject:References:In-Reply-To:List-Id:
	 List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
	 Reply-To:From;
	b=IE80b1maNq5is9+DQGD5V8JgiBIfGTw6xQ7a+KTaJcVIO00SoA9Gm2KeS8gEmOIS6
	 HNupTz9fMcan0S5XbKqK439QdcXn/NQsyYJ5PP6oGQvMiRLIgDzre6dd99xcnRGeiG
	 /TZKAeZsV6ojwuMauH5fyZ3ngdteHW5w4bmaL7LY=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 61C74383801A
Authentication-Results: sourceware.org;
 dmarc=fail (p=none dis=none) header.from=cygwin.com
Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com
Date: Thu, 28 Apr 2022 17:32:22 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: GNU make losing jobserver tokens
Message-ID: <YmqzhlrjgMkzNz6h@calimero.vinschen.de>
Mail-Followup-To: cygwin AT cygwin DOT com
References: <9b9da583-124d-9d5f-4c10-6622602ca8dc AT oracle DOT com>
 <20220401174551 DOT 820cbc148852554108397e03 AT nifty DOT ne DOT jp>
 <20220427231340 DOT 0bdab2d6d903dd4fb44bd12f AT nifty DOT ne DOT jp>
 <f83bea36-a759-5620-89d8-b7b1b0c601ee AT cornell DOT edu>
 <YmqgFLRX2ZH8AcpD AT calimero DOT vinschen DOT de>
 <20220429000152 DOT 1fe838469e543a69586e194d AT nifty DOT ne DOT jp>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20220429000152.1fe838469e543a69586e194d@nifty.ne.jp>
X-Provags-ID: V03:K1:fLI70N+XPy4eqU/v4iLoIO7ZdoEy4CAtBp4Xo33CWbixvKc/G83
 CitZCRlwjEy4r+/u02ErqMAyDoUrv9q82U6ac8iTXTtjZ7uA6BreLmw4W8UMK/t4qi3P49Q
 tDHl9w28AdoWLu63RsfUkXCBULBGGQbGEob8R5goyz1PPsGgz6cAPDSXg9dYoQIZPC1RYgN
 7aRB98Pe8zniKg/RyvgbA==
X-UI-Out-Filterresults: notjunk:1;V03:K0:rBXgCQhqwkY=:Uyw8YRqmUxvjCFG2s7Vw+f
 AuUaHEFThJWhe3sXhtfgjtVcopnMtmVGHCS/B5D5e8CDgQSqS4I7taoofquDrNnifkD2xMQDe
 ujQcpCevV15Q+nbBIrvzKOp5qpaqoJ1aHS+cv5AJlTtkaBJI6tfi49PyD68gADbSMalTQmidk
 qWsAt93hyB4wBMM6zPMgnm9JwLqJaSadzlY2/s5VhH7kGAarbSrieAy/GeR353MeunoanSGGO
 SyXXAx3DCQcDHyxylPTsfUYVrRrD8IOr8YlY58v0DXlYpJMLeDQuRBS+q1jieVGQby9Kxcx1X
 nhOCNLWXuvoUd4gCujlakTlCywtFPxb6D5Qa10Mj9gVKhZPd8IbbIG9i5SVUEU2tsZHOOEZXL
 5Tx1mvUILtOdSIfdEp14PP/B7vh0PRtgzESuKnOR/Pl5Uz/uc6EpOdCEU33Smhh9WUfteuC6J
 WTxQ4NoFi8pu6331Oxk0XqYcuTgIDF5pkXF03gkk3TofGD8MSK+bIJld7yfrMJplwpGH99Tcn
 42EpgLlTWbRmR9Ulj+PoH9pvHRcIonsYUvjkVF7aFEQYDcl7ufJ1SMkIm8L6Fw3dxOa4u9XCq
 K9VuWz4xEqFzPwnCFDJ3dozDuzgTcvZRDikis7CkYamHhHy321U3RzvCO9cWLefTH1cNLNi0U
 SPyGle1xApHURK+9isPP06ljq1oY6GHeepEVPLuwVcqDdzajnCGnjy5P56EX51Fbhwf4hf7yh
 IzpPpBtkW2W9tQVC
X-Spam-Status: No, score=-101.0 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE,
 SPF_FAIL, SPF_HELO_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Reply-To: cygwin AT cygwin DOT com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

On Apr 29 00:01, Takashi Yano wrote:
> On Thu, 28 Apr 2022 16:09:24 +0200
> Corinna Vinschen wrote:
> > On Apr 28 09:42, Ken Brown wrote:
> > > On 4/27/2022 10:13 AM, Takashi Yano wrote:
> > > > On Fri, 1 Apr 2022 17:45:51 +0900
> > > > Takashi Yano wrote:
> > > > > [...]
> > > > > diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc
> > > > > index 62df96652..3824af199 100644
> > > > > --- a/winsup/cygwin/sigproc.cc
> > > > > +++ b/winsup/cygwin/sigproc.cc
> > > > > @@ -1325,6 +1325,10 @@ wait_sig (VOID *)
> > > > >     _sig_tls = &_my_tls;
> > > > >     bool sig_held = false;
> > > > > +  /* Wait for _main_tls initialization. */
> > > > > +  while (!cygwin_finished_initializing)
> > > > > +    Sleep (10);
> > > > > +
> > > > >     sigproc_printf ("entering ReadFile loop, my_readsig %p, my_sendsig %p",
> > > > >   		  my_readsig, my_sendsig);
> > > > > 
> > > > > I guess _main_tls may not be initialized correctly until
> > > > > cygwin_finished_initializing is set.
> > > > > 
> > > > > Any comments would be appreciated.
> > > 
> > > This seems reasonable to me.
> 
> Thanks Ken and Corinna.
> 
> > Missed that, sorry. I agree this seems reasonable, but wouldn't it be
> > cleaner if we *start* wait_sig only after cygwin_finished_initializing
> > is set to true?
> 
> I also thought so, however, there is a comment in dcrt0.cc
> as follows. So, there seems to be some reason to start
> wait_sig before cygwin_finished_initialization.
> 
>   /* Initialize signal processing here, early, in the hopes that the creation
>      of a thread early in the process will cause more predictability in memory
>      layout for the main thread. */
>   if (!dynamically_loaded)
>     sigproc_init ();

This is a 32-bit only problem. The 64 bit address space layout is as
predictable as can be.  Maybe the above fix should go into 3.3 and for
3.4 we try differently?


Corinna

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple