X-Recipient: archive-cygwin AT delorie DOT com
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C206D385783B
Authentication-Results: sourceware.org;
 dmarc=pass (p=none dis=none) header.from=yandex.ru
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yandex.ru
X-Yandex-Fwd: 2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;
 t=1646728501; bh=V7vCL1L+yBWbWlb8fxk04dI9C/ozUmpLJ4LO2x53GOk=;
 h=In-Reply-To:Subject:To:From:Message-ID:References:Date:Reply-To;
 b=Bon4cukwhxISHUyywYbxOZWAPD4nqG+r/IlcrP0PwPCf3yk7thI8RhHYJaLQYT0QC
 XD8urgIEJkSvEaNylz1DIxdX1Hvj7y55fdxQU6/qeO3CJw29421apNvnXmMACuxsUN
 m/jzKNZJAgW9i0NNyBMXVx2jhfJxzBi30Cm4C/UU=
Authentication-Results: iva5-f90c153e7fcb.qloud-c.yandex.net;
 dkim=pass header.i=@yandex.ru
Date: Tue, 8 Mar 2022 11:28:33 +0300
From: Andrey Repin <anrdaemon AT yandex DOT ru>
X-Mailer: The Bat! (v9.3.4) Professional
Message-ID: <1277951355.20220308112833@yandex.ru>
To: Adam Dinwoodie <cygwin AT cygwin DOT com>, cygwin AT cygwin DOT com
Subject: Re: minor error in skel/.bashrc
In-Reply-To: <20220305132522.uq4yfrvmnrn4szvf@lucy.dinwoodie.org>
References: <CABWfEdmHy4NtqX5MmAuWsRC0+NqgeF8W6Et9dJNc-TuWjHmcZA AT mail DOT gmail DOT com> 
 <20220305132522 DOT uq4yfrvmnrn4szvf AT lucy DOT dinwoodie DOT org>
MIME-Version: 1.0
X-Spam-Status: No, score=1.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_THEBAT,
 NICE_REPLY_A, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP, T_SCC_BODY_TEXT_LINE,
 XM_LIGHT_HEAVY autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Reply-To: cygwin AT cygwin DOT com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

Greetings, Adam Dinwoodie!

> On Sat, Mar 05, 2022 at 09:26:06AM +0300, lvm wrote:
>>  The identical /etc/skel/.bashrc and /etc/defaults/etc/skel/.bashrc contain
>> the same line
>> 
>> # export HISTCONTROL=$HISTCONTROL${HISTCONTROL+,}ignoredups

Not a nitpick or anything, but I've found a slightly clearer technique on the internet:

export HISTCONTROL=${HISTCONTROL:+$HISTCONTROL:}ignoredups

>> 
>> But HISTCONTROL values should be colon separated, not comma separated. This
>> line is commented out, but if someone like me tries to use it without much
>> thinking...

> Confirmed.

> Achim, I've attached a patch that should fix this, based on the tip of
> https://sourceware.org/git/cygwin-apps/base-files.git


-- 
With best regards,
Andrey Repin
Tuesday, March 8, 2022 11:14:29

Sorry for my terrible english...


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple