X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C71E33858428
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1638889148;
	bh=xE9qjT5kknK5u9pJBlWpJUe3r+dp7RGhvk95QfG+KOo=;
	h=Date:From:To:Subject:References:In-Reply-To:List-Id:
	 List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
	 Reply-To:From;
	b=fVG8v3Y4yrbxt1OXBD8E3ioTHG0njKZCoG4sdEKUVTQOj41PTkR+8ttzB+a2s7WvC
	 NxbmmGEk1zllYECoQh2umuXWVgHgy+oKcNp4ZkWlHmvSApiMzreqiWRSBtZhUchdmz
	 DOQYlaNr36hzuG49zZ/65YNppndTlYLSdKbW0R00=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 27C393858D3C
Authentication-Results: sourceware.org;
 dmarc=fail (p=none dis=none) header.from=cygwin.com
Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com
Date: Tue, 7 Dec 2021 15:57:56 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: vboxsharedfs - Too many levels of symbolic links
Message-ID: <Ya92dHe+1fq5CvXA@calimero.vinschen.de>
Mail-Followup-To: cygwin AT cygwin DOT com
References: <d6470ffe-8e49-3eb7-4d21-3212e0ad4f31 AT oskog97 DOT com>
 <20211205115411 DOT 1619911cb3e2d23f671912ce AT nifty DOT ne DOT jp>
 <Ya3i/sfWB2avaJ9F AT calimero DOT vinschen DOT de>
 <20211206195527 DOT 9b9c09b549fa8fcc2512949e AT nifty DOT ne DOT jp>
 <20211207094612 DOT 313345b38eac94bae85448b4 AT nifty DOT ne DOT jp>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20211207094612.313345b38eac94bae85448b4@nifty.ne.jp>
X-Provags-ID: V03:K1:/TGdKJmiOCHeaAG0ZGig9+9TTVdYj/eArGRYtlaLT/RieA/1YQX
 lFvb93aikKJmT2P/0kNMC/z/SUmi96VAgxvF+2wjz8FTMfgxn++tDusRudpT6MZ7AwUCIWm
 QqDSLdpwIE+q8MkeTNZ7qk1XrnToqCJCu4Ij6ep7Fhsi+ZWUcEDV/uBluAsyPX4gYLTVXP+
 N+TB/LjPAmfHQp6WRqcOg==
X-UI-Out-Filterresults: notjunk:1;V03:K0:WB94ZJEdGUI=:2yDBe2iT0XtkrFcP5IUabC
 l3zH9dZkApINDgMy39YQMnVAXH18zjq35KqhPsbSPIo0cweIcAeECyR/x7FoEuty2vnPLF6en
 bUSmtenQGfADL2riXZUSYWIOKogJXZ5zzuROn4fQcwh7sj+lqvLMJQu3TEI8MZPvQNWPOuivp
 e8t7s4cHwTF73aReU0mcetEjDJdAH8t2828yJfuShhKA/wg87gr4zLvrWUZTZa1aPmYzTjaG5
 HAYE2nK7eE/CXa8kEYPG79SxTct3lXQMzyg3QhpL4UXAM3Hu7OAcNMQ452oOoiOHvabnjxKL5
 JaJ/yIv/PfchWEbkNTJa06FTdx+QqkWibEJcyQnCzbxz2nvfx7AU2nIClhswWjESljxTT7w/S
 2Y4wNvoHR3b/MZqiAnSN0Nf5925gA+92n0jjSPv7sYRzmOBWNu1f1h8v/Ps1LtRjtk4Bz8gcT
 mlyGJvDeBjWn2AbJrMnbvaM5gauBdOabL5i6G3X8Zscn6tM2FIPJz0cSm3XSLaQlHf4Tubr2a
 Iq8sth3hj+BlmqZw0goOTyzvfmWKnXkjQemkPo5liRt0zuwKI1DGL9oifwW9cPZeeFXll+SDF
 jW9fHXGXZmx1LaYYP2CrP4yleaQM0ChuBve1Dxbj+e27rVPGXvlXOr7aLVdQGnXL1DHMzrhZK
 IDKbW5nMsaB/KIOXk115TORmvnACY4vpKSpbLg31yw35VruG/eweDFNz/UVrlIPpcNnWsLzlI
 sDEQUXQfjI2oIkzH
X-Spam-Status: No, score=-99.4 required=5.0 tests=BAYES_00,
 GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H2,
 SPF_HELO_NONE, SPF_NEUTRAL,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Reply-To: cygwin AT cygwin DOT com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

On Dec  7 09:46, Takashi Yano wrote:
> On Mon, 6 Dec 2021 19:55:27 +0900
> Takashi Yano wrote:
> > First, I think the same. However, with this patch, it sometimes causes
> > hang for a few seconds around the code:
> [...]
> > with path_copy of "//VBoxSrv". I am not sure why.

That's expected and nothing really to worry about.  It's the network
environment access in fhandler_netdrive.

<sidenote>
I have this on the radar already, because the WNet stuff in there has
been broken by Microsoft with certain updates to Windows 10.  A SMB
security fix has deliberately left behind the WNet calls to enumerate
the network environment, because they rely on functionality of older SMB
versions.
</sidenote>

> > 
> > In addition,
> > https://cygwin.com/pipermail/cygwin/2021-December/250103.html
> > still needs fix.
> 
> Moreover, this has a problem with "ls -al /cygdrive/z".
> The information for ".." is not retrieved correctly.
> 
> drwxr-xr-x 1 yano None       0 Dec  6 13:54 .
> d????????? ? ?    ?          ?            ? ..
> -rw-r--r-- 1 yano None      29 Dec  4 07:45 Makefile
> -rw-r--r-- 1 yano None      17 Dec  6 13:18 a
> drwxr-xr-x 1 yano None       0 Dec  6 08:59 aaa
> lrwxrwxrwx 1 yano None       1 Dec  6 13:54 b -> a
> -rwxr-xr-x 1 yano None 3278626 Dec  7 09:07 cygwin0.dll
> -rwxr-xr-x 1 yano None 3549860 Dec  6 08:51 cygwin0.dll.64
> -rw-r--r-- 1 yano None       0 Dec  3 22:16 testfile.txt
> 
> I think '/cygdrive/z/..' should be '/cygdrive', however,
> in current cygwin, it is interpreted into '//VBoxSrv'.
> 
> Is this as you intended?
> 
> With my patch which stops to treat UNC path as symlink,
> '/cygdrive/z/..' returns '/cygdrive'.

Yeah, but...

...what bugs me is that *every* UNC path is treated this way with
that patch.  If you have a path like /cygdrive/x/a/b/c, with x:
being a virtual drive pointing to //server/share, and with "b"
being a symlink to "syml", what you get back is either

  //server/share/a/syml/c

without, or

  /cygdrive/x/a/b/c

with your patch.  What we would like to get back is

  /cygdrive/x/a/syml/c

So the real problem is not that we have an UNC path, but the fact that
the drive letter expression is (correctly, but unwanted) converted to
the matching UNC path by GetFinalPathNameByHandle.

Bottom line is, your patch is ok, please apply.  It would be nice,
though, if we could just avoid the drive: -> UNC path conversion and
keep the rest.


Thanks,
Corinna

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple