X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DED5E385802D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1637743803;
	bh=hVbo02QJvdRmFPeaj8ta+Yck3npHbjXKs9AOeDgWhSo=;
	h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:
	 From;
	b=XsbuHDRV/JYl+EK0wlD4V0EHRC8NgzQzWydPdUWWp0crAqftFte8SaB5YJu399gFY
	 MxJieDBRcFitEQpZdJS3kkKZwM0UI7zw2WpDWyr9ogV1twwf8296xuHL5AsbtlmyYo
	 Rt2WmUJjdoj7GJe5Xu/n8KHp6URD0TGLv0/j/FYc=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D73163858423
Date: Wed, 24 Nov 2021 09:48:26 +0100
To: cygwin AT cygwin DOT com
Subject: Re: possible snprintf() regression in 3.3.2
Message-ID: <YZ38WisiGeD2qyPy@calimero.vinschen.de>
Mail-Followup-To: cygwin AT cygwin DOT com
References: <fa647f83-c5ed-6dea-fcba-c8b799abe12f AT gmail DOT com>
 <YZZi3rI5msk6ksAV AT calimero DOT vinschen DOT de>
 <7545bb24-43de-cd7d-0764-55c85f1af957 AT gmx DOT com>
 <20211121001613 DOT GH10332 AT venus DOT tony DOT develop-help DOT com>
 <YZtyJDXdrMzVR2lJ AT calimero DOT vinschen DOT de>
 <YZuVRjYoG40cEGDV AT calimero DOT vinschen DOT de>
 <20211122232302 DOT GI10332 AT venus DOT tony DOT develop-help DOT com>
 <20211123173409 DOT 0db4d5ccd94501ce1b8f69ea AT nifty DOT ne DOT jp>
 <YZy45cStTTgLp0gO AT calimero DOT vinschen DOT de>
 <20211124124055 DOT a90e254858b66d42aca6ecef AT nifty DOT ne DOT jp>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20211124124055.a90e254858b66d42aca6ecef@nifty.ne.jp>
X-Provags-ID: V03:K1:AnOrk1LrvqZ+eGPNBe/sy0wFLcMisOCBvHyBI9V0Sexp6CXQWxP
 t3ob2HTbhqWsq9tjglSc1pwMGFD4GWUVeT8G3K/UhyTukrotODfZyZ49kB6hrGHV57sK7oL
 NKDvw87dp7TGcb/802zTS6tV+ozG0+dAoFq2CnrATXGfw1VQ5lERuIHDnzFBrxwBnc0Aj2m
 F+ATFHUOMLXaoi55w1xKA==
X-UI-Out-Filterresults: notjunk:1;V03:K0:aAhCaVu5RqM=:U4weaacwcmkcH+zqMoIpAX
 ExNuWHcCnC7/yTqSKmEKwsPJQ33Jv+5c4WKOZo5CGYA9RKaElux5xBXmzvIAQPdBmvprw/Njx
 hB01wo87FpGesPso9P93AIvNppZ7tW0vGVMpLqmCMsb/0U5iLY8oqRlMZR2LXndv/PoYqzE4Q
 xQzIM9qnyN2BEzMgNOTG4Jkb00as42jpb6b9twTPX5TKz6jfCR9Ii00+UISAehsMfez/UbE8J
 MXVq2RumuCI5JqUvK8Y6azHhAeBTmE592VHswN9Tr6IrgovRmvv9W9OofFsI8HAoO1daJRs6j
 arGsDErh3cEVjaaZN4YbaFRx4Zek+P90/i89Tq+3cNIBacVmiSMwQ47Om/ZX6hlevS72Zc26m
 VPGOGd1pvl/rj08VpwSpTAaf6hZcVtzy8f4M1MV4QBx5WZR8MZtlbHNx855CSrFPTrkDax4nq
 6ww8QN2CPsVSPrhz1zuisrjcjtaREyGBOLpwxR2oRYLNFXRP+Hw7Z3dy9xWTdqzIYJvphDKwq
 YiNqj5kYK3qoMhhT3riFpJA/Ebnak/JxDfrGnlGl1kKEBFgD3Ib2I30uNxHMWqBoMlyZaP923
 qEL930xO9m25Td3KaEkiAU/Yh3r/klU2byp3cAQhh4fH6H3sGrENYRWs5k/W43YMexHFfebBk
 C+lrh+O+3QN5TywFtFiwhv+jjHejcpx+sjpBY1+9i6meOOWfmsN9ePJPE9t088xOY0t3PdRTl
 QWD7a247Cw6K7dZ8
X-Spam-Status: No, score=-99.0 required=5.0 tests=BAYES_00,
 GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LOTSOFHASH,
 KAM_NUMSUBJECT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Corinna Vinschen via Cygwin <cygwin AT cygwin DOT com>
Reply-To: cygwin AT cygwin DOT com
Cc: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

On Nov 24 12:40, Takashi Yano via Cygwin wrote:
> On Tue, 23 Nov 2021 10:48:21 +0100
> Corinna Vinschen wrote:
> > On Nov 23 17:34, Takashi Yano via Cygwin wrote:
> > > However, in reality, for example in the case:
> > > snprintf(buf, sizeof(buf), "%.3f", 1234567890123456.789);
> > > 'ndigits' is only 3 even though total digits will be 20.
> > > 
> > > So, Tony thinks current code does not correct.
> > > 
> > > However, I think something is wrong with interpretation
> > > of 'ndigits' in dltoa.c.
> > > 
> > > printf("%.3f\n", sqrt(2)*1e70);
> > > printf("%.50f\n", sqrt(2)*1e70);
> > > 
> > > outputs
> > > 
> > > 14142135623730951759073108307330633613786387000000000000000000000000000.000
> > > 14142135623730951759073108307330633613786386978891021459448717416650727.13402790000888758223149296720949629080194006476078
> > > 
> > > Is this as intended?
> > 
> > On Linux I see
> > 
> > 14142135623730951759073108307330633613786387161811679011529922516615168.000
> > 14142135623730951759073108307330633613786387161811679011529922516615168.00000000000000000000000000000000000000000000000000
> > 
> > The newlib output for .3f probably suffers from the fact that ldtoa
> > chooses the small buffer, which restricts the number of digits to 43 or
> > 44.  But keep in mind that ldtoa *always* restricted the output to 42,
> > so you never got a more precise output anyway.  Every digit beyond digit
> > 42 is only printed due to the bigger buffer sizes.
> > 
> > So, what newlib and, in extension, Cygwin really needs at this point are
> > patches to the existing ldtoa or a change to gdtoa or equivalent.
> > 
> > https://cygwin.com/acronyms/#SHTDI
> > https://cygwin.com/acronyms/#PTC
> 
> The attached patch is the one which I think correct so far.
> 
> With this patch:
> 
> 14142135623730951759073108307330633613786386978891021459448717416650727.134
> 14142135623730951759073108307330633613786386978891021459448717416650727.13402790000888758223149296720949629080194006476078
> 
> Isn't this better than current behaviour?

LGTM, thanks!  Can you send this as patch to the newlib ML, please?


Thanks,
Corinna

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple