X-Recipient: archive-cygwin AT delorie DOT com DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D4E883985815 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com; s=default; t=1624579805; bh=N9ZKdCd+WS93JDH5E8GyNraENARQNOHnvKqyGuSEKBw=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=oUoEjraVGOAsc9MXmxBv1U0nax0O77kKThyrw8b6fTn4fczpRw8COosqOnoLllfCN O/szGtJyTdFEKXwsodriiBSOD1dWLYjUgHnFRGpk4ECH1qlpjLS2ozKEC1mrGES+1V DF9+6BSE4HS3R8nySaQx7HZVFwr0UyBlzobmh5ho= X-Original-To: cygwin AT cygwin DOT com Delivered-To: cygwin AT cygwin DOT com DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D7F63857820 Date: Fri, 25 Jun 2021 00:08:46 +0000 To: The Cygwin Mailing List Subject: Re: xwin-xdg-menu high cpu usage with rxvt-unicode Message-ID: <5ODXHOy6V1_1syKCgn8erXeXr5goM3hltEnxw1q3hBS4yD_jPTR1N0qrVlE1bGQ39G0zOeDskizMCPmNDfYUrnqerfTqYXo6kpOBbQlefRU=@protonmail.com> In-Reply-To: <608c8616-52a3-bbfb-f8f0-983a6c4453b1@dronecode.org.uk> References: <20210623120858 DOT 83e471aa7ddbc20cd41efb2c AT nifty DOT ne DOT jp> <608c8616-52a3-bbfb-f8f0-983a6c4453b1 AT dronecode DOT org DOT uk> MIME-Version: 1.0 X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_ASCII_DIVIDERS, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin AT cygwin DOT com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Viet-Duc Le via Cygwin Reply-To: Viet-Duc Le Cc: Jon Turney Content-Type: text/plain; charset="utf-8" Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com Sender: "Cygwin" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by delorie.com id 15P0A8aO003752 I've tested the patched version. At the moment, xwin-xdg-menu no longer incurs high resources with multiple instances of rxvt-unicode. @Takashi: Thanks for investigating the issues and providing a patch. @Jon: Thanks for providing the test package. ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Thursday, June 24th, 2021 at 1:41 AM, Jon Turney wrote: > On 23/06/2021 04:08, Takashi Yano wrote: > > > On Mon, 21 Jun 2021 05:49:28 +0000 > > > > Viet-Duc Le wrote: > > > > > Hi, > > > > > > I've encountered a peculiar issue with rxvt-unicode launched from xwin-xdg-menu (20170321-1) > > > > > > The image below corresponds to two rxvt-unicode instances, each occupies 30% of system resouce. > > > > > > https://imgur.com/a/FTFwIrZ > > > > > > I'm using the the latest version of cygwin. 'cygcheck.out' is attached per guideline. > > > > > > Steps to reproduce: > > > > > > - Start XWin Server from Start menu > > > - X applications menu -> System Tools -> rxvt-unicode > > > - Kill rxvt-unicode to free the resource again > > > > > > Other observations: > > > > > > - XTerm does not incur high resources. > > > - Manually launching rxvt-unicode from XTerm does not incur high resources. > > > > > > I think this is not an issue with rxvt but with xwin-xdg-menu. > > > > > > On laptop, it is very noticeable when the fan kicks in. > > > > > > Insights and suggestions are much appreciated. > > > > > > Thanks. > > > > > > Viet-Duc > > > > I looked into this problem and found the cause. > > > > urxvt seems to close stdout while xwin-xdg-menu use select() > > > > to read stdout of the launched apps. Since stdout is closed, > > > > select() returns repeatedly without any output. This causes > > > > high cpu load. > > > > I also confirmed that the following patch for xwin-xdg-menu > > > > resolves the issue. > > [...] > > > Jon, could you please have a look? > > Thanks very much for looking into this, and the patch. > > That looks right. > > I applied the patch, and built and uploaded a xwin-xdg-menu-20210623-1 > > test package. > > Perhaps you could try that, and see if it improves things for you? > > (Similar code is used in XWin, so I also need to make a similar change > > there) > > ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Problem reports: https://cygwin.com/problems.html > > FAQ: https://cygwin.com/faq/ > > Documentation: https://cygwin.com/docs.html > > Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation: https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple