X-Recipient: archive-cygwin AT delorie DOT com
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2AB89386F45E
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=SystematicSw.ab.ca
Authentication-Results: sourceware.org;
 spf=none smtp.mailfrom=brian DOT inglis AT systematicsw DOT ab DOT ca
X-Authority-Analysis: v=2.3 cv=fZA2N3YF c=1 sm=1 tr=0
 a=kiZT5GMN3KAWqtYcXc+/4Q==:117 a=kiZT5GMN3KAWqtYcXc+/4Q==:17
 a=IkcTkHD0fZMA:10 a=jChkm-x5hCMFubTIiR0A:9 a=nqtzIEOVIaXa6As6:21
 a=FL-I0ezlUF9OKG5F:21 a=QEXdDO2ut3YA:10
Subject: Re: cpp /usr/include/threads.h fails; modfl segfaults
To: cygwin AT cygwin DOT com
References: <02b16d2e-9d51-de58-807b-3b31b2565b59 DOT ref AT aol DOT com>
 <02b16d2e-9d51-de58-807b-3b31b2565b59 AT aol DOT com>
 <20200830130005 DOT GR3272 AT calimero DOT vinschen DOT de>
 <eba28e06-139b-0d01-afb5-81a67ba1ad16 AT SystematicSw DOT ab DOT ca>
 <20200831073500 DOT GU3272 AT calimero DOT vinschen DOT de>
 <36f6cc1b-1944-f1b6-b832-33205c08bbae AT SystematicSw DOT ab DOT ca>
 <20200831184517 DOT GF3272 AT calimero DOT vinschen DOT de>
 <140d7709-7db0-6935-15c1-786d392d0f53 AT SystematicSw DOT ab DOT ca>
 <20200831194153 DOT GH3272 AT calimero DOT vinschen DOT de>
From: Brian Inglis <Brian DOT Inglis AT SystematicSw DOT ab DOT ca>
Autocrypt: addr=Brian DOT Inglis AT SystematicSw DOT ab DOT ca; prefer-encrypt=mutual;
 keydata=
 mDMEXopx8xYJKwYBBAHaRw8BAQdAnCK0qv/xwUCCZQoA9BHRYpstERrspfT0NkUWQVuoePa0
 LkJyaWFuIEluZ2xpcyA8QnJpYW4uSW5nbGlzQFN5c3RlbWF0aWNTdy5hYi5jYT6IlgQTFggA
 PhYhBMM5/lbU970GBS2bZB62lxu92I8YBQJeinHzAhsDBQkJZgGABQsJCAcCBhUKCQgLAgQW
 AgMBAh4BAheAAAoJEB62lxu92I8Y0ioBAI8xrggNxziAVmr+Xm6nnyjoujMqWcq3oEhlYGAO
 WacZAQDFtdDx2koSVSoOmfaOyRTbIWSf9/Cjai29060fsmdsDLg4BF6KcfMSCisGAQQBl1UB
 BQEBB0Awv8kHI2PaEgViDqzbnoe8B9KMHoBZLS92HdC7ZPh8HQMBCAeIfgQYFggAJhYhBMM5
 /lbU970GBS2bZB62lxu92I8YBQJeinHzAhsMBQkJZgGAAAoJEB62lxu92I8YZwUBAJw/74rF
 IyaSsGI7ewCdCy88Lce/kdwX7zGwid+f8NZ3AQC/ezTFFi5obXnyMxZJN464nPXiggtT9gN5
 RSyTY8X+AQ==
Organization: Systematic Software
Message-ID: <e36b9548-58b5-b2f7-e5de-7a061c5f38ac@SystematicSw.ab.ca>
Date: Tue, 1 Sep 2020 11:28:51 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200831194153.GH3272@calimero.vinschen.de>
Content-Language: en-CA
X-CMAE-Envelope: MS4wfKywwDmGRCmT4+KgZfat/RsxltOPsAjoMJf+ajx/xCxwC7JwOa77ijtGC/RscZ0+FfgvLABz6TgHT9LBgIUQGRjbNM6pMS+PeInveDm/8Mt0I+5jiAlZ
 I8oF6Wb0GGfGHVvFSIsSE8MM52cCDAU6/AQ1Sg4rnkxiRaHWmHmMfxxXADY34cg5m1cguydgOTUZ9A==
X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,
 SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Reply-To: cygwin AT cygwin DOT com
Content-Type: text/plain; charset="utf-8"
Errors-To: cygwin-bounces AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces AT cygwin DOT com>
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by delorie.com id 081HTMfV010701

On 2020-08-31 13:41, Corinna Vinschen wrote:
> On Aug 31 13:24, Brian Inglis wrote:
>> On 2020-08-31 12:45, Corinna Vinschen wrote:
>>> On Aug 31 09:37, Brian Inglis wrote:
>>>> On 2020-08-31 01:35, Corinna Vinschen wrote:
>>>>> On Aug 30 14:39, Brian Inglis wrote:
>>>>>> On 2020-08-30 07:00, Corinna Vinschen wrote:
>>>>>>> On Aug 29 08:52, airplanemath via Cygwin wrote:
>>>>>>>> I have two reports.  A brief description of the system:
>>>>>>>> $ uname -a | sed "s/${HOSTNAME}/\${HOSTNAME}/g"
>>>>>>>> CYGWIN_NT-10.0 ${HOSTNAME} 3.1.7(0.340/5/3) 2020-08-22 17:48 x86_64 Cygwin
>>>>>> ...
>>>>>>>> $ cat test.c
>>>>>>>> #include <math.h>
>>>>>>>> #include <stdio.h>
>>>>>>>> #include <stdlib.h>
>>>>>>>>
>>>>>>>> int main(int argc, char *argv[]) {
>>>>>>>>   long double a, b, c;
>>>>>>>>   char *num_end = NULL;
>>>>>>>>   a = b = c = 0.0L;
>>>>>>>>   if (argc != 2) {
>>>>>>>>     fprintf(stderr, "Usage: %s NUMBER\n", argv[0]);
>>>>>>>>     exit(1);
>>>>>>>>   }
>>>>>>>>   a = strtold(argv[1], &num_end);
>>>>>>>>   b = modfl(a, &c);
>>>>>>>>   printf("%Lf %Lf %Lf\n", a, b, c);
>>>>>>>>   return 0;
>>>>>>>> }
>>>>>>>
>>>>>>> This is a bug in the assembler code taken from Mingw-w64.  The bug has
>>>>>>> been fixed upstream, so I just pulled in the upstream fixes.
>>>>>>
>>>>>> The 64 bit fix doesn't pop eax but *now* flags eax as clobbered, whereas the 32
>>>>>> bit fix both pops and *now* flags eax as clobbered, which it really doesn't need
>>>>>> to do. Is this inconsistent treatment correct?
>>>>>
>>>>> You may be right that this is not necessary on i686, but it doesn't
>>>>> hurt either and I'd like to stick to the upstream code if possible.
>>>>
>>>> The upstream patch changed only amd64/x86_64 code sequences for multiple modules
>>>> including modfl, and left i386/x86 untouched for those modules.
>>
>> Just pointing out that they only modify their amd64/x86_64 code which doesn't
>> push/pop rax/eax:
> 
> Where are you looking at?  As you could see from my output, I was
> looking at the master branch of the upstream repo.

Sorry I didn't see your point there as I wasn't aware there were SF repos.

> This lengthy discussion for a minor asm snippet doesn't make any sense.
> If you think this is wrong, send patches to cygwin-patches and explain
> where you got it from, preferrably as a git patch from the upstream
> repo.

Sorry for wasting your time.
I was looking at the bug/patch content and didn't realize someone later added a
bogus clobber on their x86 code path.

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in IEC units and prefixes, physical quantities in SI.]
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple